nystudio107\retour\validators\DbStringValidator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	validateAttribute()	0	7	1
A	init()	0	5	2

<?php
/**
 * Retour plugin for Craft CMS
 *
 * Retour allows you to intelligently redirect legacy URLs, so that you don't
 * lose SEO value when rebuilding & restructuring a website
 *
 * @link      https://nystudio107.com/

The tag in position 1 should be the @copyright tag

 * @copyright Copyright (c) 2018 nystudio107

@copyright tag must contain a year and the name of the copyright holder

 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

namespace nystudio107\retour\validators;

use craft\helpers\StringHelper;
use nystudio107\retour\helpers\Text as TextHelper;
use yii\base\InvalidConfigException;
use yii\validators\Validator;

/**

Missing short description in doc comment

 * @author    nystudio107

The tag in position 1 should be the @package tag

Content of the @author tag must be in the form "Display Name <username@example.com>"

Tag value for @author tag indented incorrectly; expected 2 spaces but found 4

 * @package   Retour

Tag value for @package tag indented incorrectly; expected 1 spaces but found 3

 * @since     3.0.0

The tag in position 3 should be the @author tag

Tag value for @since tag indented incorrectly; expected 3 spaces but found 5

 */

Missing @category tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class DbStringValidator extends Validator
{
    /**

Missing short description in doc comment

     * @var null|int
     */
    public ?int $max = null;


    /**

Missing short description in doc comment

     * @inheritdoc
     * @throws InvalidConfigException

Tag value for @throws tag indented incorrectly; expected 5 spaces but found 1

     */

Missing @return tag in function comment

    public function init(): void
    {
        parent::init();
        if ($this->max === null) {
            throw new InvalidConfigException('The "max" property must be set.');
        }
    }

    /**

Missing short description in doc comment

Parameter $model should have a doc-comment as per coding-style.

Parameter $attribute should have a doc-comment as per coding-style.

     * @inheritdoc
     */

Missing @return tag in function comment

    public function validateAttribute($model, $attribute): void
    {
        $value = $model->$attribute;
        $value = TextHelper::cleanupText($value);
        $value = StringHelper::encodeMb4($value);
        $value = TextHelper::truncate($value, $this->max);

It seems like $this->max can also be of type null; however, parameter $length of nystudio107\retour\helpers\Text::truncate() does only seem to accept integer, maybe add an additional type check?

        $model->$attribute = $value;
    }
}