Issues in Recipe.php (v5) - Issues in v5 - nystudio107/craft-recipe - Measure and Improve Code Quality continuously with Scrutinizer

Issues (446)

src/models/Recipe.php (112 issues)

Labels

Severity

<?php
/**
 * Recipe plugin for Craft CMS 3.x
 *
 * A comprehensive recipe FieldType for Craft CMS that includes metric/imperial
 * conversion, portion calculation, and JSON-LD microdata support
 *
 * @link      https://nystudio107.com

 * @copyright Copyright (c) 2017 nystudio107

 */


namespace nystudio107\recipe\models;

use Craft;
use craft\base\Model;
use craft\helpers\StringHelper;
use craft\helpers\Template;
use craft\validators\ArrayValidator;
use Exception;
use nystudio107\recipe\helpers\Json;
use nystudio107\recipe\helpers\PluginTemplate;
use nystudio107\seomatic\models\MetaJsonLd;
use nystudio107\seomatic\Seomatic;
use Twig\Markup;

/**

 * @author    nystudio107

 * @package   Recipe

 * @since     1.0.0

 */

class Recipe extends Model
{
    // Constants
    // =========================================================================

    public const SEOMATIC_PLUGIN_HANDLE = 'seomatic';

    public const MAIN_ENTITY_KEY = 'mainEntityOfPage';

    public const US_RDA = [
        'calories' => 2000,
        'carbohydrateContent' => 275,
        'cholesterolContent' => 300,
        'fatContent' => 78,
        'fiberContent' => 28,
        'proteinContent' => 50,
        'saturatedFatContent' => 20,
        'sodiumContent' => 2300,
        'sugarContent' => 50,
    ];

    // Mapping to convert any of the incorrect plural values
    public const NORMALIZE_PLURALS = [
        'tsps' => 'tsp',
        'tbsps' => 'tbsp',
        'flozs' => 'floz',
        'cups' => 'cups',
        'ozs' => 'oz',
        'lbs' => 'lb',
        'mls' => 'ml',
        'ls' => 'l',
        'mgs' => 'mg',
        'gs' => 'g',
        'kg' => 'kg',
    ];

    // Public Properties
    // =========================================================================

    /**

     * @var string
     */
    public string $name = '';

    /**

     * @var string
     */
    public string $author = '';

    /**

     * @var string
     */
    public string $description = '';

    /**

     * @var string
     */
    public string $keywords = '';

    /**

     * @var string
     */
    public string $recipeCategory = '';

    /**

     * @var string
     */
    public string $recipeCuisine = '';

    /**

     * @var string
     */
    public string $skill = 'intermediate';

    /**

     * @var int
     */
    public int $serves = 1;

    /**

     * @var string
     */
    public string $servesUnit = '';

    /**

     * @var array
     */
    public array $ingredients = [];

    /**

     * @var array
     */
    public array $directions = [];

    /**

     * @var array
     */
    public array $equipment = [];

    /**

     * @var ?int
     */
    public ?int $imageId = null;

    /**

     * @var ?int
     */
    public ?int $videoId = null;

    /**

     * @var int
     */
    public int $prepTime = 0;

    /**

     * @var int
     */
    public int $cookTime = 0;

    /**

     * @var int
     */
    public int $totalTime = 0;

    /**

     * @var ?array
     */
    public ?array $ratings = null;

    /**

     * @var string
     */
    public string $servingSize = '';

    /**

     * @var int
     */
    public int $calories = 0;

    /**

     * @var int
     */
    public int $carbohydrateContent = 0;

    /**

     * @var int
     */
    public int $cholesterolContent = 0;

    /**

     * @var int
     */
    public int $fatContent = 0;

    /**

     * @var int
     */
    public int $fiberContent = 0;

    /**

     * @var int
     */
    public int $proteinContent = 0;

    /**

     * @var int
     */
    public int $saturatedFatContent = 0;

    /**

     * @var int
     */
    public int $sodiumContent = 0;

    /**

     * @var int
     */
    public int $sugarContent = 0;

    /**

     * @var int
     */
    public int $transFatContent = 0;

    /**

     * @var int
     */
    public int $unsaturatedFatContent = 0;

    // Public Methods
    // =========================================================================

    /**

     * @inheritdoc
     */

    public function init(): void
    {
        parent::init();
        // Fix any of the incorrect plural values
        if (!empty($this->ingredients)) {
            foreach ($this->ingredients as &$row) {
                if (!empty($row['units']) && !empty(self::NORMALIZE_PLURALS[$row['units']])) {
                    $row['units'] = self::NORMALIZE_PLURALS[$row['units']];
                }
            }

            unset($row);
        }
    }

    /**

     * @inheritdoc
     */

    public function rules(): array
    {
        return [
            ['name', 'string'],
            ['author', 'string'],
            ['name', 'default', 'value' => ''],
            ['description', 'string'],
            ['keywords', 'string'],
            ['recipeCategory', 'string'],
            ['recipeCuisine', 'string'],
            ['skill', 'string'],
            ['serves', 'integer'],
            ['imageId', 'integer'],
            ['videoId', 'integer'],
            ['prepTime', 'integer'],
            ['cookTime', 'integer'],
            ['totalTime', 'integer'],
            ['servingSize', 'string'],
            ['calories', 'integer'],
            ['carbohydrateContent', 'integer'],
            ['cholesterolContent', 'integer'],
            ['fatContent', 'integer'],
            ['fiberContent', 'integer'],
            ['proteinContent', 'integer'],
            ['saturatedFatContent', 'integer'],
            ['sodiumContent', 'integer'],
            ['sugarContent', 'integer'],
            ['transFatContent', 'integer'],
            ['unsaturatedFatContent', 'integer'],
            [
                [
                    'ingredients',
                    'directions',
                    'equipment',
                ],
                ArrayValidator::class,
            ],

        ];
    }

    /**
     * Return the JSON-LD Structured Data for this recipe
     */

    public function getRecipeJSONLD(): array
    {
        $recipeJSONLD = [
            'context' => 'https://schema.org',
            'type' => 'Recipe',
            'name' => $this->name,
            'image' => $this->getImageUrl(),
            'description' => $this->description,
            'keywords' => $this->keywords,
            'recipeCategory' => $this->recipeCategory,
            'recipeCuisine' => $this->recipeCuisine,
            'recipeYield' => $this->getServes(),
            'recipeIngredient' => $this->getIngredients('imperial', 0, false),
            'recipeInstructions' => $this->getDirections(false),
            'tool' => $this->getEquipment(false),
        ];
        $recipeJSONLD = array_filter($recipeJSONLD);

        if (!empty($this->author)) {
            $author = [
                'type' => 'Person',
                'name' => $this->author,
            ];
            $author = array_filter($author);
            $recipeJSONLD['author'] = $author;
        }

        $videoUrl = $this->getVideoUrl();
        if (!empty($videoUrl)) {
            $video = [
                'type' => 'VideoObject',
                'name' => $this->name,
                'description' => $this->description,
                'contentUrl' => $videoUrl,
                'thumbnailUrl' => $this->getImageUrl(),
                'uploadDate' => $this->getVideoUploadedDate(),
            ];
            $video = array_filter($video);
            $recipeJSONLD['video'] = $video;
        }

        $nutrition = [
            'type' => 'NutritionInformation',
            'servingSize' => $this->servingSize,
            'calories' => $this->calories,
            'carbohydrateContent' => $this->carbohydrateContent,
            'cholesterolContent' => $this->cholesterolContent,
            'fatContent' => $this->fatContent,
            'fiberContent' => $this->fiberContent,
            'proteinContent' => $this->proteinContent,
            'saturatedFatContent' => $this->saturatedFatContent,
            'sodiumContent' => $this->sodiumContent,
            'sugarContent' => $this->sugarContent,
            'transFatContent' => $this->transFatContent,
            'unsaturatedFatContent' => $this->unsaturatedFatContent,
        ];
        $nutrition = array_filter($nutrition);
        $recipeJSONLD['nutrition'] = $nutrition;
        if (count($recipeJSONLD['nutrition']) === 1) {
            unset($recipeJSONLD['nutrition']);
        }

        $aggregateRating = $this->getAggregateRating();
        if ($aggregateRating) {
            $aggregateRatings = [
                'type' => 'AggregateRating',
                'ratingCount' => $this->getRatingsCount(),
                'bestRating' => '5',
                'worstRating' => '1',
                'ratingValue' => $aggregateRating,
            ];
            $aggregateRatings = array_filter($aggregateRatings);
            $recipeJSONLD['aggregateRating'] = $aggregateRatings;

            $reviews = [];
            foreach ($this->ratings as $rating) {
                $review = [
                    'type' => 'Review',
                    'author' => $rating['author'],
                    'name' => $this->name . ' ' . Craft::t('recipe', 'Review'),
                    'description' => $rating['review'],
                    'reviewRating' => [
                        'type' => 'Rating',
                        'bestRating' => '5',
                        'worstRating' => '1',
                        'ratingValue' => $rating['rating'],
                    ],
                ];
                $reviews[] = $review;
            }

            $reviews = array_filter($reviews);
            $recipeJSONLD['review'] = $reviews;
        }

        if ($this->prepTime !== 0) {
            $recipeJSONLD['prepTime'] = 'PT' . $this->prepTime . 'M';
        }

        if ($this->cookTime !== 0) {
            $recipeJSONLD['cookTime'] = 'PT' . $this->cookTime . 'M';
        }

        if ($this->totalTime !== 0) {
            $recipeJSONLD['totalTime'] = 'PT' . $this->totalTime . 'M';
        }

        return $recipeJSONLD;
    }

    /**

     * Create the SEOmatic MetaJsonLd object for this recipe
     *
     * @param null $key

     */

    public function createRecipeMetaJsonLd($key = null, bool $add = true): ?MetaJsonLd
    {
        $result = null;
        if (Craft::$app->getPlugins()->getPlugin(self::SEOMATIC_PLUGIN_HANDLE)) {
            $seomatic = Seomatic::getInstance();
            if ($seomatic !== null) {
                $recipeJson = $this->getRecipeJSONLD();
                // If we're adding the MetaJsonLd to the container, and no key is provided, give it a random key
                if ($add && $key === null) {
                    try {
                        $key = StringHelper::UUID();
                    } catch (Exception) {
                        // That's okay
                    }
                }

                if ($key !== null) {
                    $recipeJson['key'] = $key;
                }

                // If the key is `mainEntityOfPage` add in the URL
                if ($key === self::MAIN_ENTITY_KEY) {
                    $mainEntity = Seomatic::$plugin->jsonLd->get(self::MAIN_ENTITY_KEY);
                    if ($mainEntity !== null) {
                        $recipeJson[self::MAIN_ENTITY_KEY] = $mainEntity[self::MAIN_ENTITY_KEY];
                    }
                }

                $result = Seomatic::$plugin->jsonLd->create(
                    $recipeJson,
                    $add
                );
            }
        }

        return $result;
    }

    /**

     * Render the JSON-LD Structured Data for this recipe
     *
     *
     */

    public function renderRecipeJSONLD(bool $raw = true): string|Markup
    {
        return $this->renderJsonLd($this->getRecipeJSONLD(), $raw);
    }

    /**
     * Get the URL to the recipe's image
     *
     * @param null $transform

     */

    public function getImageUrl($transform = null): ?string
    {
        $result = '';
        if ($this->imageId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $image = Craft::$app->getAssets()->getAssetById($this->imageId);
            if ($image) {
                $result = $image->getUrl($transform);
            }
        }

        return $result;
    }

    /**
     * Get the URL to the recipe's video
     */

    public function getVideoUrl(): ?string
    {
        $result = '';
        if ($this->videoId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $video = Craft::$app->getAssets()->getAssetById($this->videoId);
            if ($video) {
                $result = $video->getUrl();
            }
        }

        return $result;
    }

    /**
     * Get the URL to the recipe's uploaded date
     */

    public function getVideoUploadedDate(): ?string
    {
        $result = '';
        if ($this->videoId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $video = Craft::$app->getAssets()->getAssetById($this->videoId);
            if ($video) {
                $result = $video->dateCreated->format('c');
            }
        }

        return $result;
    }

    /**

     * Render the Nutrition Facts template
     */

    public function renderNutritionFacts(array $rda = self::US_RDA): Markup
    {
        return PluginTemplate::renderPluginTemplate(
            'recipe-nutrition-facts',
            [
                'value' => $this,
                'rda' => $rda,
            ]
        );
    }

    /**

     * Get all the ingredients for this recipe
     */

    public function getIngredients(string $outputUnits = 'imperial', int $serving = 0, bool $raw = true): array
    {
        $result = [];

        foreach ($this->ingredients as $row) {
            $convertedUnits = '';
            $ingredient = '';
            if ($row['quantity']) {
                // Multiply the quantity by how many servings we want
                $multiplier = 1;
                if ($serving > 0) {
                    $multiplier = $serving / $this->serves;
                }

                $quantity = $row['quantity'] * $multiplier;
                $originalQuantity = $quantity;

                // Do the imperial->metric units conversion
                if ($outputUnits === 'imperial') {
                    switch ($row['units']) {
                        case 'ml':

                            $convertedUnits = 'tsp';
                            $quantity *= 0.2;
                            break;
                        case 'l':

                            $convertedUnits = 'cups';
                            $quantity *= 4.2;
                            break;
                        case 'mg':

                            $convertedUnits = 'oz';
                            $quantity *= 0.000035274;
                            break;
                        case 'g':

                            $convertedUnits = 'oz';
                            $quantity *= 0.035274;
                            break;
                        case 'kg':

                            $convertedUnits = 'lb';
                            $quantity *= 2.2046226218;
                            break;
                    }
                }

                // Do the metric->imperial units conversion
                if ($outputUnits === 'metric') {
                    switch ($row['units']) {
                        case 'tsp':

                            $convertedUnits = 'ml';
                            $quantity *= 4.929;
                            break;
                        case 'tbsp':

                            $convertedUnits = 'ml';
                            $quantity *= 14.787;
                            break;
                        case 'floz':

                            $convertedUnits = 'ml';
                            $quantity *= 29.574;
                            break;
                        case 'cups':

                            $convertedUnits = 'l';
                            $quantity *= 0.236588;
                            break;
                        case 'oz':

                            $convertedUnits = 'g';
                            $quantity *= 28.3495;
                            break;
                        case 'lb':

                            $convertedUnits = 'kg';
                            $quantity *= 0.45359237;
                            break;
                    }

                    $quantity = round($quantity, 1);
                }

                // Convert units to nice fractions
                $quantity = $this->convertToFractions($quantity);

                $ingredient .= $quantity;

                if ($row['units']) {
                    $units = $row['units'];
                    if ($convertedUnits !== '' && $convertedUnits !== '0') {
                        $units = $convertedUnits;
                    }

                    if ($originalQuantity <= 1) {
                        $units = rtrim($units);
                        $units = rtrim($units, 's');
                    }

                    $ingredient .= ' ' . $units;
                }
            }

            if ($row['ingredient']) {
                $ingredient .= ' ' . $row['ingredient'];
            }

            if ($raw) {
                $ingredient = Template::raw($ingredient);
            }

            $result[] = $ingredient;
        }

        return $result;
    }

    /**

     * Get all the directions for this recipe
     *
     *
     * @return array

     */
    public function getDirections(bool $raw = true): array
    {
        $result = [];
        foreach ($this->directions as $row) {
            $direction = $row['direction'];
            if ($raw) {
                $direction = Template::raw($direction);
            }

            $result[] = $direction;
        }

        return $result;
    }

    /**

     * Get all the equipment for this recipe
     */

    public function getEquipment(bool $raw = true): array
    {
        $result = [];
        foreach ($this->equipment as $row) {
            $equipment = $row['equipment'];
            if ($raw) {
                $equipment = Template::raw($equipment);
            }

            $result[] = $equipment;
        }

        return $result;
    }

    /**
     * Get the aggregate rating from all the ratings
     */

    public function getAggregateRating(): float|int|string
    {
        $result = 0;
        $total = 0;
        if (!empty($this->ratings)) {
            foreach ($this->ratings as $row) {
                $result += $row['rating'];
                ++$total;
            }

            $result /= $total;
        } else {
            $result = '';
        }

        return $result;
    }

    /**
     * Get the total number of ratings
     */

    public function getRatingsCount(): int
    {
        return count($this->ratings);
        return count(/** @scrutinizer ignore-type */ $this->ratings);
    }

    /**
     * Returns concatenated serves with its unit
     */

    public function getServes(): int|string
    {
        if (!empty($this->servesUnit)) {
            return $this->serves . ' ' . $this->servesUnit;
        }

        return $this->serves;
    }

    /**
     * Convert decimal numbers into fractions
     *
     * @param $quantity

     */

    private function convertToFractions($quantity): string

    {
        $whole = floor($quantity);
        // Round the mantissa so we can do a floating point comparison without
        // weirdness, per: https://www.php.net/manual/en/language.types.float.php#113703
        $fraction = round($quantity - $whole, 3);
        switch ($fraction) {
            case 0:

                $fraction = '';
                break;
            case 0.25:

                $fraction = ' &frac14;';
                break;
            case 0.33:

                $fraction = ' &frac13;';
                break;
            case 0.66:

                $fraction = ' &frac23;';
                break;
            case 0.165:

                $fraction = ' &frac16;';
                break;
            case 0.5:

                $fraction = ' &frac12;';
                break;
            case 0.75:

                $fraction = ' &frac34;';
                break;
            case 0.125:

                $fraction = ' &#x215B;';
                break;
            case 0.375:

                $fraction = ' &#x215C;';
                break;
            case 0.625:

                $fraction = ' &#x215D;';
                break;
            case 0.875:

                $fraction = ' &#x215E;';
                break;
            default:

                $precision = 1;
                $pnum = round($fraction, $precision);
                $denominator = 10 ** $precision;
                $numerator = $pnum * $denominator;
                $fraction = ' <sup>'
                    . $numerator
                    . '</sup>&frasl;<sub>'
                    . $denominator
                    . '</sub>';
                break;
        }

        if ($whole == 0) {
            $whole = '';
        }

        return $whole . $fraction;
    }

    // Private Methods
    // =========================================================================

    /**

     * Renders a JSON-LD representation of the schema
     *
     * @param      $json

     */

    private function renderJsonLd($json, bool $raw = true): string|Markup

    {
        $linebreak = '';

        // If `devMode` is enabled, make the JSON-LD human-readable
        if (Craft::$app->getConfig()->getGeneral()->devMode) {
            $linebreak = PHP_EOL;
        }

        // Render the resulting JSON-LD
        $result = '<script type="application/ld+json">'
            . $linebreak
            . Json::encode($json)
            . $linebreak
            . '</script>';

        if ($raw) {
            $result = Template::raw($result);
        }

        return $result;
    }
}

nystudio107 / craft-recipe

Issues (446)

src/models/Recipe.php (112 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like
