nystudio107 / craft-recipe

src/helpers/PluginTemplate.php

<?php
/**
 * Recipe plugin for Craft CMS 3.x
 *
 * A comprehensive recipe FieldType for Craft CMS that includes metric/imperial
 * conversion, portion calculation, and JSON-LD microdata support
 *
 * @link      https://nystudio107.com

The tag in position 1 should be the @copyright tag

 * @copyright Copyright (c) 2020 nystudio107

@copyright tag must contain a year and the name of the copyright holder

 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

namespace nystudio107\recipe\helpers;

use Craft;
use craft\helpers\Template;
use craft\web\View;
use Twig\Markup;
use yii\base\Exception;

/**

Missing short description in doc comment

 * @author    nystudio107

The tag in position 1 should be the @package tag

Content of the @author tag must be in the form "Display Name <username@example.com>"

Tag value for @author tag indented incorrectly; expected 2 spaces but found 4

 * @package   Recipe

Tag value for @package tag indented incorrectly; expected 1 spaces but found 3

 * @since     1.1.0

The tag in position 3 should be the @author tag

Tag value for @since tag indented incorrectly; expected 3 spaces but found 5

 */

Missing @category tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class PluginTemplate
{
    // Static Methods
    // =========================================================================

    public static function renderStringTemplate(string $templateString, array $params = []): string

You must use "/**" style comments for a function comment

    {
        try {
            $html = Craft::$app->getView()->renderString($templateString, $params);
        } catch (\Exception $exception) {
            $html = Craft::t(
                'recipe',
                'Error rendering template string -> {error}',
                ['error' => $exception->getMessage()]
            );
            Craft::error($html, __METHOD__);
        }

        return $html;
    }

    /**
     * Render a plugin template
     *
     * @param string $templatePath

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @param array $params

Missing parameter comment

Expected 2 spaces after parameter type; 1 found

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return Markup

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public static function renderPluginTemplate(string $templatePath, array $params = []): Markup
    {
        $exception = null;
        $htmlText = '';

The assignment to $htmlText is dead and can be removed.

        // Stash the old template mode, and set it Control Panel template mode
        $oldMode = Craft::$app->view->getTemplateMode();
        // Look for a frontend template to render first
        try {
            Craft::$app->view->setTemplateMode(View::TEMPLATE_MODE_SITE);
        } catch (Exception $exception) {
            Craft::error($exception->getMessage(), __METHOD__);
        }

        // Render the template with our vars passed in
        try {
            $htmlText = Craft::$app->view->renderTemplate('recipe/' . $templatePath, $params);
            $templateRendered = true;
        } catch (\Exception $exception) {
            $templateRendered = false;
        }

        // If no frontend template was found, try our built-in template
        if (!$templateRendered) {
            try {
                Craft::$app->view->setTemplateMode(View::TEMPLATE_MODE_CP);
            } catch (Exception $exception) {
                Craft::error($exception->getMessage(), __METHOD__);
            }

            // Render the template with our vars passed in
            try {
                $htmlText = Craft::$app->view->renderTemplate('recipe/' . $templatePath, $params);
                $templateRendered = true;
            } catch (\Exception $exception) {
                $templateRendered = false;
            }
        }

        // Only if the template didn't render at all should we log an error
        if (!$templateRendered) {
            $htmlText = Craft::t(
                'recipe',
                'Error rendering `{template}` -> {error}',
                ['template' => $templatePath, 'error' => $exception->getMessage()]

The method getMessage() does not exist on null.

            );
            Craft::error($htmlText, __METHOD__);
        }

        // Restore the old template mode
        try {
            Craft::$app->view->setTemplateMode($oldMode);
        } catch (Exception $exception) {
            Craft::error($exception->getMessage(), __METHOD__);
        }

        return Template::raw($htmlText);
    }
}