ViteService::fetchFile() - Code Metrics - Inspection of "Merge branch 'release/1.0.2' into v1" - nystudio107/craft-plugin-vite - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v1 ( 740a10...974e3b )

by Andrew

created 2021-05-07 04:27 UTC

ViteService::fetchFile() B

↳ Parent: ViteService

Complexity

Conditions	8
Paths	4

Size

Total Lines	70
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	8
eloc	45
c	3
b	0
f	0
nc	4
nop	2
dl	0
loc	70
rs	7.9555

How to fix Long Method

<?php
/**
 * Vite plugin for Craft CMS 3.x
 *
 * Allows the use of the Vite.js next generation frontend tooling with Craft CMS
 *
 * @link      https://nystudio107.com

 * @copyright Copyright (c) 2021 nystudio107

 */


namespace nystudio107\pluginvite\services;

use Craft;
use craft\base\Component;
use craft\helpers\Html as HtmlHelper;
use craft\helpers\Json as JsonHelper;
use craft\helpers\UrlHelper;

use yii\base\InvalidConfigException;
use yii\caching\ChainedDependency;
use yii\caching\FileDependency;
use yii\caching\TagDependency;

use GuzzleHttp\Client;
use GuzzleHttp\RequestOptions;

/**

 * @author    nystudio107

 * @package   Vite

 * @since     1.0.0

 */

class ViteService extends Component
{
    // Constants
    // =========================================================================

    const VITE_CLIENT = '@vite/client.js';
    const LEGACY_EXTENSION = '-legacy.';
    const LEGACY_POLYFILLS = 'vite/legacy-polyfills';

    const CACHE_KEY = 'vite';
    const CACHE_TAG = 'vite';

    const DEVMODE_CACHE_DURATION = 1;

    const USER_AGENT_STRING = 'User-Agent:Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13';

    const SAFARI_NOMODULE_FIX = '!function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();';

    // Public Properties
    // =========================================================================

    /**

     * @var bool Should the dev server be used for?
     */
    public $useDevServer;

    /**

     * @var string File system path (or URL) to the Vite-built manifest.json
     */
    public $manifestPath;

    /**

     * @var string The public URL to the dev server (what appears in `<script src="">` tags
     */
    public $devServerPublic;

    /**

     * @var string The public URL to use when not using the dev server
     */
    public $serverPublic;

    /**

     * @var string String to be appended to the cache key
     */
    public $cacheKeySuffix = '';

    // Protected Properties
    // =========================================================================

    /**

     * @var bool Whether any legacy tags were found in this request
     */
    protected $hasLegacyTags = false;

    /**

     * @var bool Whether the legacy polyfill has been included yet or not
     */
    protected $legacyPolyfillIncluded = false;

    // Public Methods
    // =========================================================================

    /**
     * Return the appropriate tags to load the Vite script, either via the dev server or
     * extracting it from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return string
     */
    public function script(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = []): string
    {
        if ($this->useDevServer) {
            return $this->devServerScript($path, $scriptTagAttrs);
        }

        return $this->manifestScript($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
    }

    /**
     * Return the script tag to load the script from the Vite dev server
     *
     * @param string $path

     * @param array $scriptTagAttrs

     *
     * @return string
     */
    public function devServerScript(string $path, array $scriptTagAttrs = []): string
    {
        $lines = [];
        // Include the entry script
        $url = $this->createUrl($this->devServerPublic, $path);
        $lines[] = HtmlHelper::jsFile($url, array_merge([

            'type' => 'module',
        ], $scriptTagAttrs));
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

        return implode("\r\n", $lines);
    }

    /**
     * Return the script, module link, and CSS link tags for the script from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return string
     */
    public function manifestScript(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = []): string
    {
        $lines = [];
        $tags = $this->manifestTags($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
        // Handle any legacy polyfills
        if ($this->hasLegacyTags && !$this->legacyPolyfillIncluded) {
            $lines[] = HtmlHelper::script(self::SAFARI_NOMODULE_FIX, []);
            $legacyPolyfillTags = $this->extractManifestTags(self::LEGACY_POLYFILLS, $asyncCss, $scriptTagAttrs, $cssTagAttrs, true);
            $tags = array_merge($legacyPolyfillTags, $tags);
            $this->legacyPolyfillIncluded = true;
        }
        foreach($tags as $tag) {

            if (!empty($tag)) {
                switch ($tag['type']) {
                    case 'file':

                        $lines[] = HtmlHelper::jsFile($tag['url'], $tag['options']);
                        break;
                    case 'css':

                        $lines[] = HtmlHelper::cssFile($tag['url'], $tag['options']);
                        break;
                    default:

                        break;
                }
            }
        }

        return implode("\r\n", $lines);
    }

    /**
     * Register the appropriate tags to the Craft View to load the Vite script, either via the dev server or
     * extracting it from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return void
     * @throws InvalidConfigException
     */
    public function register(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = [])
    {
        if ($this->useDevServer) {
            $this->devServerRegister($path, $scriptTagAttrs);

            return;
        }

        $this->manifestRegister($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
    }

    /**
     * Register the script tag to the Craft View to load the script from the Vite dev server
     *
     * @param string $path

     * @param array $scriptTagAttrs

     *
     * @return void
     */
    public function devServerRegister(string $path, array $scriptTagAttrs = [])
    {
        $view = Craft::$app->getView();
        // Include the entry script
        $url = $this->createUrl($this->devServerPublic, $path);
        $view->registerScript('', $view::POS_HEAD, array_merge([

            'type' => 'module',
            'src' => $url,
            ], $scriptTagAttrs));
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    /**
     * Register the script, module link, and CSS link tags to the Craft View for the script from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return void
     * @throws InvalidConfigException
     */
    public function manifestRegister(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = [])
    {
        $view = Craft::$app->getView();
        $tags = $this->manifestTags($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
        // Handle any legacy polyfills
        if ($this->hasLegacyTags && !$this->legacyPolyfillIncluded) {
            $view->registerScript(self::SAFARI_NOMODULE_FIX, $view::POS_HEAD, [], 'SAFARI_NOMODULE_FIX');
            $legacyPolyfillTags = $this->extractManifestTags(self::LEGACY_POLYFILLS, $asyncCss, $scriptTagAttrs, $cssTagAttrs, true);
            $tags = array_merge($legacyPolyfillTags, $tags);
            $this->legacyPolyfillIncluded = true;
        }
        foreach($tags as $tag) {

            if (!empty($tag)) {
                switch ($tag['type']) {
                    case 'file':

                        $view->registerScript(
                            '',
                            $view::POS_HEAD,
                            array_merge(['src' => $tag['url']], $tag['options']),
                            md5($tag['url'] . json_encode($tag['options']))
                        );
                        break;
                    case 'css':

                        $view->registerCssFile($tag['url'], $tag['options']);
                        break;
                    default:

                        break;
                }
            }
        }
    }

    /**
     * Invalidate all of the Vite caches
     */

    public function invalidateCaches()
    {
        $cache = Craft::$app->getCache();
        TagDependency::invalidate($cache, self::CACHE_TAG . $this->cacheKeySuffix);
        Craft::info('All Vite caches cleared', __METHOD__);
    }

    // Protected Methods
    // =========================================================================

    /**
     * Return an array of tags from the manifest, for both modern and legacy builds
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return array
     */
    protected function manifestTags(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = []): array
    {
        // Get the modern tags for this $path
        $tags = $this->extractManifestTags($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs, false);
        // Look for a legacy version of this $path too
        $parts = pathinfo($path);
        $legacyPath = $parts['dirname']
            . '/'
            . $parts['filename']
            . self::LEGACY_EXTENSION
            . $parts['extension'];
        $legacyTags = $this->extractManifestTags($legacyPath, $asyncCss, $scriptTagAttrs, $cssTagAttrs, true);
        // Set a flag to indicate the some legacy gets were found
        $legacyPolyfillTags = [];
        if (!empty($legacyTags)) {
            $this->hasLegacyTags = true;
        }
        return array_merge(
            $legacyPolyfillTags,
            $tags,
            $legacyTags
        );
    }

    /**

     * Return an array of data describing the  script, module link, and CSS link tags for the
     * script from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return array
     */
    protected function extractManifestTags(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = [], $legacy = false): array
    {
        $tags = [];
        // Grab the manifest
        $pathOrUrl = (string)Craft::parseEnv($this->manifestPath);
        $manifest = $this->fetchFile($pathOrUrl, [JsonHelper::class, 'decodeIfJson']);
        // If no manifest file is found, bail
        if ($manifest === null) {
            Craft::error('Manifest not found at ' . $this->manifestPath, __METHOD__);

            return [];
        }
        // Set the async CSS args
        $asyncCssOptions = [];
        if ($asyncCss) {
            $asyncCssOptions = [
                'media' => 'print',
                'onload' => "this.media='all'",
            ];
        }
        // Set the script args
        $scriptOptions = [
            'type' => 'module',
            'crossorigin' => true,
        ];
        if ($legacy) {
            $scriptOptions = [
                'type' => 'nomodule',
            ];
        }
        // Iterate through the manifest
        foreach ($manifest as $manifestKey => $entry) {
            if (isset($entry['isEntry']) && $entry['isEntry']) {
                // Include the entry script
                if (isset($entry['file']) && strpos($path, $manifestKey) !== false) {
                    $tags[] = [
                        'type' => 'file',
                        'url' => $this->createUrl($this->serverPublic, $entry['file']),
                        'options' => array_merge($scriptOptions, $scriptTagAttrs)
                    ];
                    // Include any CSS tags
                    $cssFiles = [];
                    $this->extractCssFiles($manifest, $manifestKey, $cssFiles);
                    foreach ($cssFiles as $cssFile) {
                        $tags[] = [
                            'type' => 'css',
                            'url' => $this->createUrl($this->serverPublic, $cssFile),
                            'options' => array_merge([

                                'rel' => 'stylesheet',
                            ], $asyncCssOptions, $cssTagAttrs)
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                        ];
                    }
                }
            }
        }

        return $tags;
    }

    /**
     * Extract any CSS files from entries recursively
     *
     * @param array $manifest

     * @param string $manifestKey

     * @param array $cssFiles

     */

    protected function extractCssFiles(array $manifest, string $manifestKey, array &$cssFiles)
    {
        if (isset($manifest[$manifestKey])) {
            $entry = $manifest[$manifestKey];
            // Handle any CSS files
            if (isset($entry['css'])) {
                foreach ($entry['css'] as $css) {
                    $cssFiles[] = $css;
                }
            }
            //  Handle imports recursively
            if (isset($entry['imports'])) {
                foreach ($entry['imports'] as $import) {
                    $this->extractCssFiles($manifest, $import, $cssFiles);
                }
            }
            //  Handle dynamic imports recursively
            if (isset($entry['dynamicImports'])) {
                foreach ($entry['dynamicImports'] as $dynamicImport) {
                    $this->extractCssFiles($manifest, $dynamicImport, $cssFiles);
                }
            }
        }
    }

    /**
     * Combine a path with a URL to create a URL
     *
     * @param string $url

     * @param string $path

     *
     * @return string
     */
    protected function createUrl(string $url, string $path): string
    {
        $url = (string)Craft::parseEnv($url);
        return rtrim($url, '/') . '/' . trim($path, '/');
    }

    /**
     * Return the contents of a local or remote file, or null
     *
     * @param string $pathOrUrl

     * @param callable|null $callback

     * @return mixed

     */
    protected function fetchFile(string $pathOrUrl, callable $callback = null)
    {
        // Create the dependency tags
        $dependency = new TagDependency([

            'tags' => [
                self::CACHE_TAG . $this->cacheKeySuffix,
                self::CACHE_TAG . $this->cacheKeySuffix . $pathOrUrl,
            ],
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
        // If this is a file path such as for the `manifest.json`, add a FileDependency so it's cache bust if the file changes
        if (!UrlHelper::isAbsoluteUrl($pathOrUrl)) {
            $dependency = new ChainedDependency([

                'dependencies' => [
                    new FileDependency([

                        'fileName' => $pathOrUrl
                    ]),
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                    $dependency
                ]
            ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
        }
        // Set the cache duration based on devMode
        $cacheDuration = Craft::$app->getConfig()->getGeneral()->devMode
            ? self::DEVMODE_CACHE_DURATION
            : null;
        // Get the result from the cache, or parse the file
        $cache = Craft::$app->getCache();
        $file = $cache->getOrSet(
            self::CACHE_KEY . $this->cacheKeySuffix . $pathOrUrl,
            function () use ($pathOrUrl, $callback) {
                $contents = null;
                $result = null;
                if (UrlHelper::isAbsoluteUrl($pathOrUrl)) {
                    // See if we can connect to the server
                    $clientOptions = [
                        RequestOptions::HTTP_ERRORS => false,
                        RequestOptions::CONNECT_TIMEOUT => 3,
                        RequestOptions::VERIFY => false,
                        RequestOptions::TIMEOUT => 5,
                    ];
                    $client = new Client($clientOptions);
                    try {
                        $response = $client->request('GET', $pathOrUrl, [

                            RequestOptions::HEADERS => [
                                'User-Agent' => self::USER_AGENT_STRING,
                                'Accept' => '*/*',
                            ],
                        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                        if ($response->getStatusCode() === 200) {
                            $contents = $response->getBody()->getContents();
                        }
                    } catch (\Throwable $e) {
                        Craft::error($e, __METHOD__);
                    }
                } else {
                    $contents = @file_get_contents($pathOrUrl);
                }
                if ($contents) {
                    $result = $contents;
                    if ($callback) {
                        $result = $callback($result);
                    }
                }

                return $result;
            },
            $cacheDuration,
            $dependency
        );

        return $file;
    }
}


1			<?php
2			/**
3			* Vite plugin for Craft CMS 3.x
4			*
5			* Allows the use of the Vite.js next generation frontend tooling with Craft CMS
6			*
7			* @link https://nystudio107.com
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @copyright tag Loading history...
8			* @copyright Copyright (c) 2021 nystudio107
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report @copyright tag must contain a year and the name of the copyright holder Loading history...
9			*/
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
10
11			namespace nystudio107\pluginvite\services;
12
13			use Craft;
14			use craft\base\Component;
15			use craft\helpers\Html as HtmlHelper;
16			use craft\helpers\Json as JsonHelper;
17			use craft\helpers\UrlHelper;
18
19			use yii\base\InvalidConfigException;
20			use yii\caching\ChainedDependency;
21			use yii\caching\FileDependency;
22			use yii\caching\TagDependency;
23
24			use GuzzleHttp\Client;
25			use GuzzleHttp\RequestOptions;
26
27			/**
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
28			* @author nystudio107
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @package tag Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Content of the @author tag must be in the form "Display Name <[email protected]>" Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Tag value for @author tag indented incorrectly; expected 2 spaces but found 4 Loading history...
29			* @package Vite
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Tag value for @package tag indented incorrectly; expected 1 spaces but found 3 Loading history...
30			* @since 1.0.0
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report The tag in position 3 should be the @author tag Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Tag value for @since tag indented incorrectly; expected 3 spaces but found 5 Loading history...
31			*/
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
32			class ViteService extends Component

nystudio107 / craft-plugin-vite

Push — v1 ( 740a10...974e3b )

ViteService::fetchFile() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like