ViteService::manifestScript() - Code Metrics - Inspection of "Refactor to a single tag loop, possible because on..." - nystudio107/craft-plugin-vite - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 059ea9...a64540 )

by Andrew

created 2021-08-10 17:04 UTC

ViteService::manifestScript() B

↳ Parent: ViteService

Complexity

Conditions	10
Paths	36

Size

Total Lines	52
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	9
Bugs	0	Features	1

Metric	Value
cc	10
eloc	35
c	9
b	0
f	1
nc	36
nop	4
dl	0
loc	52
rs	7.6666

How to fix Long Method Complexity

<?php
/**
 * Vite plugin for Craft CMS 3.x
 *
 * Allows the use of the Vite.js next generation frontend tooling with Craft CMS
 *
 * @link      https://nystudio107.com

 * @copyright Copyright (c) 2021 nystudio107

 */


namespace nystudio107\pluginvite\services;

use nystudio107\pluginvite\helpers\FileHelper;
use nystudio107\pluginvite\helpers\ManifestHelper;

use Craft;
use craft\base\Component;
use craft\helpers\Html as HtmlHelper;
use craft\helpers\Json as JsonHelper;
use craft\web\View;

use yii\base\InvalidConfigException;
use yii\caching\TagDependency;

use Throwable;

/**

 * @author    nystudio107

 * @package   Vite

 * @since     1.0.0

 */

class ViteService extends Component
{
    // Constants
    // =========================================================================

    const VITE_CLIENT = '@vite/client';
    const LEGACY_POLYFILLS = 'vite/legacy-polyfills';

    // Public Properties
    // =========================================================================

    /**

     * @var bool Should the dev server be used for?
     */
    public $useDevServer;

    /**

     * @var string File system path (or URL) to the Vite-built manifest.json
     */
    public $manifestPath;

    /**

     * @var string The public URL to the dev server (what appears in `<script src="">` tags
     */
    public $devServerPublic;

    /**

     * @var string The public URL to use when not using the dev server
     */
    public $serverPublic;

    /**

     * @var string The JavaScript entry from the manifest.json to inject on Twig error pages
     *              This can be a string or an array of strings
     */
    public $errorEntry = '';

    /**

     * @var string String to be appended to the cache key
     */
    public $cacheKeySuffix = '';

    /**

     * @var string The internal URL to the dev server, when accessed from the environment in which PHP is executing
     *              This can be the same as `$devServerPublic`, but may be different in containerized or VM setups.
     *              ONLY used if $checkDevServer = true
     */
    public $devServerInternal;

    /**

     * @var bool Should we check for the presence of the dev server by pinging $devServerInternal to make sure it's running?
     */
    public $checkDevServer = false;

    /**

     * @var bool Whether the react-refresh-shim should be included
     */
    public $includeReactRefreshShim = false;

    // Protected Properties
    // =========================================================================

    /**

     * @var bool Whether the manifest shims has been included yet or not
     */
    protected $manifestShimsIncluded = false;

    /**

     * @var bool Whether the dev server shims has been included yet or not
     */
    protected $devServerShimsIncluded = false;

    /**

     * @var bool Whether the modulepreload polyfill has been included yet or not
     */
    protected $modulepreloadPolyfillIncluded = false;

    // Public Methods
    // =========================================================================

    /**

     * @inheritDoc
     */

    public function init()
    {
        parent::init();
        // Do nothing for console requests
        $request = Craft::$app->getRequest();
        if ($request->getIsConsoleRequest()) {
            return;
        }
        // Our component is lazily loaded, so the View will be instantiated by now
        if (Craft::$app->getConfig()->getGeneral()->devMode) {
            Craft::$app->getView()->on(View::EVENT_END_BODY, [$this, 'injectErrorEntry']);
        }
    }

    /**
     * Return the appropriate tags to load the Vite script, either via the dev server or
     * extracting it from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return string
     */
    public function script(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = []): string
    {
        if ($this->devServerRunning()) {
            return $this->devServerScript($path, $scriptTagAttrs);
        }

        return $this->manifestScript($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
    }

    /**
     * Return the script tag to load the script from the Vite dev server
     *
     * @param string $path

     * @param array $scriptTagAttrs

     *
     * @return string
     */
    public function devServerScript(string $path, array $scriptTagAttrs = []): string
    {
        $lines = [];
        // Include any dev server shims
        if (!$this->devServerShimsIncluded) {
            // Include the react-refresh-shim
            if ($this->includeReactRefreshShim) {
                $script = FileHelper::fetchScript('react-refresh-shim.min.js', $this->cacheKeySuffix);
                // Replace the hard-coded dev server URL with whatever they have theirs set to
                $script = str_replace(
                    'http://localhost:3000/',
                    rtrim($this->devServerPublic, '/') . '/',
                    $script
                );
                $lines[] = HtmlHelper::script(
                    $script,
                    [
                        'type' => 'module',
                    ]
                );
            }
            $this->devServerShimsIncluded = true;
        }
        // Include the entry script
        $url = FileHelper::createUrl($this->devServerPublic, $path);
        $lines[] = HtmlHelper::jsFile($url, array_merge([

            'type' => 'module',
        ], $scriptTagAttrs));
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

        return implode("\r\n", $lines);
    }

    /**
     * Return the script, module link, and CSS link tags for the script from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return string
     */
    public function manifestScript(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = []): string
    {
        $lines = [];
        ManifestHelper::fetchManifest($this->manifestPath);
        $tags = ManifestHelper::manifestTags($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
        $legacyTags = ManifestHelper::legacyManifestTags($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
        // Include any manifest shims
        if (!$this->manifestShimsIncluded) {
            // Handle any legacy polyfills
            if (!empty($legacyTags)) {
                $lines[] = HtmlHelper::script(
                    FileHelper::fetchScript('safari-nomodule-fix.min.js', $this->cacheKeySuffix),
                    []
                );
                $legacyPolyfillTags = ManifestHelper::extractManifestTags(self::LEGACY_POLYFILLS, $asyncCss, $scriptTagAttrs, $cssTagAttrs, true);
                $tags = array_merge($legacyPolyfillTags, $tags);
            }
            $this->manifestShimsIncluded = true;
        }

        foreach (array_merge($tags, $legacyTags) as $tag) {
            if (!empty($tag)) {
                $url = FileHelper::createUrl($this->serverPublic, $tag['url']);
                switch ($tag['type']) {
                    case 'file':

                        $lines[] = HtmlHelper::jsFile($url, $tag['options']);
                        break;
                    case 'css':

                        $lines[] = HtmlHelper::cssFile($url, $tag['options']);
                        break;
                    case 'import':

                        $lines[] = HtmlHelper::tag('link', '', [

                            'crossorigin' => $tag['crossorigin'],
                            'href' => $url,
                            'rel' => 'modulepreload',
                        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                        break;
                    default:

                        break;
                }
            }
        }

        if ($modulepreloadPolyfillRequired && !$this->modulepreloadPolyfillIncluded) {

            $this->modulepreloadPolyfillIncluded = true;
            $lines[] = HtmlHelper::script(
                FileHelper::fetchScript('modulepreload-polyfill.min.js', $this->cacheKeySuffix),
                ['type' => 'module']
            );
        }

        return implode("\r\n", $lines);
    }

    /**
     * Register the appropriate tags to the Craft View to load the Vite script, either via the dev server or
     * extracting it from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return void
     * @throws InvalidConfigException
     */
    public function register(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = [])
    {
        if ($this->devServerRunning()) {
            $this->devServerRegister($path, $scriptTagAttrs);

            return;
        }

        $this->manifestRegister($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
    }

    /**
     * Register the script tag to the Craft View to load the script from the Vite dev server
     *
     * @param string $path

     * @param array $scriptTagAttrs

     *
     * @return void
     * @throws InvalidConfigException
     */
    public function devServerRegister(string $path, array $scriptTagAttrs = [])
    {
        $view = Craft::$app->getView();
        // Include any dev server shims
        if (!$this->devServerShimsIncluded) {
            // Include the react-refresh-shim
            if ($this->includeReactRefreshShim) {
                $script = FileHelper::fetchScript('react-refresh-shim.min.js', $this->cacheKeySuffix);
                // Replace the hard-coded dev server URL with whatever they have theirs set to
                $script = str_replace(
                    'http://localhost:3000/',
                    rtrim($this->devServerPublic, '/') . '/',
                    $script
                );
                $view->registerScript(
                    $script,
                    $view::POS_HEAD,
                    [
                        'type' => 'module',
                    ],
                    'REACT_REFRESH_SHIM'
                );
            }
            $this->devServerShimsIncluded = true;
        }
        // Include the entry script
        $url = FileHelper::createUrl($this->devServerPublic, $path);
        $view->registerJsFile(
            $url,
            array_merge(['type' => 'module'], $scriptTagAttrs),
            md5($url . JsonHelper::encode($scriptTagAttrs))
        );
    }

    /**
     * Register the script, module link, and CSS link tags to the Craft View for the script from the manifest.json file
     *
     * @param string $path

     * @param bool $asyncCss

     * @param array $scriptTagAttrs

     * @param array $cssTagAttrs

     *
     * @return void
     * @throws InvalidConfigException
     */
    public function manifestRegister(string $path, bool $asyncCss = true, array $scriptTagAttrs = [], array $cssTagAttrs = [])
    {
        $view = Craft::$app->getView();
        ManifestHelper::fetchManifest($this->manifestPath);
        $tags = ManifestHelper::manifestTags($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
        $legacyTags = ManifestHelper::legacyManifestTags($path, $asyncCss, $scriptTagAttrs, $cssTagAttrs);
        // Include any manifest shims
        if (!$this->manifestShimsIncluded) {
            // Handle any legacy polyfills
            if (!empty($legacyTags)) {
                $view->registerScript(
                    FileHelper::fetchScript('safari-nomodule-fix.min.js', $this->cacheKeySuffix),
                    $view::POS_HEAD,
                    [],
                    'SAFARI_NOMODULE_FIX'
                );
                $legacyPolyfillTags = ManifestHelper::extractManifestTags(self::LEGACY_POLYFILLS, $asyncCss, $scriptTagAttrs, $cssTagAttrs, true);
                $tags = array_merge($legacyPolyfillTags, $tags);
            }
            $this->manifestShimsIncluded = true;
        }
        foreach (array_merge($tags, $legacyTags) as $tag) {
            if (!empty($tag)) {
                $url = FileHelper::createUrl($this->serverPublic, $tag['url']);
                switch ($tag['type']) {
                    case 'file':

                        $view->registerJsFile(
                            $url,
                            $tag['options'],
                            md5($url . JsonHelper::encode($tag['options']))
                        );
                        break;
                    case 'css':

                        $view->registerCssFile(
                            $url,
                            $tag['options']
                        );
                        break;
                    case 'import':

                        $view->registerLinkTag(
                            [
                                'crossorigin' => $tag['crossorigin'],
                                'href' => $url,
                                'rel' => 'modulepreload',
                            ],
                            md5($url)
                        );
                        break;
                    default:

                        break;
                }
            }
        }

        if ($modulepreloadPolyfillRequired && !$this->modulepreloadPolyfillIncluded) {

            $this->modulepreloadPolyfillIncluded = true;
            $view->registerScript(
                FileHelper::fetchScript('modulepreload-polyfill.min.js', $this->cacheKeySuffix),
                $view::POS_HEAD,
                ['type' => 'module'],
                'MODULEPRELOAD_POLYFILL'
            );
        }
    }

    /**
     * Return the contents of a local file (via path) or remote file (via URL),
     * or null if the file doesn't exist or couldn't be fetched
     * Yii2 aliases and/or environment variables may be used
     *
     * @param string $pathOrUrl

     * @param callable|null $callback

     *
     * @return string|array|null
     */
    public function fetch(string $pathOrUrl, callable $callback = null)
    {
        return FileHelper::fetch($pathOrUrl, $callback, $this->cacheKeySuffix);
    }

    /**
     * Determine whether the Vite dev server is running
     *
     * @return bool
     */
    public function devServerRunning(): bool
    {
        // If the dev server is turned off via config, say it's not running
        if (!$this->useDevServer) {
            return false;
        }
        // If we're not supposed to check that the dev server is actually running, just assume it is
        if (!$this->checkDevServer) {
            return true;
        }
        // Check to see if the dev server is actually running by pinging it
        $url = FileHelper::createUrl($this->devServerInternal, self::VITE_CLIENT);

        return !($this->fetch($url) === null);
    }

    /**
     * Invalidate all of the Vite caches
     */

    public function invalidateCaches()
    {
        $cache = Craft::$app->getCache();
        TagDependency::invalidate($cache, FileHelper::CACHE_TAG . $this->cacheKeySuffix);
        Craft::info('All Vite caches cleared', __METHOD__);
    }

    // Protected Methods
    // =========================================================================

    /**
     * Inject the error entry point JavaScript for auto-reloading of Twig error
     * pages
     */

    protected function injectErrorEntry()
    {
        // If there's no error entry provided, return
        if (empty($this->errorEntry)) {
            return;
        }
        // If it's not a server error or a client error, return
        $response = Craft::$app->getResponse();
        if (!($response->isServerError || $response->isClientError)) {
            return;
        }
        // If the dev server isn't running, return
        if (!$this->devServerRunning()) {
            return;
        }
        // Inject the errorEntry script tags to enable HMR on this page
        try {
            $errorEntry = $this->errorEntry;
            if (is_string($errorEntry)) {

                $errorEntry = [$errorEntry];
            }
            foreach ($errorEntry as $entry) {
                $tag = $this->script($entry);
                if ($tag !== null) {
                    echo $tag;
                }
            }
        } catch (Throwable $e) {
            // That's okay, Vite will have already logged the error
        }
    }
}


1			<?php
2			/**
3			* Vite plugin for Craft CMS 3.x
4			*
5			* Allows the use of the Vite.js next generation frontend tooling with Craft CMS
6			*
7			* @link https://nystudio107.com
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @copyright tag Loading history...
8			* @copyright Copyright (c) 2021 nystudio107
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report @copyright tag must contain a year and the name of the copyright holder Loading history...
9			*/
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
10
11			namespace nystudio107\pluginvite\services;
12
13			use nystudio107\pluginvite\helpers\FileHelper;
14			use nystudio107\pluginvite\helpers\ManifestHelper;
15
16			use Craft;
17			use craft\base\Component;
18			use craft\helpers\Html as HtmlHelper;
19			use craft\helpers\Json as JsonHelper;
20			use craft\web\View;
21
22			use yii\base\InvalidConfigException;
23			use yii\caching\TagDependency;
24
25			use Throwable;
26
27			/**
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
28			* @author nystudio107
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @package tag Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Content of the @author tag must be in the form "Display Name <[email protected]>" Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Tag value for @author tag indented incorrectly; expected 2 spaces but found 4 Loading history...
29			* @package Vite
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Tag value for @package tag indented incorrectly; expected 1 spaces but found 3 Loading history...
30			* @since 1.0.0
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report The tag in position 3 should be the @author tag Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Tag value for @since tag indented incorrectly; expected 3 spaces but found 5 Loading history...
31			*/
			0 ignored issues – show Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2021-05-04 23:39 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
32			class ViteService extends Component

nystudio107 / craft-plugin-vite

Push — develop ( 059ea9...a64540 )

ViteService::manifestScript() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like