nystudio107 / craft-minify

src/twigextensions/MinifyTokenParser.php

<?php
/**
 * Minify plugin for Craft CMS
 *
 * @link      https://nystudio107.com/

The tag in position 1 should be the @copyright tag

 * @copyright Copyright (c) nystudio107

@copyright tag must contain a year and the name of the copyright holder

 * @license   MIT License https://opensource.org/licenses/MIT
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

namespace nystudio107\minify\twigextensions;

use Twig\Error\SyntaxError;
use Twig\Token;
use Twig\TokenParser\AbstractTokenParser;

/**
 * Minify twig token parser
 *
 * @author    nystudio107

The tag in position 1 should be the @package tag

Content of the @author tag must be in the form "Display Name <username@example.com>"

Tag value for @author tag indented incorrectly; expected 2 spaces but found 4

 * @package   Minify

Tag value for @package tag indented incorrectly; expected 1 spaces but found 3

 * @since     1.2.0

The tag in position 3 should be the @author tag

Tag value for @since tag indented incorrectly; expected 3 spaces but found 5

 */

Missing @category tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class MinifyTokenParser extends AbstractTokenParser
{
    // Public Methods
    // =========================================================================

    /**
     * Parses {% minify %}...{% endminify %} tags
     *
     * @param Token $token

Missing parameter comment

     *
     * @return MinifyNode
     * @throws SyntaxError
     */
    public function parse(Token $token): MinifyNode
    {
        $lineNo = $token->getLine();
        $stream = $this->parser->getStream();

        $attributes = [
            'html' => false,
            'css' => false,
            'js' => false,
        ];

        if ($stream->test(Token::NAME_TYPE, 'html')) {
            $attributes['html'] = true;
            $stream->next();
        }

        if ($stream->test(Token::NAME_TYPE, 'css')) {
            $attributes['css'] = true;
            $stream->next();
        }

        if ($stream->test(Token::NAME_TYPE, 'js')) {
            $attributes['js'] = true;
            $stream->next();
        }

        $stream->expect(Token::BLOCK_END_TYPE);
        $nodes['body'] = $this->parser->subparse([$this, 'decideMinifyEnd'], true);

$nodes was never initialized. Although not strictly required by PHP, it is generally a good practice to add $nodes = array(); before regardless.

        $stream->expect(Token::BLOCK_END_TYPE);

        return new MinifyNode($nodes, $attributes, $lineNo, $this->getTag());
    }

    /**

Missing short description in doc comment

     * @return string
     */
    public function getTag(): string
    {
        return 'minify';
    }

    /**

Missing short description in doc comment

     * @param Token $token

Missing parameter comment

     *
     * @return bool
     */
    public function decideMinifyEnd(Token $token): bool
    {
        return $token->test('endminify');
    }
}