ImgixImageTransform::getAssetUri() - Code Metrics - Inspection of "Add displayName()" - nystudio107/craft-imageoptimize - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( a3b096...881135 )

by Andrew

created 2018-12-24 04:05 UTC

ImgixImageTransform::getAssetUri() A

↳ Parent: ImgixImageTransform

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	19
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php
/**
 * ImageOptimize plugin for Craft CMS 3.x
 *
 * Automatically optimize images after they've been transformed
 *
 * @link      https://nystudio107.com

 * @copyright Copyright (c) 2017 nystudio107

 */


namespace nystudio107\imageoptimize\imagetransforms;

use nystudio107\imageoptimize\ImageOptimize;

use craft\elements\Asset;
use craft\helpers\ArrayHelper;
use craft\helpers\Assets as AssetsHelper;
use craft\helpers\UrlHelper;
use craft\models\AssetTransform;

use Imgix\UrlBuilder;
use Psr\Http\Message\ResponseInterface;

use Craft;

/**

 * @author    nystudio107

 * @package   ImageOptimize

 * @since     1.0.0

 */

class ImgixImageTransform extends ImageTransform
{
    // Constants
    // =========================================================================

    const TRANSFORM_ATTRIBUTES_MAP = [
        'width'   => 'w',
        'height'  => 'h',
        'quality' => 'q',
        'format'  => 'fm',
    ];

    const IMGIX_PURGE_ENDPOINT = 'https://api.imgix.com/v2/image/purger';

    // Static Methods
    // =========================================================================

    /**

     * @inheritdoc
     */

    public static function displayName(): string
    {
        return Craft::t('image-optimize', 'Imgix');
    }

    // Public Methods
    // =========================================================================

    /**

     * @param Asset               $asset

     * @param AssetTransform|null $transform

     * @param array               $params

     *
     * @return string|null
     * @throws \yii\base\Exception
     * @throws \yii\base\InvalidConfigException
     */
    public function getTransformUrl(Asset $asset, $transform, array $params = [])
    {
        $url = null;
        $settings = ImageOptimize::$plugin->getSettings();

        $domain = $params['domain'] ?? 'demos.imgix.net';
        $builder = new UrlBuilder($domain);
        if ($asset && $builder) {

            $builder->setUseHttps(true);
            if ($transform) {
                // Map the transform properties
                foreach (self::TRANSFORM_ATTRIBUTES_MAP as $key => $value) {
                    if (!empty($transform[$key])) {
                        $params[$value] = $transform[$key];
                    }
                }
                // Remove any 'AUTO' settings
                ArrayHelper::removeValue($params, 'AUTO');
                // Handle the Imgix auto setting for compression/format
                $autoParams = [];
                if (empty($params['q'])) {
                    $autoParams[] = 'compress';
                }
                if (empty($params['fm'])) {
                    $autoParams[] = 'format';
                }
                if (!empty($autoParams)) {
                    $params['auto'] = implode(',', $autoParams);
                }
                // Handle interlaced images
                if (property_exists($transform, 'interlace')) {
                    if (($transform->interlace != 'none')
                        && (!empty($params['fm']))
                        && ($params['fm'] == 'jpg')
                    ) {
                        $params['fm'] = 'pjpg';
                    }
                }
                if ($settings->autoSharpenScaledImages) {
                    // See if the image has been scaled >= 50%
                    $widthScale = $asset->getWidth() / ($transform->width ?? $asset->getWidth());
                    $heightScale = $asset->getHeight() / ($transform->height ?? $asset->getHeight());
                    if (($widthScale >= 2.0) || ($heightScale >= 2.0)) {
                        $params['usm'] = 50.0;
                    }
                }
                // Handle the mode
                switch ($transform->mode) {
                    case 'fit':

                        $params['fit'] = 'clamp';
                        break;

                    case 'stretch':

                        $params['fit'] = 'scale';
                        break;

                    default:

                        // Set a sane default
                        if (empty($transform->position)) {

                            $transform->position = 'center-center';
                        }

                        // Fit mode
                        $params['fit'] = 'crop';
                        $cropParams = [];
                        // Handle the focal point
                        $focalPoint = $asset->getFocalPoint();
                        if (!empty($focalPoint)) {

                            $params['fp-x'] = $focalPoint['x'];
                            $params['fp-y'] = $focalPoint['y'];
                            $cropParams[] = 'focalpoint';
                        } elseif (preg_match('/(top|center|bottom)-(left|center|right)/', $transform->position)) {

                            // Imgix defaults to 'center' if no param is present
                            $filteredCropParams = explode('-', $transform->position);
                            $filteredCropParams = array_diff($filteredCropParams, ['center']);
                            $cropParams[] = $filteredCropParams;
                        }

                        // Imgix
                        if (!empty($cropParams) && $transform->position !== 'center-center') {

                            $params['crop'] = implode(',', $cropParams);
                        }

                        break;
                }
            } else {
                // No transform was passed in; so just auto all the things
                $params['auto'] = 'format,compress';
            }
            // Remove the api-key param
            unset($params['api-key']);
            // Apply the Security Token, if set
            if (!empty($settings->imgixSecurityToken)) {

                $builder->setSignKey($settings->imgixSecurityToken);
            }
            // Finally, create the Imgix URL for this transformed image
            $assetUri = $this->getAssetUri($asset);
            $url = $builder->createURL($assetUri, $params);
            Craft::debug(
                'Imgix transform created for: '.$assetUri.' - Params: '.print_r($params, true).' - URL: '.$url,
                __METHOD__
            );
        }

        return $url;
    }

    /**

     * @param string              $url

     * @param Asset               $asset

     * @param AssetTransform|null $transform

     * @param array               $params

     *
     * @return string
     */
    public function getWebPUrl(string $url, Asset $asset, $transform, array $params = []): string
    {
        $url = preg_replace('/fm=[^&]*/', 'fm=webp', $url);

        return $url;
    }

    /**

     * @param Asset $asset

     * @param array $params

     *
     * @return null|string
     * @throws \yii\base\InvalidConfigException
     */
    public function getPurgeUrl(Asset $asset, array $params = [])
    {
        $url = null;

        $domain = isset($params['domain'])
            ? $params['domain']
            : 'demos.imgix.net';
        $builder = new UrlBuilder($domain);
        if ($asset && $builder) {

            $builder->setUseHttps(true);
            // Create the Imgix URL for purging this image
            $assetUri = $this->getAssetUri($asset);
            $url = $builder->createURL($assetUri, $params);
            // Strip the query string so we just pass in the raw URL
            $url = UrlHelper::stripQueryString($url);
        }

        return $url;
    }

    /**

     * @param string $url

     * @param array  $params

     *
     * @return bool
     */
    public function purgeUrl(string $url, array $params = []): bool
    {
        $result = false;
        $apiKey = isset($params['api-key'])
            ? $params['api-key']
            : '';
        // create new guzzle client
        $guzzleClient = Craft::createGuzzleClient(['timeout' => 120, 'connect_timeout' => 120]);
        // Submit the sitemap index to each search engine
        try {
            /** @var ResponseInterface $response */

            $response = $guzzleClient->post(self::IMGIX_PURGE_ENDPOINT, [

                'auth'        => [
                    $apiKey,
                    '',
                ],
                'form_params' => [
                    'url' => $url,
                ],
            ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
            // See if it succeeded
            if (($response->getStatusCode() >= 200)
                && ($response->getStatusCode() < 400)
            ) {
                $result = true;
            }
            Craft::info(
                'URL purged: '.$url.' - Response code: '.$response->getStatusCode(),
                __METHOD__
            );
        } catch (\Exception $e) {
            Craft::error(
                'Error purging URL: '.$url.' - '.$e->getMessage(),
                __METHOD__
            );
        }

        return $result;
    }

    /**

     * @return array
     */
    public function getTransformParams(): array
    {
        $settings = ImageOptimize::$plugin->getSettings();
        $params = [
            'domain'  => $settings->imgixDomain,

            'api-key' => $settings->imgixApiKey,

        ];

        return $params;
    }

    /**

     * @param Asset $asset

     *
     * @return mixed
     * @throws \yii\base\InvalidConfigException
     */
    public function getAssetUri(Asset $asset)
    {
        $volume = $asset->getVolume();

        // If this is a local volume, it implies your are using a "Web Folder"
        // source in Imgix. We can then also infer that:
        // - This volume has URLs
        // - The "Base URL" in Imgix is set to your domain root, per the ImageOptimize docs.
        //
        // Therefore, we need to parse the path from the full URL, so that it
        // includes the path of the volume.
        if ($volume instanceof \craft\volumes\Local) {
            $assetUrl = AssetsHelper::generateUrl($volume, $asset);
            $assetUri = parse_url($assetUrl, PHP_URL_PATH);

            return $assetUri;
        }

        return parent::getAssetUri($asset);
    }
}


1			<?php
2			/**
3			* ImageOptimize plugin for Craft CMS 3.x
4			*
5			* Automatically optimize images after they've been transformed
6			*
7			* @link https://nystudio107.com
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @copyright tag Loading history...
8			* @copyright Copyright (c) 2017 nystudio107
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report @copyright tag must contain a year and the name of the copyright holder Loading history...
9			*/
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
10
11			namespace nystudio107\imageoptimize\imagetransforms;
12
13			use nystudio107\imageoptimize\ImageOptimize;
14
15			use craft\elements\Asset;
16			use craft\helpers\ArrayHelper;
17			use craft\helpers\Assets as AssetsHelper;
18			use craft\helpers\UrlHelper;
19			use craft\models\AssetTransform;
20
21			use Imgix\UrlBuilder;
22			use Psr\Http\Message\ResponseInterface;
23
24			use Craft;
25
26			/**
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
27			* @author nystudio107
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @package tag Loading history... Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Content of the @author tag must be in the form "Display Name <[email protected]>" Loading history... Coding Style introduced 2018-09-25 23:18 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 2 spaces but found 4 Loading history...
28			* @package ImageOptimize
			0 ignored issues – show Coding Style introduced 2018-09-25 23:18 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 1 spaces but found 3 Loading history...
29			* @since 1.0.0
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report The tag in position 3 should be the @author tag Loading history... Coding Style introduced 2018-09-25 23:18 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 3 spaces but found 5 Loading history...
30			*/
			0 ignored issues – show Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
31			class ImgixImageTransform extends ImageTransform
32			{
33			// Constants
34			// =========================================================================
35
36			const TRANSFORM_ATTRIBUTES_MAP = [
37			'width' => 'w',
38			'height' => 'h',
39			'quality' => 'q',
40			'format' => 'fm',
41			];
42
43			const IMGIX_PURGE_ENDPOINT = 'https://api.imgix.com/v2/image/purger';
44
45			// Static Methods
46			// =========================================================================
47
48			/**
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
49			* @inheritdoc
50			*/
			0 ignored issues – show Coding Style introduced 2018-12-24 04:09 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
51			public static function displayName(): string
52			{
53			return Craft::t('image-optimize', 'Imgix');
54			}
55
56			// Public Methods
57			// =========================================================================
58
59			/**
			0 ignored issues – show Coding Style introduced 2018-09-25 23:06 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
60			* @param Asset $asset
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
61			* @param AssetTransform\|null $transform
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
62			* @param array $params
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
63			*
64			* @return string\|null
65			* @throws \yii\base\Exception
66			* @throws \yii\base\InvalidConfigException
67			*/
68			public function getTransformUrl(Asset $asset, $transform, array $params = [])
69			{
70			$url = null;
71			$settings = ImageOptimize::$plugin->getSettings();
72
73			$domain = $params['domain'] ?? 'demos.imgix.net';
74			$builder = new UrlBuilder($domain);
75			if ($asset && $builder) {
			0 ignored issues – show introduced 2018-10-25 11:13 UTC by Report Bug Copy Issue Report `$builder` is of type `Imgix\UrlBuilder`, thus it always evaluated to `true`. Loading history...
76			$builder->setUseHttps(true);
77			if ($transform) {
78			// Map the transform properties
79			foreach (self::TRANSFORM_ATTRIBUTES_MAP as $key => $value) {
80			if (!empty($transform[$key])) {
81			$params[$value] = $transform[$key];
82			}
83			}
84			// Remove any 'AUTO' settings
85			ArrayHelper::removeValue($params, 'AUTO');
86			// Handle the Imgix auto setting for compression/format
87			$autoParams = [];
88			if (empty($params['q'])) {
89			$autoParams[] = 'compress';
90			}
91			if (empty($params['fm'])) {
92			$autoParams[] = 'format';
93			}
94			if (!empty($autoParams)) {
95			$params['auto'] = implode(',', $autoParams);
96			}
97			// Handle interlaced images
98			if (property_exists($transform, 'interlace')) {
99			if (($transform->interlace != 'none')
100			&& (!empty($params['fm']))
101			&& ($params['fm'] == 'jpg')
102			) {
103			$params['fm'] = 'pjpg';
104			}
105			}
106			if ($settings->autoSharpenScaledImages) {
107			// See if the image has been scaled >= 50%
108			$widthScale = $asset->getWidth() / ($transform->width ?? $asset->getWidth());
109			$heightScale = $asset->getHeight() / ($transform->height ?? $asset->getHeight());
110			if (($widthScale >= 2.0) \|\| ($heightScale >= 2.0)) {
111			$params['usm'] = 50.0;
112			}
113			}
114			// Handle the mode
115			switch ($transform->mode) {
116			case 'fit':
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 16 spaces, found 20 Loading history...
117			$params['fit'] = 'clamp';
118			break;
119
120			case 'stretch':
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 16 spaces, found 20 Loading history...
121			$params['fit'] = 'scale';
122			break;
123
124			default:
			0 ignored issues – show Coding Style introduced 2018-11-18 04:49 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 16 spaces, found 20 Loading history...
125			// Set a sane default
126			if (empty($transform->position)) {
			0 ignored issues – show Coding Style introduced 2018-11-18 04:49 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 20 spaces, found 24 Loading history...
127			$transform->position = 'center-center';
128			}
			0 ignored issues – show Coding Style introduced 2018-11-18 04:49 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 20 spaces, found 24 Loading history...
129			// Fit mode
130			$params['fit'] = 'crop';
131			$cropParams = [];
132			// Handle the focal point
133			$focalPoint = $asset->getFocalPoint();
134			if (!empty($focalPoint)) {
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 20 spaces, found 24 Loading history...
135			$params['fp-x'] = $focalPoint['x'];
136			$params['fp-y'] = $focalPoint['y'];
137			$cropParams[] = 'focalpoint';
138			} elseif (preg_match('/(top\|center\|bottom)-(left\|center\|right)/', $transform->position)) {
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 20 spaces, found 24 Loading history...
139			// Imgix defaults to 'center' if no param is present
140			$filteredCropParams = explode('-', $transform->position);
141			$filteredCropParams = array_diff($filteredCropParams, ['center']);
142			$cropParams[] = $filteredCropParams;
143			}
			0 ignored issues – show Coding Style introduced 2018-11-18 04:49 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 20 spaces, found 24 Loading history...
144			// Imgix
145			if (!empty($cropParams) && $transform->position !== 'center-center') {
			0 ignored issues – show Coding Style introduced 2018-11-18 04:49 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 20 spaces, found 24 Loading history...
146			$params['crop'] = implode(',', $cropParams);
147			}
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 20 spaces, found 24 Loading history...
148			break;
149			}
150			} else {
151			// No transform was passed in; so just auto all the things
152			$params['auto'] = 'format,compress';
153			}
154			// Remove the api-key param
155			unset($params['api-key']);
156			// Apply the Security Token, if set
157			if (!empty($settings->imgixSecurityToken)) {
			0 ignored issues – show Bug Best Practice introduced 2018-12-24 03:44 UTC by Report Bug Copy Issue Report The property `imgixSecurityToken` does not exist on `nystudio107\imageoptimize\models\Settings`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
158			$builder->setSignKey($settings->imgixSecurityToken);
159			}
160			// Finally, create the Imgix URL for this transformed image
161			$assetUri = $this->getAssetUri($asset);
162			$url = $builder->createURL($assetUri, $params);
163			Craft::debug(
164			'Imgix transform created for: '.$assetUri.' - Params: '.print_r($params, true).' - URL: '.$url,
165			__METHOD__
166			);
167			}
168
169			return $url;
170			}
171
172			/**
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
173			* @param string $url
			0 ignored issues – show Coding Style introduced 2018-10-11 22:29 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
174			* @param Asset $asset
			0 ignored issues – show Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
175			* @param AssetTransform\|null $transform
			0 ignored issues – show Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
176			* @param array $params
			0 ignored issues – show Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
177			*
178			* @return string
179			*/
180			public function getWebPUrl(string $url, Asset $asset, $transform, array $params = []): string
181			{
182			$url = preg_replace('/fm=[^&]*/', 'fm=webp', $url);
183
184			return $url;
185			}
186
187			/**
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
188			* @param Asset $asset
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
189			* @param array $params
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
190			*
191			* @return null\|string
192			* @throws \yii\base\InvalidConfigException
193			*/
194			public function getPurgeUrl(Asset $asset, array $params = [])
195			{
196			$url = null;
197
198			$domain = isset($params['domain'])
199			? $params['domain']
200			: 'demos.imgix.net';
201			$builder = new UrlBuilder($domain);
202			if ($asset && $builder) {
			0 ignored issues – show introduced 2018-10-25 11:13 UTC by Report Bug Copy Issue Report `$builder` is of type `Imgix\UrlBuilder`, thus it always evaluated to `true`. Loading history...
203			$builder->setUseHttps(true);
204			// Create the Imgix URL for purging this image
205			$assetUri = $this->getAssetUri($asset);
206			$url = $builder->createURL($assetUri, $params);
207			// Strip the query string so we just pass in the raw URL
208			$url = UrlHelper::stripQueryString($url);
209			}
210
211			return $url;
212			}
213
214			/**
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
215			* @param string $url
			0 ignored issues – show Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
216			* @param array $params
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
217			*
218			* @return bool
219			*/
220			public function purgeUrl(string $url, array $params = []): bool
221			{
222			$result = false;
223			$apiKey = isset($params['api-key'])
224			? $params['api-key']
225			: '';
226			// create new guzzle client
227			$guzzleClient = Craft::createGuzzleClient(['timeout' => 120, 'connect_timeout' => 120]);
228			// Submit the sitemap index to each search engine
229			try {
230			/** @var ResponseInterface $response */
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report The open comment tag must be the only content on the line Loading history... Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history... Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report The close comment tag must be the only content on the line Loading history...
231			$response = $guzzleClient->post(self::IMGIX_PURGE_ENDPOINT, [
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
232			'auth' => [
233			$apiKey,
234			'',
235			],
236			'form_params' => [
237			'url' => $url,
238			],
239			]);
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
240			// See if it succeeded
241			if (($response->getStatusCode() >= 200)
242			&& ($response->getStatusCode() < 400)
243			) {
244			$result = true;
245			}
246			Craft::info(
247			'URL purged: '.$url.' - Response code: '.$response->getStatusCode(),
248			__METHOD__
249			);
250			} catch (\Exception $e) {
251			Craft::error(
252			'Error purging URL: '.$url.' - '.$e->getMessage(),
253			__METHOD__
254			);
255			}
256
257			return $result;
258			}
259
260			/**
			0 ignored issues – show Coding Style introduced 2018-09-25 21:32 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
261			* @return array
262			*/
263			public function getTransformParams(): array
264			{
265			$settings = ImageOptimize::$plugin->getSettings();
266			$params = [
267			'domain' => $settings->imgixDomain,
			0 ignored issues – show Bug Best Practice introduced 2018-12-24 03:44 UTC by Report Bug Copy Issue Report The property `imgixDomain` does not exist on `nystudio107\imageoptimize\models\Settings`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
268			'api-key' => $settings->imgixApiKey,
			0 ignored issues – show Bug Best Practice introduced 2018-12-24 03:44 UTC by Report Bug Copy Issue Report The property `imgixApiKey` does not exist on `nystudio107\imageoptimize\models\Settings`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
269			];
270
271			return $params;
272			}
273
274			/**
			0 ignored issues – show Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
275			* @param Asset $asset
			0 ignored issues – show Coding Style introduced 2018-10-30 00:15 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
276			*
277			* @return mixed
278			* @throws \yii\base\InvalidConfigException
279			*/
280			public function getAssetUri(Asset $asset)
281			{
282			$volume = $asset->getVolume();
283
284			// If this is a local volume, it implies your are using a "Web Folder"
285			// source in Imgix. We can then also infer that:
286			// - This volume has URLs
287			// - The "Base URL" in Imgix is set to your domain root, per the ImageOptimize docs.
288			//
289			// Therefore, we need to parse the path from the full URL, so that it
290			// includes the path of the volume.
291			if ($volume instanceof \craft\volumes\Local) {
292			$assetUrl = AssetsHelper::generateUrl($volume, $asset);
293			$assetUri = parse_url($assetUrl, PHP_URL_PATH);
294
295			return $assetUri;
296			}
297
298			return parent::getAssetUri($asset);
299			}
300			}
301

nystudio107 / craft-imageoptimize

Push — develop ( a3b096...881135 )

ImgixImageTransform::getAssetUri() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like