Issues in PagesController.php (master) - Issues in master - nyacide/amma - Measure and Improve Code Quality continuously with Scrutinizer

Issues (415)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Http/Controllers/PagesController.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace App\Http\Controllers;

use App\Repositories\ContactsRepository;
use App\Http\Requests\ContactSend;
use App\Repositories\LotRepository;
use App\Repositories\ProductsRepository;
use App\Repositories\PagesRepository;
use App\Repositories\VendorRepository;
use Illuminate\Http\Request;

class PagesController extends Controller
{
    /**
     * @var ContactsRepository
     */
    protected $contacts;

    /**
     * @var ProductsRepository
     */
    protected $products;

    /**
     * @var PagesRepository
     */
    protected $pages;

    /**
     * @var LotRepository
     */
    protected $lot;

    /**
     * PagesController constructor.
     * @param ContactsRepository $contactsRepository
     * @param ProductsRepository $productsRepository
     */
    public function __construct(
        ContactsRepository $contactsRepository,
        ProductsRepository $productsRepository,
        PagesRepository $pagesRepository,
        LotRepository $lotRepository
    ) {
        $this->contacts = $contactsRepository;
        $this->products = $productsRepository;
        $this->pages    = $pagesRepository;
        $this->lot      = $lotRepository;
    }

    /**
     * Show page method.
     *
     * @param $page
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function show($page)
    {
        return view('pages.show', ['item' => $page]);
    }

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function help()
    {
        $helpPages = $this->pages->getPagesHelp();
        return view('pages.help', compact('helpPages'));
    }
    /**
     * Get contacts page.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function contacts()
    {
        return view('home.contacts');
    }

    /**
     * @param ContactSend $request
     * @return mixed
     */
    public function send_contact(ContactSend $request)
    {
        $this->contacts->sendContact($request->all());

        return redirect()->back()->withStatus('Your message was send!');

    }
    
    /**
     * Expire soon product page.
     * 
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function expireSoonLots()
    {
        $lot = $this->lot->getExpireSoon(10);

        return view('pages.expire_soon_products', compact('lot'));
    }

    /**
     *
     */
    public function lastAddedLots()
    {
        $lot = $this->lot->getLatestLot(10);

        return view('pages.last_added_lots', compact('lot'));
    }

    /**
     * Support static page.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function support()
    {
        return view('pages.support');
    }
}

1			<?php
2			namespace App\Http\Controllers;
3
4			use App\Repositories\ContactsRepository;
5			use App\Http\Requests\ContactSend;
6			use App\Repositories\LotRepository;
7			use App\Repositories\ProductsRepository;
8			use App\Repositories\PagesRepository;
9			use App\Repositories\VendorRepository;
10			use Illuminate\Http\Request;
11
12			class PagesController extends Controller
13			{
14			/**
15			* @var ContactsRepository
16			*/
17			protected $contacts;
18
19			/**
20			* @var ProductsRepository
21			*/
22			protected $products;
23
24			/**
25			* @var PagesRepository
26			*/
27			protected $pages;
28
29			/**
30			* @var LotRepository
31			*/
32			protected $lot;
33
34			/**
35			* PagesController constructor.
36			* @param ContactsRepository $contactsRepository
37			* @param ProductsRepository $productsRepository
38			*/
39			public function __construct(
40			ContactsRepository $contactsRepository,
41			ProductsRepository $productsRepository,
42			PagesRepository $pagesRepository,
43			LotRepository $lotRepository
44			) {
45			$this->contacts = $contactsRepository;
46			$this->products = $productsRepository;
47			$this->pages = $pagesRepository;
48			$this->lot = $lotRepository;
49			}
50
51			/**
52			* Show page method.
53			*
54			* @param $page
55			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
56			*/
57			public function show($page)
58			{
59			return view('pages.show', ['item' => $page]);
60			}
61
62			/**
63			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
64			*/
65			public function help()
66			{
67			$helpPages = $this->pages->getPagesHelp();
68			return view('pages.help', compact('helpPages'));
69			}
70			/**
71			* Get contacts page.
72			*
73			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
74			*/
75			public function contacts()
76			{
77			return view('home.contacts');
78			}
79
80			/**
81			* @param ContactSend $request
82			* @return mixed
83			*/
84			public function send_contact(ContactSend $request)
85			{
86			$this->contacts->sendContact($request->all());
87
88			return redirect()->back()->withStatus('Your message was send!');
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `withStatus()` does not exist on `Illuminate\Http\RedirectResponse`. Did you maybe mean `status()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
89			}
90
91			/**
92			* Expire soon product page.
93			*
94			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
95			*/
96			public function expireSoonLots()
97			{
98			$lot = $this->lot->getExpireSoon(10);
99
100			return view('pages.expire_soon_products', compact('lot'));
101			}
102
103			/**
104			*
105			*/
106			public function lastAddedLots()
107			{
108			$lot = $this->lot->getLatestLot(10);
109
110			return view('pages.last_added_lots', compact('lot'));
111			}
112
113			/**
114			* Support static page.
115			*
116			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
117			*/
118			public function support()
119			{
120			return view('pages.support');
121			}
122			}

nyacide / amma

Issues (415)

Security Analysis not enabled

app/Http/Controllers/PagesController.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like