ProductsController - Code Metrics - Inspection of "28.12.2016 m2" - nyacide/amma - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 28284e...eaa9bf )

unknown

created 2016-12-28 08:02 UTC

ProductsController C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	475
Duplicated Lines	9.89 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

Metric	Value
wmc	72
lcom	1
cbo	11
dl	47
loc	475
rs	5.5667
c	0
b	0
f	0

27 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	23	23	1
B	save()	0	24	4
A	show()	0	21	2
A	getSalledPercent()	0	8	2
A	getSpecifications()	0	7	1
A	getSpecificationsColor()	0	7	1
A	remove()	0	18	3
A	saveSpecifications()	0	8	3
D	saveSpecificationsPrice()	0	39	20
A	saveImprovedSpecifications()	0	8	2
A	removeSpec()	0	12	2
A	removeSpecPrice()	0	5	1
A	removeImproveSpec()	0	6	1
A	addImage()	0	10	2
A	removeImage()	0	4	1
A	saveImagesOrder()	0	23	1
A	getChangedSortPositions()	0	13	2
A	setNewRankToChangedPositions()	0	9	1
A	loadSpecPrice()	0	7	2
A	loadSpecPriceDescription()	0	6	3
A	loadImprovedSpecPrice()	0	6	3
A	loadSpecPriceColor()	0	7	4
A	loadSpec()	0	5	2
A	removeGroupPrice()	0	9	2
A	removeSpecPriceDescription()	8	8	2
A	removeGroupSizeColor()	8	8	2
A	removeSpecPriceColor()	8	8	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like ProductsController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use ProductsController, and based on these observations, apply Extract Interface, too.

<?php

namespace App\Http\Controllers;

use App\Http\Requests\ProductCreateRequest;
use App\Http\Requests\ProductUpdateRequest;
use App\Http\Requests\SaveProductRequest;
use App\Image;
use App\ImprovedSpec;
use App\Lot;
use App\Repositories\ImprovedSpecRepository;
use App\Repositories\SpecPriceRepository;
use App\Repositories\LotRepository;
use Illuminate\Support\Facades\Auth;
use App\Product;
use App\Repositories\CategoryableRepository;
use App\Repositories\InvolvedRepository;
use App\Repositories\ModelColorsRepository;
use App\Services\ImageProcessor;
use Illuminate\Http\Request;
use Illuminate\Http\UploadedFile;
use Illuminate\Session\Store;
use App\Repositories\ProductsRepository;
use App\Repositories\CurrenciesRepository;
use XmlParser;
use Storage;

class ProductsController extends Controller
{
    /**
     * @var ProductsRepository
     */
    protected $products;

    /**
     * @var CategoryableRepository
     */
    protected $categoryable;

    /**
     * @var Store
     */
    protected $session;

    /**
     * @var InvolvedRepository
     */
    protected $involved;

    /**
     * @var modelColorsRepository
     */
    protected $modelColors;

    /**
     * @var LotRepository
     */
    protected $lots;

    /**
     * @var ImprovedSpec
     */
    protected $improvedSpecs;
    protected $specPrice;
    protected $currencies;

    /**
     * ProductsController constructor.
     * @param Store $session
     * @param ProductsRepository $productsRepository
     * @param CategoryableRepository $categoryableRepository
     * @param ModelColorsRepository $modelColorsRepository
     * @param InvolvedRepository $involvedRepository
     * @param LotRepository $lotRepository
     * @param ImprovedSpecRepository $improvedSpecRepository
     */
    public function __construct(

        Store $session,
        ProductsRepository $productsRepository,
        CategoryableRepository $categoryableRepository,
        ModelColorsRepository $modelColorsRepository,
        InvolvedRepository $involvedRepository,
        LotRepository $lotRepository,
        ImprovedSpecRepository $improvedSpecRepository,
        SpecPriceRepository $specPriceRepository,
        CurrenciesRepository $currenciesRepository
    )
    {
        $this->session       = $session;
        $this->products      = $productsRepository;
        $this->categoryable  = $categoryableRepository;
        $this->modelColors   = $modelColorsRepository;

        $this->involved      = $involvedRepository;
        $this->lots          = $lotRepository;
        $this->improvedSpecs = $improvedSpecRepository;

        $this->specPrice     = $specPriceRepository;
        $this->currencies    = $currenciesRepository;

    }

    /**
     * @param SaveProductRequest $request
     * @param Product $product
     * @return mixed
     */
    public function save(SaveProductRequest $request, Lot $lot, Product $product)

    {
        $product = $this->products->saveProduct($product, $request->all());

        if (!empty($spec_price = $request->get('spec_price')))
            $this->saveSpecificationsPrice($request,$product);

        if (!empty($spec = $request->get('spec')))
            $this->saveSpecifications($spec, $product);

        if (!empty($fileInput = $request->file('image')))
            array_walk($fileInput, function($image) use (&$product){
                $this->addImage($image, $product);
            });

       /* if (!empty($specs = $request->get('i_spec')))

            $this->saveImprovedSpecifications($specs, $product);*/

        $json = array(
            'respons' => true
        );
        return response($json);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        //return view('lots.partials.form.product', [ 'lot' => $lot, 'product' => $product]);

    }

    /**
     * Show inner product.
     *
     * @param $product
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function show($product)
    {
        $itemPercentage = $this->getSalledPercent($product->id);
        $lot            = $this->lots->find($product->lot_id);
        $productInLot   = $this->products->countInLotProduct($product->lot_id);
        $same_products  = $this->products->getSameProduct($product->sub_category_id);
        $view = view('product.show',['item'=>$product,'lot'=>$lot,'similar'=>$same_products ,'productItem'=> $itemPercentage,'productinlot'=>$productInLot]);

        if(Auth::check()) {
            $auth_is_involved = $this->involved
                ->checkIfAuthInvolved($product);

            return $view
                ->withUserIsInvolved($auth_is_involved)
                ->withInvolved($this->involved->getModelByUserAndProduct($product));
        }

        return $view
            ->withUserIsInvolved(false)
            ->withSame($same_products);
    }

/*    public function convertAmount(){

        $xml = XmlParser::load('http://www.bnm.org/ro/official_exchange_rates?get_xml=1&date='.date("d.m.Y"));

        $parsed = $xml->parse([
            'cursToDay' => ['uses' => 'Valute[CharCode,Value]'],
        ]);

        $currency = array('EUR','USD');
        $json = array();
        foreach ($parsed as $key => $item) {
            foreach ($item as $key => $val) {
                if (in_array($val['CharCode'], $currency)) {
                    $json[$val['CharCode']] = $val['Value'];
                }
            }
        }
        $put = Storage::put('json_currency.json', json_encode($json));
    }*/

    public function getSalledPercent($id)
    {
        $count = $this->products->getCount($id);
        $selled = $this->involved->getCountSelled($id);
        ($count) ? $result = number_format((100 * $selled)  / $count) : $result = 0;

        return array(['totalItems'=>$count,'salePercent'=>$result]);
    }


    public function getSpecifications() {

        $request =  \Request::all();
        $getSpecification = $this->improvedSpecs->getById($request['id']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        return json_encode($getSpecification);
    }

    public function getSpecificationsColor() {

        $request =  \Request::all();
        $getSpecificationColor = $this->modelColors->getById($request['id']);

        return json_encode($getSpecificationColor);
    }


    /**
     * Delete products..
     *
     * @param Request $request
     * @param Lot $lot
     *
     * @return string
     */
    public function remove(Request $request, Lot $lot)

    {
        $product    = $this->products->find($request->get('product_id'));
        if ($product) {
            foreach ($product->specPrice as $key => $price) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $price->removeMetaGroupById('price', $price->id);
            }
            $product->removeMetaGroupById('spec', $request->get('product_id'));
        }
        $this->products->delete($request->get('product_id'));

        /*if($this->lots->checkIfPossibleToChangeCategory($lot))

            return 'enable_cat';*/
        $json = array(
            'respons' => true
        );
        return response($json);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Save specifications.
     *
     * @param $specifications
     * @param $product
     */
    private function saveSpecifications($specifications, Product $product)
    {
        array_walk($specifications, function ($meta) use ($product) {
            if ($meta['key'] != null  && $meta['value'] != null) {
                $product->setMeta($meta, 'spec');
            }
        });
    }


    private function saveSpecificationsPrice($request, Product $product)
    {
        //dd($request->get('spec_price'));

        //dd(collect($request->get('spec_price'))->first());

        //$collection = $request->get('spec_price');

       /* $collection = collect($request->get('spec_price'));

        $filtered = $collection->filter(function ($item) {
            return $item['new_price'] != '' && $item['old_price'] != '';
        })->values();
        dd($filtered->all());*/
        if (!empty($spec = $request->get('spec_price'))) {
            foreach ($spec as $key => $price) {
                if (($price['new_price'] >= 0 && $price['old_price'] >= 0) && ($price['new_price'] != null && $price['old_price'] != null)) {
                    $specPriceInsert = $this->specPrice->save($price, $product);
                    if (!empty($specMeta = $price['spec_desc'])) {
                        foreach ($specMeta as $meta) {
                            if ($meta['key'] != null  && $meta['value'] != null) {
                                $specPriceInsert->setMeta($meta, 'price');
                            }
                        }
                    }
                    if (!empty($specSize = $price['size'])) {
                        foreach ($specSize as $key => $size) {
                            if ($size['size'] >= 0  && $size['size'] != null) {
                                $specSizeInsert = $this->improvedSpecs->save($size, $specPriceInsert);

                                if (!empty($specColor = $size['color'])) {
                                    foreach ($specColor as $key => $color) {
                                        if ($color['color_hash'] != null  or ($color['amount'] >= 0 && $color['amount'] != null)) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                                            $specColorInsert = $this->modelColors->save($color, $specSizeInsert);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        }
    }

    private function saveImprovedSpecifications($specs, $product)

    {
        array_walk($specs, function($data, $product){

            $spec = $this->improvedSpecs->find($spec_id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if($spec)
                $this->improvedSpecs->update($spec, $data);
        });
    }

    /**
     * Remove spec.
     *
     * @param Request $request
     *
     * @return void
     */
    public function removeSpec(Request $request)
    {
        $product = $this->products->find($request->get('product_id'));
        if ($product) {
            $product->removeMetaByKey($request->get('key'));
        }
        $json = array(
            'respons' => true
        );
        return response($json);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        
    }

    public function removeSpecPrice(Request $request)
    {
        $spec = $this->specPrice->find($request->get('spec_id'));
        $this->specPrice->delete($spec);
    }
    /**
     * Remove improved spec.
     *
     * @param Request $request
     * @param Lot $lot
     *
     * @return void
     */
    public function removeImproveSpec(Request $request, Lot $lot)

    {
        $spec = $this->improvedSpecs->find($request->get('spec_id'));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $this->improvedSpecs->delete($spec);

    }

    /**
     * Add image to product.
     *
     * @param $image
     * @param Product $product
     *
     * @return mixed
     */
    public function addImage($image, Product $product)
    {
        if ($image instanceof UploadedFile) {
            $location = 'upload/products/' . $product->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $processor = new ImageProcessor();
            $imageable = $processor->uploadAndCreate($image, $product, null, $location);

            return $imageable;
        }
    }

    /**
     * Remove Image.
     *
     * @param Request $request
     * @param $lot
     */
    public function removeImage(Request $request, $lot)

    {
        Image::find($request->get('image_id'))->delete();
    }

    /**
     * Save image order.
     *
     * @param Request $request
     * @param $product
     */
    public function saveImagesOrder(Request $request, $product)
    {
        $sorted = $request->get('item');

        $newsort = [];
        array_walk($sorted, function ($id, $k) use (&$newsort){
            $image = Image::find($id);

            $newsort[$k] = ['id' => $image->id, 'rank' => $image->rank];
        });

        $oldsort = [];
        $product->images()->ranked('asc')->get()->each(function ($item, $k) use(&$oldsort)
        {
            $oldsort[$k] = ['id' => $item->id, 'rank' => $item->rank];
        });

        $this->setNewRankToChangedPositions(
            $this->getChangedSortPositions($newsort, $oldsort),
            $newsort,
            $oldsort
        );
    }

    /**
     * Get only changed positions of sorted elements.
     *
     * @param $newsort
     * @param $oldsort
     * @return array
     */
    private function getChangedSortPositions($newsort, $oldsort)
    {
        $temp = [];
        array_walk($newsort, function ($sorted_attribs, $position) use ($oldsort, $newsort, &$temp)
        {
            if($oldsort[$position]['id'] !== $newsort[$position]['id'])
            {
                $temp[] = $position;
            }
        });

        return $temp;
    }

    /**
     * Save sorted ranks to changed positions.
     *
     * @param $changed_positions
     * @param $newsort
     * @param $oldsort
     */
    private function setNewRankToChangedPositions($changed_positions, $newsort, $oldsort)
    {
        array_walk($changed_positions, function ($position) use ($oldsort, $newsort)
        {
            $image = Image::find($newsort[$position]['id']);

            $image->setRank($oldsort[$position]['rank']);
        });
    }



    public function loadSpecPrice(Request $request, Lot $lot)
    {
        $key_spec   = ($request->has('key_spec')) ? $request->get('key_spec') : 1;
        $product    = $this->products->find($request->get('product_id'));
        $currencies = $this->currencies->getPublic();
        return view('lots.partials.form.specification_price', ['currencies' => $currencies,'lot' => $lot,'product' => $product,'key_spec' => $key_spec]);
    }
    public function loadSpecPriceDescription(Request $request)
    {
        $key_desc = ($request->has('key_desc')) ? $request->get('key_desc') : 1;
        $key_spec = ($request->has('key_spec')) ? $request->get('key_spec') : 1;
        return view('lots.partials.form.description_specs', ['key_spec' => $key_spec,'key_desc' => $key_desc]);
    }
    public function loadImprovedSpecPrice(Request $request)
    {
        $key_spec = ($request->has('key_spec')) ? $request->get('key_spec') : 1;
        $key_size = ($request->has('key_size')) ? $request->get('key_size') : 1;
        return view('lots.partials.form.size_specs', ['key_spec' => $key_spec,'key_size' => $key_size]);
    }
    public function loadSpecPriceColor(Request $request)
    {
        $key_spec  = ($request->has('key_spec')) ? $request->get('key_spec') : 1;
        $key_size  = ($request->has('key_size')) ? $request->get('key_size') : 1;
        $key_color = ($request->has('key_color')) ? $request->get('key_color') : 1;
        return view('lots.partials.form.color_specs', ['key_spec' => $key_spec,'key_size' => $key_size,'key_color' => $key_color]);
    }
    public function loadSpec(Request $request)
    {
        $key_spec_product  = ($request->has('key_spec_product')) ? $request->get('key_spec_product') : 1;
        return view('lots.partials.form.specification', ['key_spec_product' => $key_spec_product]);
    }

    public function removeGroupPrice(Request $request)
    {
        $spec = $this->specPrice->findKey($request->get('key'));
        if ($spec) {
            $spec->removeMetaGroupById('price', $spec->id);
            $this->specPrice->delete($spec->id);
        }
        return response(array('type' => true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }   
    public function removeSpecPriceDescription(Request $request)

    {
        $spec = $this->specPrice->findKey($request->get('key_price'));
        if ($spec) {
            $spec->removeMetaByKey($request->get('key'));
        }
        return response(array('type' => true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
    public function removeGroupSizeColor(Request $request)

    {
        $spec = $this->improvedSpecs->findKey($request->get('key'));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($spec) {
            $this->improvedSpecs->delete($spec);

        }
        return response(array('type' => true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
    public function removeSpecPriceColor(Request $request)

    {
        $spec = $this->modelColors->findKey($request->get('key'));
        if ($spec) {
            $this->modelColors->delete($spec);
        }
        return response(array('type' => true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}

nyacide / amma