CreateWalletOrder::__construct()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 7
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 4
nc 1
nop 1
1
<?php
2
3
namespace App\Orders;
4
5
use App\Repositories\WalletRepository;
6
use App\User;
7
8
class CreateWalletOrder extends Order
9
{
10
    /**
11
     * @var User
12
     */
13
    protected $user;
14
15
    /**
16
     * @var int
17
     */
18
    protected $test_count;
19
20
    /**
21
     * CreateWalletOrder constructor.
22
     * @param User $user
23
     */
24
    public function __construct(User $user)
25
    {
26
        $this->user = $user;
27
        $this->test_count = config('testing_payment.amount');
28
29
        parent::__construct();
30
    }
31
32
    /**
33
     * Method witch run's on serialize object.
34
     *
35
     * @return void.
0 ignored issues
show
Documentation introduced by
The doc-type void. could not be parsed: Unknown type name "void." at position 0. (view supported doc-types)

This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.

Loading history...
36
     */
37
    public function handle()
38
    {
39
//        if(! $this->user->hasWallet())
0 ignored issues
show
Unused Code Comprehensibility introduced by
70% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
40
        if(! $this->user->wallet()->first())
41
        {
42
            $data['amount'] = 0;
0 ignored issues
show
Coding Style Comprehensibility introduced by
$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
43
            if($this->checkIfTestWalletPeriodOn())
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->checkIfTestWalletPeriodOn() of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
44
            {
45
                $data['amount'] = $this->test_count;
46
            }
47
48
            $this->getWalletsRepository()
49
                ->create($this->user, $data);
50
        }
51
    }
52
53
    /**
54
     * Check if testing period.
55
     *
56
     * @return string|null
57
     */
58
    public function checkIfTestWalletPeriodOn()
59
    {
60
        return settings()->getOption('site::testing_payment_period');
61
    }
62
63
    /**
64
     * @return WalletRepository
65
     */
66
    private function getWalletsRepository()
67
    {
68
        return (new WalletRepository());
69
    }
70
}