HasRank::swapRank() - Code Metrics - nyacide/amma - Measure and Improve Code Quality continuously with Scrutinizer

HasRank::swapRank() A
last analyzed 2016-12-28 08:14 UTC

↳ Parent: HasRank

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	1

<?php

namespace App\Libraries\Rankable;

trait HasRank
{
    public function rankUp()
    {

    }

    public function rankDown()
    {

    }

    public function makeFirst()
    {

    }

    public function makeLast()
    {

    }
    
    public function getFirstRank($query = false)
    {
        if($query)
            return $this->orderBy('rank', 'ASC');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this->orderBy('rank', 'ASC')->first();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getLastRank($query = false)
    {
        if($query)
            return $this->orderBy('rank', 'DESC');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this->orderBy('rank', 'DESC')->first();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function swapRank($swapper)
    {
        if(is_numeric($swapper))
            $swapper = $this->find((int) $swapper)->first();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $swapperModelRank = $swapper->rank;
        $currentModelRank = $this->getRank();

        $swapper->rank = $currentModelRank;
        $this->rank = $swapperModelRank;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $swapper->save();
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }

    /**
     * Set rank to model.
     * 
     * @param $rank
     * @return $this
     */
    public function setRank($rank)
    {
        $this->rank = $rank;
        
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        return $this;
    }

    public function getRankIndex()
    {
        return $this->id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function getRank()
    {
        return $this->rank();
    }

    public function rank()
    {
        return $this->rank();
    }

    public function scopeRanked($query, $order = 'DESC')
    {
        return $query->orderBy('rank', $order);
    }

    public function scopeFindRank($query, $rank)
    {
        return $query->whereRank($rank);
    }
}

1			<?php
2
3			namespace App\Libraries\Rankable;
4
5			trait HasRank
6			{
7			public function rankUp()
8			{
9
10			}
11
12			public function rankDown()
13			{
14
15			}
16
17			public function makeFirst()
18			{
19
20			}
21
22			public function makeLast()
23			{
24
25			}
26
27			public function getFirstRank($query = false)
28			{
29			if($query)
30			return $this->orderBy('rank', 'ASC');
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report It seems like `orderBy()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31
32			return $this->orderBy('rank', 'ASC')->first();
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report It seems like `orderBy()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33			}
34
35			public function getLastRank($query = false)
36			{
37			if($query)
38			return $this->orderBy('rank', 'DESC');
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report It seems like `orderBy()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39
40			return $this->orderBy('rank', 'DESC')->first();
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report It seems like `orderBy()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41			}
42
43			public function swapRank($swapper)
44			{
45			if(is_numeric($swapper))
46			$swapper = $this->find((int) $swapper)->first();
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report It seems like `find()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
47
48			$swapperModelRank = $swapper->rank;
49			$currentModelRank = $this->getRank();
50
51			$swapper->rank = $currentModelRank;
52			$this->rank = $swapperModelRank;
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report The property `rank` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
53			$swapper->save();
54			$this->save();
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
55
56			return $this;
57			}
58
59			/**
60			* Set rank to model.
61			*
62			* @param $rank
63			* @return $this
64			*/
65			public function setRank($rank)
66			{
67			$this->rank = $rank;
68
69			$this->save();
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
70
71			return $this;
72			}
73
74			public function getRankIndex()
75			{
76			return $this->id;
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
77			}
78
79			public function getRank()
80			{
81			return $this->rank();
82			}
83
84			public function rank()
85			{
86			return $this->rank();
87			}
88
89			public function scopeRanked($query, $order = 'DESC')
90			{
91			return $query->orderBy('rank', $order);
92			}
93
94			public function scopeFindRank($query, $rank)
95			{
96			return $query->whereRank($rank);
97			}
98			}

nyacide / amma

HasRank::swapRank() A last analyzed 2016-12-28 08:14 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

HasRank::swapRank() A
last analyzed 2016-12-28 08:14 UTC