BannerComposer::compose() - Code Metrics - nyacide/amma - Measure and Improve Code Quality continuously with Scrutinizer

BannerComposer::compose() A
last analyzed 2016-12-28 08:14 UTC

↳ Parent: BannerComposer

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.2
c	0
b	0
f	0
cc	4
eloc	11
nc	4
nop	1

<?php

namespace App\Http\ViewComposers;

use App\Repositories\BannerRepository;
use Illuminate\Contracts\View\View;

class BannerComposer extends Composer
{
    /**
     * @var BannerRepository
     */
    protected $banners;

    /**
     * BannerComposer constructor.
     * @param BannerRepository $bannerRepository
     */
    public function __construct(BannerRepository $bannerRepository)
    {
        $this->banners = $bannerRepository;
    }

    /**
     * @param View $view
     * @return $this
     */
    public function compose(View $view)
    {
        // Here template names is hardcoded, but here is easy to edit them, then go to templates and change variables there

        switch ($view->getName()){
            case "partials.banners.small":
                return $view->with('banners', $this->banners->getSmallAdBlocks(2));
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case "partials.banners.r_sidebar":
                return $view->with('banners', $this->banners->getRightSideBarAdBlocks(1));
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case "partials.banners.big":
                return $view->with('banners', $this->banners->getBigAdBlocks(2));
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }
}

1			<?php
2
3			namespace App\Http\ViewComposers;
4
5			use App\Repositories\BannerRepository;
6			use Illuminate\Contracts\View\View;
7
8			class BannerComposer extends Composer
9			{
10			/**
11			* @var BannerRepository
12			*/
13			protected $banners;
14
15			/**
16			* BannerComposer constructor.
17			* @param BannerRepository $bannerRepository
18			*/
19			public function __construct(BannerRepository $bannerRepository)
20			{
21			$this->banners = $bannerRepository;
22			}
23
24			/**
25			* @param View $view
26			* @return $this
27			*/
28			public function compose(View $view)
29			{
30			// Here template names is hardcoded, but here is easy to edit them, then go to templates and change variables there
31
32			switch ($view->getName()){
33			case "partials.banners.small":
34			return $view->with('banners', $this->banners->getSmallAdBlocks(2));
35			break;
			0 ignored issues – show Unused Code introduced 2016-09-02 08:37 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
36
37			case "partials.banners.r_sidebar":
38			return $view->with('banners', $this->banners->getRightSideBarAdBlocks(1));
39			break;
			0 ignored issues – show Unused Code introduced 2016-09-02 08:37 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
40
41			case "partials.banners.big":
42			return $view->with('banners', $this->banners->getBigAdBlocks(2));
43			break;
			0 ignored issues – show Unused Code introduced 2016-09-02 08:37 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
44			}
45			}
46			}

nyacide / amma

BannerComposer::compose() A last analyzed 2016-12-28 08:14 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BannerComposer::compose() A
last analyzed 2016-12-28 08:14 UTC