GetCurrency::convertAmount() - Code Metrics - nyacide/amma - Measure and Improve Code Quality continuously with Scrutinizer

GetCurrency::convertAmount() A
last analyzed 2016-12-28 08:14 UTC

↳ Parent: GetCurrency

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.2
c	0
b	0
f	0
cc	4
eloc	11
nc	4
nop	0

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;
use XmlParser;
use Storage;

class GetCurrency extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'get:currency';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Get Daily Currency';

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->convertAmount();
    }

    public function convertAmount(){
        $xml = XmlParser::load('http://www.bnm.org/ro/official_exchange_rates?get_xml=1&date='.date("d.m.Y"));

        $parsed = $xml->parse([
            'cursToDay' => ['uses' => 'Valute[CharCode,Value]'],
        ]);

        $currency = array('EUR','USD');
        $json = array();
        foreach ($parsed as $key => $item) {
            foreach ($item as $key => $val) {
                if (in_array($val['CharCode'], $currency)) {
                    $json[$val['CharCode']] = $val['Value'];
                }
            }
        }
        $put = Storage::put('json_currency.json', json_encode($json));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php
2
3			namespace App\Console\Commands;
4
5			use Illuminate\Console\Command;
6			use XmlParser;
7			use Storage;
8
9			class GetCurrency extends Command
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'get:currency';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'Get Daily Currency';
24
25			/**
26			* Create a new command instance.
27			*
28			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
29			*/
30			public function __construct()
31			{
32			parent::__construct();
33			}
34
35			/**
36			* Execute the console command.
37			*
38			* @return mixed
39			*/
40			public function handle()
41			{
42			$this->convertAmount();
43			}
44
45			public function convertAmount(){
46			$xml = XmlParser::load('http://www.bnm.org/ro/official_exchange_rates?get_xml=1&date='.date("d.m.Y"));
47
48			$parsed = $xml->parse([
49			'cursToDay' => ['uses' => 'Valute[CharCode,Value]'],
50			]);
51
52			$currency = array('EUR','USD');
53			$json = array();
54			foreach ($parsed as $key => $item) {
55			foreach ($item as $key => $val) {
56			if (in_array($val['CharCode'], $currency)) {
57			$json[$val['CharCode']] = $val['Value'];
58			}
59			}
60			}
61			$put = Storage::put('json_currency.json', json_encode($json));
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report The method `put()` does not seem to exist on `object<Illuminate\Contracts\Filesystem\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Unused Code introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report `$put` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
62			}
63			}
64

nyacide / amma

GetCurrency::convertAmount() A last analyzed 2016-12-28 08:14 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

GetCurrency::convertAmount() A
last analyzed 2016-12-28 08:14 UTC