SendConfirmationCode - Code Metrics - nyacide/amma - Measure and Improve Code Quality continuously with Scrutinizer

SendConfirmationCode A
last analyzed 2016-12-28 08:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	3
dl	0
loc	35
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	0	10	1

<?php

namespace App\Listeners;

use App\Events\UserCreationRequestSent;
use Illuminate\Foundation\Application;
use Illuminate\Mail\Message;
use Keyhunter\Administrator\Filters\QueryableTrait;
use Illuminate\Bus\Queueable;


class SendConfirmationCode
{
//    use QueryableTrait, Queueable;


    /**
     * @var Application
     */
    private $application;

    /**
     * Create the event handler.
     * @param Application $application
     */
    public function __construct(Application $application)
    {
        $this->application = $application;
    }

    /**
     * Handle the event.
     *
     * @param  UserCreationRequestSent  $event
     * @return void
     */
    public function handle(UserCreationRequestSent $event)
    {
        $user    = $event->getUser();

        \Mail::send('email.verify', compact('user'), function(Message $message) use ($user)
        {
            $message->to($user->email, sprintf('%s %s', $user->profile->firstname, $user->profile->lastname))
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ->subject("Verify your email address");
        });
    }
}

1			<?php
2
3			namespace App\Listeners;
4
5			use App\Events\UserCreationRequestSent;
6			use Illuminate\Foundation\Application;
7			use Illuminate\Mail\Message;
8			use Keyhunter\Administrator\Filters\QueryableTrait;
9			use Illuminate\Bus\Queueable;
10
11
12			class SendConfirmationCode
13			{
14			// use QueryableTrait, Queueable;
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report `38%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
15
16			/**
17			* @var Application
18			*/
19			private $application;
20
21			/**
22			* Create the event handler.
23			* @param Application $application
24			*/
25			public function __construct(Application $application)
26			{
27			$this->application = $application;
28			}
29
30			/**
31			* Handle the event.
32			*
33			* @param UserCreationRequestSent $event
34			* @return void
35			*/
36			public function handle(UserCreationRequestSent $event)
37			{
38			$user = $event->getUser();
39
40			\Mail::send('email.verify', compact('user'), function(Message $message) use ($user)
41			{
42			$message->to($user->email, sprintf('%s %s', $user->profile->firstname, $user->profile->lastname))
			0 ignored issues – show Documentation introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report The property `email` does not exist on `object<App\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report The property `profile` does not exist on `object<App\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
43			->subject("Verify your email address");
44			});
45			}
46			}

nyacide / amma

SendConfirmationCode A last analyzed 2016-12-28 08:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

SendConfirmationCode A
last analyzed 2016-12-28 08:14 UTC