App\Http\Middleware\CanHandleActionMiddleware

Complexity

Total Complexity

9

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	13	3
A	getRouteParameter()	0	4	1
A	getObjectHolder()	0	10	4
A	abort()	0	4	1

<?php

namespace App\Http\Middleware;

use App\Http\Requests\Request;
use App\Lot;
use Auth;

class CanHandleActionMiddleware
{
    /**
     * @var Request
     */
    private $request;

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \Closure $next
     * @return mixed
     */
    public function handle($request, \Closure $next, $parameter)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;

$request is of type object<Illuminate\Http\Request>, but the property $request was declared to be of type object<App\Http\Requests\Request>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $user_holder = $this->getObjectHolder(
            $this->getRouteParameter($parameter)
        );

        if ($user_holder && Auth::id() == $user_holder->id)
            return $next($request);

        $this->abort();
    }

    /**
     * Get model from parameter from route.
     *
     * @param $parameter
     * @return \Illuminate\Routing\Route|object|string
     */
    private function getRouteParameter($parameter)
    {
        return $this->request->route($parameter);
    }

    /**
     * Get user of this object.
     *
     * @param $model
     * @return mixed
     */
    private function getObjectHolder($model)
    {
        if($model && $model instanceof Lot)
            return $model->vendor->user;

The property vendor does not exist on object<App\Lot>. Since you implemented __get, maybe consider adding a @property annotation.

        if($model)
            return $model->user()->first();

        $this->abort();
    }

    /**
     * Abort connection.
     */
    private function abort()
    {
        return abort('404');
    }
}