App\Http\Middleware\AddLotMiddleware

Complexity

Total Complexity

15

Size/Duplication

Total Lines	141
Duplicated Lines	23.4 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	handle()	0	21	4
A	issetAmount()	0	9	2
A	blockAmount()	0	6	1
A	blockSumm()	17	17	2
A	eraseFromWallet()	0	15	2
A	eraseSummFromWallet()	16	16	2
A	calcEraseSumm()	0	4	1

<?php

namespace App\Http\Middleware;

use App\Lot;
use App\Repositories\LotRepository;
use Closure;
use Illuminate\Contracts\Auth\Guard;

class AddLotMiddleware
{
    /**
     * @var Guard
     */
    protected $auth;

    /**
     * @var LotRepository
     */
    protected $lots;

    /**
     * AddLotMiddleware constructor.
     * @param Guard $auth
     * @param LotRepository $lotRepository
     */
    public function __construct(Guard $auth, LotRepository $lotRepository)
    {
        $this->auth = $auth;
        $this->lots = $lotRepository;
    }

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @param  string|null  $guard
     * @return mixed
     */
    public function handle($request, Closure $next, $guard = null)

The parameter $guard is not used and could be removed.

    {
        if($lot = $request->route('lot'))
        {
            if($lot->status == Lot::STATUS_DRAFTED)
            {
                /*$category = $lot->category;*/

50% of this comment could be valid code. Did you maybe forget this after debugging?

                if($this->issetAmount($lot, $request->get('comision')))
                {
                    $lot->status = Lot::STATUS_COMPLETE;
                    $lot->save();
                    return $next($request);
                } else {
                    //return redirect()->back()->withErrors('No amount');

74% of this comment could be valid code. Did you maybe forget this after debugging?

                    return response('No amount',402);
                }
            }
        }

        return redirect()->back()->withSuccess('Something Wrong!');
    }

    private function issetAmount($lot, $requestComision)
    {
        $comision = $this->lots->userLotsPendingComision(\Auth::user(),$lot->id) + $requestComision;
        $wallet   = $this->auth->user()->wallet;

Accessing wallet on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($wallet->amount >= $comision) {
            return true;
        }
        return false;
    }

    private function blockAmount($lot, $tax)

This method is not used, and could be removed.

    {
        $user = $this->auth->user();

$user is not used, you could remove the assignment.

        $amount = $lot->yield_amount;
        return $this->blockSumm($tax, $amount);
    }

    public function blockSumm($tax, $amount)

This method seems to be duplicated in your project.

    {
        $wallet = $this->auth->user()->wallet;

Accessing wallet on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $summ = $this->calcEraseSumm($tax, $amount);

        $calc = $wallet->amount - $summ;
        if($calc > 0)
        {
            return $wallet->fill([
                //'amount'       => $calc,

67% of this comment could be valid code. Did you maybe forget this after debugging?

                'amount_block' => $summ
            ])->save();
        }

        return false;
    }


    /**
     * @param $lot
     * @param $tax
     * @return bool
     */
    private function eraseFromWallet($lot, $tax)

This method is not used, and could be removed.

    {
        $user = $this->auth->user();
        $amount = $lot->yield_amount;

        if(! $user->isAdmin())
        {
            return $this->eraseSummFromWallet($tax, $amount);
        } else {
            $lot->status = Lot::STATUS_COMPLETE;
            $lot->save();

            return true;
        }
    }
    /**
     * @param $tax
     * @param $amount
     * @return bool
     */
    public function eraseSummFromWallet($tax, $amount)

This method seems to be duplicated in your project.

    {
        $wallet = $this->auth->user()->wallet;

Accessing wallet on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $summ = $this->calcEraseSumm($tax, $amount);

        $calc = $wallet->amount - $summ;
        if($calc > 0)
        {
            return $wallet->fill([
                'amount' => $calc
            ])->save();
        }

        return false;
    }

    /**
     * @param $tax
     * @param $amount
     * @return float|int
     */
    public function calcEraseSumm($tax, $amount)
    {
        return ($amount / 100 * $tax);
    }
}