PostController - Code Metrics - nyacide/amma - Measure and Improve Code Quality continuously with Scrutinizer

PostController A
last analyzed 2016-12-28 08:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	3
dl	0
loc	43
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	index()	6	1
A	show()	8	1

<?php

namespace App\Http\Controllers;

use Event;
use App\Events\PostWasViewed;
use App\Repositories\PostsRepository;

class PostController extends Controller
{
    /**
     * @var PostsRepository
     */
    protected $posts;

    /**
     * PostController constructor.
     * @param PostsRepository $postsRepository
     */
    public function __construct(PostsRepository $postsRepository)
    {
        $this->posts = $postsRepository;
    }

    /**
     * Index blog page.
     * 
     * @return \Illuminate\View\View
     */
    public function index()
    {
        $posts = $this->posts->getPublic(5);

        return view('blog.index')->with('posts', $posts);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Single post view.
     *
     * @param \App\Post $post
     * @return \Illuminate\View\View
     */
    public function show($post)
    {
        Event::fire(new PostWasViewed($post));

        $post  = $this->posts->find($post->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        
        return view('blog.post')->withItem($post);
    }
}

1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Event;
6			use App\Events\PostWasViewed;
7			use App\Repositories\PostsRepository;
8
9			class PostController extends Controller
10			{
11			/**
12			* @var PostsRepository
13			*/
14			protected $posts;
15
16			/**
17			* PostController constructor.
18			* @param PostsRepository $postsRepository
19			*/
20			public function __construct(PostsRepository $postsRepository)
21			{
22			$this->posts = $postsRepository;
23			}
24
25			/**
26			* Index blog page.
27			*
28			* @return \Illuminate\View\View
29			*/
30			public function index()
31			{
32			$posts = $this->posts->getPublic(5);
33
34			return view('blog.index')->with('posts', $posts);
			0 ignored issues – show Bug introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
35			}
36
37			/**
38			* Single post view.
39			*
40			* @param \App\Post $post
41			* @return \Illuminate\View\View
42			*/
43			public function show($post)
44			{
45			Event::fire(new PostWasViewed($post));
46
47			$post = $this->posts->find($post->id);
			0 ignored issues – show Documentation introduced 2016-12-28 08:14 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Post>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
48
49			return view('blog.post')->withItem($post);
50			}
51			}

nyacide / amma

PostController A last analyzed 2016-12-28 08:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

PostController A
last analyzed 2016-12-28 08:14 UTC