App\Http\Controllers\LotsController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	247
Duplicated Lines	23.48 %

Coupling/Cohesion

Components	3
Dependencies	11

Importance

Changes

0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	21	21	1
A	create()	7	7	1
A	edit()	7	7	1
A	delete()	0	8	1
A	selectCategory()	0	10	1
A	loadProductBlock()	0	10	2
A	loadImprovedSpec()	0	6	1
A	saveLot()	0	6	1
A	updateLot()	11	11	2
A	publishedLot()	12	12	2
A	index()	0	4	1
A	myLots()	0	5	1
A	show()	0	4	1
A	getUser()	0	4	1

<?php

namespace App\Http\Controllers;

use App\Http\Requests\SaveLotRequest;
use App\Lot;
use App\Repositories\ImprovedSpecRepository;
use App\Repositories\SpecPriceRepository;
use App\Repositories\LotRepository;
use App\Repositories\ProductsRepository;
use App\Repositories\SubCategoriesRepository;
use App\Repositories\MethodDeliveryPaymentRepository;
use App\Repositories\LotDeliveryPaymentRepository;
use App\Repositories\CurrenciesRepository;
use App\Vendor;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Http\Request;

use App\Http\Requests;

class LotsController extends Controller
{
    /**
     * @var LotRepository
     */
    protected $lots;

    /**
     * @var Guard
     */
    protected $auth;

    /**
     * @var ProductsRepository
     */
    protected $products;

    /**
     * @var ImprovedSpecRepository
     */
    protected $improvedSpecs;

    protected $specPrice;


    protected $sub_category;

    protected $method;

    protected $lot_method;

    protected $currencies;

    /**
     * LotsController constructor.
     * @param LotRepository $lotRepository
     * @param ProductsRepository $productsRepository
     * @param ImprovedSpecRepository $improvedSpecRepository
     * @param Guard $auth
     */
    public function __construct(

This method seems to be duplicated in your project.

        LotRepository $lotRepository,
        ProductsRepository $productsRepository,
        ImprovedSpecRepository $improvedSpecRepository,
        SpecPriceRepository $specPriceRepository,
        SubCategoriesRepository $subCategoriesRepository,
        MethodDeliveryPaymentRepository $methodDeliveryPaymentRepository,
        LotDeliveryPaymentRepository $lotDeliveryPaymentRepository,
        CurrenciesRepository $currenciesRepository,
        Guard $auth
    ) {
        $this->lots          = $lotRepository;
        $this->auth          = $auth;
        $this->products      = $productsRepository;
        $this->improvedSpecs = $improvedSpecRepository;
        $this->specPrice     = $specPriceRepository;
        $this->sub_category  = $subCategoriesRepository;
        $this->method        = $methodDeliveryPaymentRepository;
        $this->lot_method    = $lotDeliveryPaymentRepository;
        $this->currencies    = $currenciesRepository;
    }

    /**
     * Create lot or modify drafted for vendor.
     *
     * @param Vendor $vendor
     * @return \Illuminate\View\View
     */
    public function create(Vendor $vendor)

This method seems to be duplicated in your project.

    {
        $lot = $this->lots->addLot($vendor);
        $delivery = $this->method->getPublic('delivery');
        $payment = $this->method->getPublic('payment');
        return view('lots.create', compact('lot','delivery','payment'));

The expression view('lots.create', compact('lot', 'delivery', 'payment')); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 94 which is incompatible with the return type documented by App\Http\Controllers\LotsController::create of type Illuminate\View\View.

    }

    /**
     * @param Lot $lot
     * @return \Illuminate\View\View
     */
    public function edit(Lot $lot)

This method seems to be duplicated in your project.

    {
        //dd($lot->lotDeliveryPayment());

78% of this comment could be valid code. Did you maybe forget this after debugging?

        $delivery = $this->method->getPublic('delivery');
        $payment = $this->method->getPublic('payment');
        return view('lots.create', compact('lot','delivery','payment'));

The expression view('lots.create', compact('lot', 'delivery', 'payment')); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 106 which is incompatible with the return type documented by App\Http\Controllers\LotsController::edit of type Illuminate\View\View.

    }

    /**
     * Remove lot.
     *
     * @param Lot $lot
     * @return mixed
     */
    public function delete(Lot $lot)
    {
        $this->lots->delete($lot);

        return redirect()->route('my_lots')

The method withStatus() does not exist on Illuminate\Http\RedirectResponse. Did you maybe mean status()?

            ->withStatus(sprintf('Lot %s was removed', $lot->present()->renderName()))

The method present() does not exist on App\Lot. Did you maybe mean scopePresent()?

            ->withColor('green');
    }

    /**
     * Select category.
     *
     * @param Request $request
     * @param Lot $lot
     *
     * @return string
     */
/*    public function selectCategory(Request $request, Lot $lot)

60% of this comment could be valid code. Did you maybe forget this after debugging?

    {
        if($this->lots->checkIfPossibleToChangeCategory($lot)) {
            $this->lots->changeCategory($lot, $request->get('category_id'));
            return 'true';
        }

        return 'false';
    }*/

    public function selectCategory(Request $request, Lot $lot)
    {
        $sub_category = $this->sub_category->getSubCategory($request->get('category_id'));
        $this->lots->changeCategory($lot, $request->get('category_id'));
        $json = array(
            'sub_category' => $sub_category,
            'respons'      => true
        );
         return response($json);

$json is of type array<string,?,{"sub_category":"?","respons":"boolean"}>, but the function expects a string.

    }

    /**
     * Load product form for lot create/edit.
     *
     * @param Request $request
     * @param Lot $lot
     * @return mixed
     */
    public function loadProductBlock(Request $request, Lot $lot)

The parameter $request is not used and could be removed.

    {
        if($lot->category_id) {

The property category_id does not exist on object<App\Lot>. Since you implemented __get, maybe consider adding a @property annotation.

            $product = $this->products->createPlain($lot);

            return view('lots.partials.form.product', ['product' => $product, 'lot' => $lot]);
        }

        return 'false';
    }

    /**
     * Load specification
     *
     * @param Request $request
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */


    /**
     * Load improved spec.
     * 
     * @param Request $request
     * @return mixed
     */
    public function loadImprovedSpec(Request $request)
    {
        $spec = $this->improvedSpecs->createPlain($request->get('product_id'));
        
        return view('lots.partials.form.improved_specs', [ 'spec' => $spec ]);
    }

    /**
     * @param SaveLotRequest $request
     * @param Lot $lot
     * @return mixed
     */
    public function saveLot(SaveLotRequest $request, Lot $lot)
    {
        $lot = $this->lots->save($lot, $request->all());
        return redirect()->route('edit_lot', [ $lot ])

The method withStatus() does not exist on Illuminate\Http\RedirectResponse. Did you maybe mean status()?

            ->withStatus('You created lot successefully. Waiting for moderator verify it. You will be notificated!');
    }

    public function updateLot(SaveLotRequest $request, Lot $lot)

This method seems to be duplicated in your project.

    {
        $lot = $this->lots->save($lot, $request->all());
        $method = [];
        if ($request->input('method')) {
            $method  = $request->input('method');
        }
        $lotMethod = $this->lot_method->save($lot, $method);

It seems like $method defined by $request->input('method') on line 209 can also be of type string; however, App\Repositories\LotDeliveryPaymentRepository::save() does only seem to accept array, maybe add an additional type check?

$lotMethod is not used, you could remove the assignment.

        return response(array('respons'=>true));

array('respons' => true) is of type array<string,boolean,{"respons":"boolean"}>, but the function expects a string.

        
    }

    public function publishedLot(SaveLotRequest $request, Lot $lot)

This method seems to be duplicated in your project.

    {
        $lot = $this->lots->save($lot, $request->all());
        $method = [];
        if ($request->input('method')) {
            $method  = $request->input('method');
        }
        $lotMethod = $this->lot_method->save($lot, $method);

It seems like $method defined by $request->input('method') on line 221 can also be of type string; however, App\Repositories\LotDeliveryPaymentRepository::save() does only seem to accept array, maybe add an additional type check?

$lotMethod is not used, you could remove the assignment.

        return response(array('respons'=>true,'status'=>$lot->status));

array('respons' => true, 'status' => $lot->status) is of type array<string,?,{"respons":"boolean","status":"?"}>, but the function expects a string.

        
    }

    /**
     *
     */
    public function index()
    {
       /* dd(Lot::all());*/

60% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    /**
     * Show user's all lots;
     *
     * @return \Illuminate\View\View
     */
    public function myLots()
    {
        $lots = $this->lots->userLots($this->getUser(), 5);
        return view('lots.my_lots', compact('lots'));

The expression view('lots.my_lots', compact('lots')); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 245 which is incompatible with the return type documented by App\Http\Controllers\LotsController::myLots of type Illuminate\View\View.

    }

    /**
     * @param Lot $lot
     * @return mixed
     */
    public function show(Lot $lot)
    {
        return view('lots.show', compact('lot'));
    }


    /**
     * Get user from Guard\Auth
     *
     * @return \Illuminate\Contracts\Auth\Authenticatable|null
     */
    public function getUser()
    {
        return $this->auth->user();
    }
}