nxmad / Larapay

src/Traits/HasTransactions.php

<?php

declare(strict_types=1);

namespace Nxmad\Larapay\Traits;

use Nxmad\Larapay\Models\Transaction;

trait HasTransactions
{
    /**
     * Setup transaction for subject without saving to database.
     *
     * @param float  $amount
     * @param array  $meta
     * @param string $state
     *
     * @return mixed
     */
    public function setup(float $amount, $meta = [], string $state = Transaction::PENDING): Transaction
    {
        $class = $this->getTransactionClass();
        $meta = is_scalar($meta) ? ['description' => $meta] : $meta;

The condition is_scalar($meta) is always false.

        /**
         * @var Transaction
         */
        $transaction = (new $class)
            ->setSubject($this)
            ->fill(compact('amount', 'meta', 'state'));

        return $transaction;
    }

    /**
     * Setup transaction and save it immediately.
     *
     * @param float  $amount
     * @param array  $meta
     * @param string $state
     *
     * @return Transaction
     */
    public function transaction(float $amount, array $meta = [], string $state = Transaction::PENDING): Transaction
    {
        $transaction = $this->setup(...func_get_args());

func_get_args() is expanded, but the parameter $amount of Nxmad\Larapay\Traits\HasTransactions::setup() does not expect variable arguments.

        return $transaction($state);
    }

    /**
     * Determine if Model's balance is enough for transaction
     *
     * @param Transaction $transaction
     *
     * @return bool
     */
    public function canAfford(Transaction $transaction): bool
    {
        $balance = self::KEEP ? $this->attributes[self::KEEP] : $this->recalculateBalance();

The constant Nxmad\Larapay\Traits\HasTransactions::KEEP was not found. Maybe you did not declare it correctly or list all dependencies?

        return $balance >= abs($transaction->amount);

The property amount does not seem to exist on Nxmad\Larapay\Models\Transaction. Are you sure there is no database migration missing?

    }

    /**
     * Recalculate subject's balance.
     *
     * @return mixed
     */
    public function recalculateBalance()
    {
        return $this->transactions()
            ->where('state', Transaction::SUCCESSFUL)
            ->get()
            ->sum('amount');
    }

    /**
     * Get internal Transaction class name
     *
     * @return string
     */
    protected function getTransactionClass(): string
    {
        return app()->config->get('larapay.transaction');

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * Get primary value.
     *
     * @return mixed
     */
    public function getPrimaryValue()
    {
        return $this->{$this->primaryKey};
    }

    /**
     * Get polymorphic relation.
     *
     * @return \Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function transactions()
    {
        return $this->morphMany($this->getTransactionClass(), 'subject');

It seems like morphMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}