Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class AssetController |
||
16 | { |
||
17 | /** |
||
18 | * @var FilterManager |
||
19 | */ |
||
20 | private $filterManager; |
||
21 | |||
22 | /** |
||
23 | * @var boolean |
||
24 | */ |
||
25 | private $isDebug = false; |
||
26 | |||
27 | /** |
||
28 | * @var array |
||
29 | */ |
||
30 | private $cssFilters = array(); |
||
31 | |||
32 | /** |
||
33 | * @var array |
||
34 | */ |
||
35 | private $jsFilters = array(); |
||
36 | |||
37 | /** |
||
38 | * @param KernelInterface $kernel |
||
39 | * @param array $filters |
||
40 | */ |
||
41 | public function __construct(FilterManager $filterManager, KernelInterface $kernel = null, $filters = null) |
||
62 | |||
63 | /** |
||
64 | * @param Request $request |
||
65 | * @param object $contentDocument |
||
66 | * @param array $filters |
||
67 | * |
||
68 | * @return Response |
||
69 | */ |
||
70 | public function serveAsset(Request $request, $contentDocument, $filters = array()) |
||
98 | |||
99 | /** |
||
100 | * Helper action |
||
101 | * |
||
102 | * @param Request $request |
||
103 | * @param object $contentDocument |
||
104 | * @param array $filters |
||
105 | * |
||
106 | * @return Response |
||
107 | */ |
||
108 | View Code Duplication | public function serveJs(Request $request, $contentDocument, $filters = array()) |
|
123 | |||
124 | /** |
||
125 | * Helper action |
||
126 | * |
||
127 | * @param Request $request |
||
128 | * @param object $contentDocument |
||
129 | * @param array $filters |
||
130 | * |
||
131 | * @return Response |
||
132 | */ |
||
133 | View Code Duplication | public function serveCss(Request $request, $contentDocument, $filters = array()) |
|
148 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.