AssetController   A
last analyzed

Complexity

Total Complexity 20

Size/Duplication

Total Lines 134
Duplicated Lines 22.39 %

Coupling/Cohesion

Components 1
Dependencies 5

Importance

Changes 2
Bugs 1 Features 0
Metric Value
wmc 20
c 2
b 1
f 0
lcom 1
cbo 5
dl 30
loc 134
rs 10

4 Methods

Rating   Name   Duplication   Size   Complexity  
B __construct() 0 21 7
C serveAsset() 0 28 7
A serveJs() 15 15 3
A serveCss() 15 15 3

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
namespace NVBooster\PHPCRAssetsBundle\Controller;
3
4
use Symfony\Component\HttpFoundation\Request;
5
use Symfony\Component\HttpFoundation\Response;
6
use Assetic\Asset\StringAsset;
7
use Symfony\Component\HttpKernel\KernelInterface;
8
use Symfony\Bundle\AsseticBundle\FilterManager;
9
10
/**
11
 * AssetController
12
 *
13
 * @author nvb <[email protected]>
14
 */
15
class AssetController
16
{
17
    /**
18
     * @var FilterManager
19
     */
20
    private $filterManager;
21
22
    /**
23
     * @var boolean
24
     */
25
    private $isDebug = false;
26
27
    /**
28
     * @var array
29
     */
30
    private $cssFilters = array();
31
32
    /**
33
     * @var array
34
     */
35
    private $jsFilters = array();
36
37
    /**
38
     * @param KernelInterface $kernel
39
     * @param array           $filters
40
     */
41
    public function __construct(FilterManager $filterManager, KernelInterface $kernel = null, $filters = null)
42
    {
43
        if ($kernel) {
44
            $this->isDebug = $kernel->isDebug();
45
        }
46
47
        if (is_array($filters)) {
48
            if (key_exists('js', $filters)) {
49
                if (is_array($filters['js'])) {
50
                    $this->jsFilters = $filters['js'];
51
                }
52
            }
53
            if (key_exists('css', $filters)) {
54
                if (is_array($filters['css'])) {
55
                    $this->cssFilters = $filters['css'];
56
                }
57
            }
58
        }
59
60
        $this->filterManager = $filterManager;
61
    }
62
63
    /**
64
     * @param Request $request
65
     * @param object  $contentDocument
66
     * @param array   $filters
67
     *
68
     * @return Response
69
     */
70
    public function serveAsset(Request $request, $contentDocument, $filters = array())
71
    {
72
        $response = new Response();
73
        $response->setStatusCode(200);
74
        $response->setLastModified($contentDocument->getUpdatedAt());
75
        $response->setPublic();
76
77
        if (!$this->isDebug && $response->isNotModified($request)) {
78
            return $response;
79
        }
80
81
        $asset = new StringAsset($contentDocument->getContent());
82
        $asset->load();
83
84
        foreach ($filters as $filter) {
85
            if (($filter[0] !== '?') || (!$this->isDebug)) {
86
                if ($processor = $this->filterManager->get(preg_replace('@^\?@', '', $filter))) {
87
                    $processor->filterDump($asset);
88
                }
89
            }
90
        }
91
92
        $response->setContent($asset->getContent());
93
94
        $response->prepare($request);
95
96
        return $response;
97
    }
98
99
    /**
100
     * Helper action
101
     *
102
     * @param Request $request
103
     * @param object  $contentDocument
104
     * @param array   $filters
105
     *
106
     * @return Response
107
     */
108 View Code Duplication
    public function serveJs(Request $request, $contentDocument, $filters = array())
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
109
    {
110
        if ($filters === false) {
111
            $mergedFilters = array();
112
        } elseif (count($filters)) {
113
            $mergedFilters = $filters;
114
        } else {
115
            $mergedFilters = $this->jsFilters;
116
        }
117
118
        $response = $this->serveAsset($request, $contentDocument, $mergedFilters);
119
        $response->headers->set('Content-Type', 'text/javascript');
120
121
        return $response;
122
    }
123
124
    /**
125
     * Helper action
126
     *
127
     * @param Request $request
128
     * @param object  $contentDocument
129
     * @param array   $filters
130
     *
131
     * @return Response
132
     */
133 View Code Duplication
    public function serveCss(Request $request, $contentDocument, $filters = array())
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
134
    {
135
        if ($filters === false) {
136
            $mergedFilters = array();
137
        } elseif (count($filters)) {
138
            $mergedFilters = $filters;
139
        } else {
140
            $mergedFilters = $this->cssFilters;
141
        }
142
143
        $response = $this->serveAsset($request, $contentDocument, $mergedFilters);
144
        $response->headers->set('Content-Type', 'text/css');
145
146
        return $response;
147
    }
148
}