nuxsmin / sysPass

lib/SP/Http/Xml.php

<?php
/**
 * sysPass
 *
 * @author    nuxsmin
 * @link      https://syspass.org
 * @copyright 2012-2019, Rubén Domínguez nuxsmin@$syspass.org
 *
 * This file is part of sysPass.
 *
 * sysPass is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * sysPass is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 *  along with sysPass.  If not, see <http://www.gnu.org/licenses/>.
 */

namespace SP\Http;

use Klein\Response;

/**
 * Class Xml
 *
 * @package SP\Http
 */
final class Xml
{
    const SAFE = [
        'from' => ['&', '<', '>', '"', "\'"],
        'to' => ['&amp;', '&lt;', '&gt;', '&quot;', '&apos;']
    ];

    /**
     * @var Response
     */
    private $response;

    /**
     * Xml constructor.
     *
     * @param Response $response
     */
    public function __construct(Response $response)
    {
        $this->response = $response;
    }

    /**
     * Devuelve una respuesta en formato XML con el estado y el mensaje.
     *
     * @param string $description mensaje a devolver
     * @param int    $status      devuelve el estado
     */
    public function printXml(string $description, int $status = 1)
    {
        if (!is_string($description)) {

The condition is_string($description) is always true.

            return;
        }

        $xml[] = '<?xml version="1.0" encoding="UTF-8" standalone="yes"?>';

$xml was never initialized. Although not strictly required by PHP, it is generally a good practice to add $xml = array(); before regardless.

        $xml[] = '<root>';
        $xml[] = '<status>' . $status . '</status>';
        $xml[] = '<description>' . $this->safeString($description) . '</description>';
        $xml[] = '</root>';

        $this->response
            ->header('Content-Type', 'application/xml')
            ->body(implode(PHP_EOL, $xml))
            ->send(true);
    }

    /**
     * @param string $string
     *
     * @return mixed
     */
    public function safeString(string $string)
    {
        return str_replace(self::SAFE['from'], self::SAFE['to'], $string);
    }
}