ClientServiceTest::testDelete() - Code Metrics - Inspection of "* [ADD] Unit testing. Work in progress" - nuxsmin/sysPass - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — devel-3.0 ( 09ea81...3c7891 )

by Rubén

created 2018-08-11 07:46 UTC

ClientServiceTest::testDelete() A

↳ Parent: ClientServiceTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	8
nc	1
nop	0
dl	0
loc	18
rs	10
c	0
b	0
f	0

<?php
/**
 * sysPass
 *
 * @author    nuxsmin
 * @link      https://syspass.org
 * @copyright 2012-2018, Rubén Domínguez nuxsmin@$syspass.org
 *
 * This file is part of sysPass.
 *
 * sysPass is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * sysPass is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 *  along with sysPass.  If not, see <http://www.gnu.org/licenses/>.
 */

namespace SP\Tests\Services\Client;

use SP\Core\Context\ContextInterface;
use SP\Core\Exceptions\ConstraintException;
use SP\DataModel\ClientData;
use SP\DataModel\ItemSearchData;
use SP\Repositories\DuplicatedItemException;
use SP\Repositories\NoSuchItemException;
use SP\Services\Client\ClientService;
use SP\Services\ServiceException;
use SP\Services\User\UserLoginResponse;
use SP\Storage\Database\DatabaseConnectionData;
use SP\Tests\DatabaseTestCase;
use function SP\Tests\setupContext;

/**
 * Class ClientServiceTest
 *
 * @package SP\Tests\Services\Client
 */
class ClientServiceTest extends DatabaseTestCase
{
    /**
     * @var \Closure
     */
    private static $setupUser;
    /**
     * @var ClientService
     */
    private static $service;

    /**
     * @throws \DI\NotFoundException
     * @throws \SP\Core\Context\ContextException
     * @throws \DI\DependencyException
     */
    public static function setUpBeforeClass()
    {
        $dic = setupContext();

        self::$dataset = 'syspass.xml';

        // Datos de conexión a la BBDD
        self::$databaseConnectionData = $dic->get(DatabaseConnectionData::class);

        // Inicializar el servicio
        self::$service = $dic->get(ClientService::class);

        self::$setupUser = function (UserLoginResponse $response) use ($dic) {
            $response->setLastUpdate(time());

            $dic->get(ContextInterface::class)->setUserData($response);
        };
    }

    /**
     * @throws \SP\Core\Exceptions\ConstraintException
     * @throws \SP\Core\Exceptions\QueryException
     */
    public function testSearch()
    {
        $itemSearchData = new ItemSearchData();
        $itemSearchData->setLimitCount(10);
        $itemSearchData->setSeachString('google');

        $result = self::$service->search($itemSearchData);
        $data = $result->getDataAsArray();

        $this->assertEquals(1, $result->getNumRows());
        $this->assertCount(1, $data);
        $this->assertInstanceOf(ClientData::class, $data[0]);
        $this->assertEquals(1, $data[0]->id);
        $this->assertEquals('Google Inc.', $data[0]->description);

        $itemSearchData = new ItemSearchData();
        $itemSearchData->setLimitCount(10);
        $itemSearchData->setSeachString('prueba');

        $result = self::$service->search($itemSearchData);

        $this->assertEquals(0, $result->getNumRows());
        $this->assertCount(0, $result->getDataAsArray());
    }

    /**
     * @throws \SP\Core\Exceptions\ConstraintException
     * @throws \SP\Core\Exceptions\QueryException
     */
    public function testGetAllBasic()
    {
        $count = $this->conn->getRowCount('Client');

        $results = self::$service->getAllBasic();

        $this->assertCount($count, $results);

        $this->assertInstanceOf(ClientData::class, $results[0]);
        $this->assertEquals('Apple', $results[0]->getName());

        $this->assertInstanceOf(ClientData::class, $results[1]);
        $this->assertEquals('Google', $results[1]->getName());

        $this->assertInstanceOf(ClientData::class, $results[2]);
        $this->assertEquals('Microsoft', $results[2]->getName());
    }

    /**
     * @throws ConstraintException
     * @throws NoSuchItemException
     * @throws \SP\Core\Exceptions\QueryException
     */
    public function testGetById()
    {
        $client = self::$service->getById(1);

        $this->assertEquals('Google', $client->getName());
        $this->assertEquals('Google Inc.', $client->getDescription());

        $client = self::$service->getById(2);

        $this->assertEquals('Apple', $client->getName());
        $this->assertEquals('Apple Inc.', $client->getDescription());

        $this->expectException(NoSuchItemException::class);

        self::$service->getById(10);
    }

    /**
     * @throws ConstraintException
     * @throws \SP\Core\Exceptions\QueryException
     */
    public function testGetAllForUserAdmin()
    {
        $this->assertCount(3, self::$service->getAllForUser());
    }

    /**
     * @throws ConstraintException
     * @throws \SP\Core\Exceptions\QueryException
     */
    public function testGetAllForUser()
    {
        $userData = new UserLoginResponse();
        $userData->setId(4);

        self::$setupUser->call($this, $userData);

        $this->assertCount(1, self::$service->getAllForUser());
    }

    /**
     * @throws \SP\Core\Exceptions\ConstraintException
     * @throws \SP\Core\Exceptions\QueryException
     * @throws \SP\Core\Exceptions\SPException
     * @throws \SP\Repositories\DuplicatedItemException
     */
    public function testCreate()
    {
        $data = new ClientData();
        $data->name = 'Cliente prueba';
        $data->description = 'Descripción prueba';
        $data->isGlobal = 1;

        $id = self::$service->create($data);

        // Comprobar que el Id devuelto corresponde con el cliente creado
        $result = self::$service->getById($id);

        $this->assertEquals($data->name, $result->getName());
        $this->assertEquals($data->isGlobal, $result->getIsGlobal());

        $countAfter = $this->conn->getRowCount('Client');

        $this->assertEquals(4, $countAfter);

        $this->expectException(DuplicatedItemException::class);

        self::$service->create($data);
    }

    /**
     * @throws \SP\Core\Exceptions\ConstraintException
     * @throws \SP\Core\Exceptions\QueryException
     * @throws \SP\Services\ServiceException
     */
    public function testDeleteByIdBatch()
    {
        $countBefore = $this->conn->getRowCount('Client');

        self::$service->deleteByIdBatch([3]);

        $countAfter = $this->conn->getRowCount('Client');

        $this->assertEquals($countBefore - 1, $countAfter);

        // Comprobar que se produce una excepción al tratar de eliminar clientes usados
        $this->expectException(ConstraintException::class);

        self::$service->deleteByIdBatch([1, 2]);

        $this->expectException(ServiceException::class);

        self::$service->deleteByIdBatch([10]);
    }

    /**
     * @throws ConstraintException
     * @throws NoSuchItemException
     * @throws \SP\Core\Exceptions\QueryException
     */
    public function testGetByName()
    {
        $data = self::$service->getByName('Google');

        $this->assertEquals(1, $data->getId());
        $this->assertEquals('Google Inc.', $data->getDescription());

        $data = self::$service->getByName('Apple');

        $this->assertEquals(2, $data->getId());
        $this->assertEquals('Apple Inc.', $data->getDescription());

        // Se comprueba que el hash generado es el mismo en para el nombre 'Web'
        $data = self::$service->getByName(' google. ');

        $this->assertEquals(1, $data->getId());
        $this->assertEquals('Google Inc.', $data->getDescription());

        $this->expectException(NoSuchItemException::class);

        self::$service->getByName('Amazon');
    }

    /**
     * @throws \SP\Core\Exceptions\SPException
     */
    public function testDelete()
    {
        $countBefore = $this->conn->getRowCount('Client');

        self::$service->delete(3);

        $countAfter = $this->conn->getRowCount('Client');

        $this->assertEquals($countBefore - 1, $countAfter);

        // Comprobar que se produce una excepción al tratar de eliminar clientes usados
        $this->expectException(ConstraintException::class);

        self::$service->delete(2);

        $this->expectException(NoSuchItemException::class);

        self::$service->delete(10);
    }

    /**
     * @throws ConstraintException
     * @throws \SP\Core\Exceptions\QueryException
     * @throws \SP\Core\Exceptions\SPException
     */
    public function testUpdate()
    {
        $data = new ClientData();
        $data->id = 1;
        $data->name = 'Cliente prueba';
        $data->description = 'Descripción cliente prueba';

        self::$service->update($data);

        $result = self::$service->getById(1);

        $this->assertEquals($data->name, $result->getName());
        $this->assertEquals($data->description, $result->getDescription());

        // Comprobar la a actualización con un nombre duplicado comprobando su hash
        $data = new ClientData();
        $data->id = 1;
        $data->name = ' apple.';

        $this->expectException(DuplicatedItemException::class);

        self::$service->update($data);
    }
}


1			<?php
2			/**
3			* sysPass
4			*
5			* @author nuxsmin
6			* @link https://syspass.org
7			* @copyright 2012-2018, Rubén Domínguez nuxsmin@$syspass.org
8			*
9			* This file is part of sysPass.
10			*
11			* sysPass is free software: you can redistribute it and/or modify
12			* it under the terms of the GNU General Public License as published by
13			* the Free Software Foundation, either version 3 of the License, or
14			* (at your option) any later version.
15			*
16			* sysPass is distributed in the hope that it will be useful,
17			* but WITHOUT ANY WARRANTY; without even the implied warranty of
18			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19			* GNU General Public License for more details.
20			*
21			* You should have received a copy of the GNU General Public License
22			* along with sysPass. If not, see <http://www.gnu.org/licenses/>.
23			*/
24
25			namespace SP\Tests\Services\Client;
26
27			use SP\Core\Context\ContextInterface;
28			use SP\Core\Exceptions\ConstraintException;
29			use SP\DataModel\ClientData;
30			use SP\DataModel\ItemSearchData;
31			use SP\Repositories\DuplicatedItemException;
32			use SP\Repositories\NoSuchItemException;
33			use SP\Services\Client\ClientService;
34			use SP\Services\ServiceException;
35			use SP\Services\User\UserLoginResponse;
36			use SP\Storage\Database\DatabaseConnectionData;
37			use SP\Tests\DatabaseTestCase;
38			use function SP\Tests\setupContext;
39
40			/**
41			* Class ClientServiceTest
42			*
43			* @package SP\Tests\Services\Client
44			*/
45			class ClientServiceTest extends DatabaseTestCase
46			{
47			/**
48			* @var \Closure
49			*/
50			private static $setupUser;
51			/**
52			* @var ClientService
53			*/
54			private static $service;
55
56			/**
57			* @throws \DI\NotFoundException
58			* @throws \SP\Core\Context\ContextException
59			* @throws \DI\DependencyException
60			*/
61			public static function setUpBeforeClass()
62			{
63			$dic = setupContext();
64
65			self::$dataset = 'syspass.xml';
66
67			// Datos de conexión a la BBDD
68			self::$databaseConnectionData = $dic->get(DatabaseConnectionData::class);
69
70			// Inicializar el servicio
71			self::$service = $dic->get(ClientService::class);
72
73			self::$setupUser = function (UserLoginResponse $response) use ($dic) {
74			$response->setLastUpdate(time());
75
76			$dic->get(ContextInterface::class)->setUserData($response);
77			};
78			}
79
80			/**
81			* @throws \SP\Core\Exceptions\ConstraintException
82			* @throws \SP\Core\Exceptions\QueryException
83			*/
84			public function testSearch()
85			{
86			$itemSearchData = new ItemSearchData();
87			$itemSearchData->setLimitCount(10);
88			$itemSearchData->setSeachString('google');
89
90			$result = self::$service->search($itemSearchData);
91			$data = $result->getDataAsArray();
92
93			$this->assertEquals(1, $result->getNumRows());
94			$this->assertCount(1, $data);
95			$this->assertInstanceOf(ClientData::class, $data[0]);
96			$this->assertEquals(1, $data[0]->id);
97			$this->assertEquals('Google Inc.', $data[0]->description);
98
99			$itemSearchData = new ItemSearchData();
100			$itemSearchData->setLimitCount(10);
101			$itemSearchData->setSeachString('prueba');
102
103			$result = self::$service->search($itemSearchData);
104
105			$this->assertEquals(0, $result->getNumRows());
106			$this->assertCount(0, $result->getDataAsArray());
107			}
108
109			/**
110			* @throws \SP\Core\Exceptions\ConstraintException
111			* @throws \SP\Core\Exceptions\QueryException
112			*/
113			public function testGetAllBasic()
114			{
115			$count = $this->conn->getRowCount('Client');
116
117			$results = self::$service->getAllBasic();
118
119			$this->assertCount($count, $results);
120
121			$this->assertInstanceOf(ClientData::class, $results[0]);
122			$this->assertEquals('Apple', $results[0]->getName());
123
124			$this->assertInstanceOf(ClientData::class, $results[1]);
125			$this->assertEquals('Google', $results[1]->getName());
126
127			$this->assertInstanceOf(ClientData::class, $results[2]);
128			$this->assertEquals('Microsoft', $results[2]->getName());
129			}
130
131			/**
132			* @throws ConstraintException
133			* @throws NoSuchItemException
134			* @throws \SP\Core\Exceptions\QueryException
135			*/
136			public function testGetById()
137			{
138			$client = self::$service->getById(1);
139
140			$this->assertEquals('Google', $client->getName());
141			$this->assertEquals('Google Inc.', $client->getDescription());
142
143			$client = self::$service->getById(2);
144
145			$this->assertEquals('Apple', $client->getName());
146			$this->assertEquals('Apple Inc.', $client->getDescription());
147
148			$this->expectException(NoSuchItemException::class);
149
150			self::$service->getById(10);
151			}
152
153			/**
154			* @throws ConstraintException
155			* @throws \SP\Core\Exceptions\QueryException
156			*/
157			public function testGetAllForUserAdmin()
158			{
159			$this->assertCount(3, self::$service->getAllForUser());
160			}
161
162			/**
163			* @throws ConstraintException
164			* @throws \SP\Core\Exceptions\QueryException
165			*/
166			public function testGetAllForUser()
167			{
168			$userData = new UserLoginResponse();
169			$userData->setId(4);
170
171			self::$setupUser->call($this, $userData);
172
173			$this->assertCount(1, self::$service->getAllForUser());
174			}
175
176			/**
177			* @throws \SP\Core\Exceptions\ConstraintException
178			* @throws \SP\Core\Exceptions\QueryException
179			* @throws \SP\Core\Exceptions\SPException
180			* @throws \SP\Repositories\DuplicatedItemException
181			*/
182			public function testCreate()
183			{
184			$data = new ClientData();
185			$data->name = 'Cliente prueba';
186			$data->description = 'Descripción prueba';
187			$data->isGlobal = 1;
188
189			$id = self::$service->create($data);
190
191			// Comprobar que el Id devuelto corresponde con el cliente creado
192			$result = self::$service->getById($id);
193
194			$this->assertEquals($data->name, $result->getName());
195			$this->assertEquals($data->isGlobal, $result->getIsGlobal());
196
197			$countAfter = $this->conn->getRowCount('Client');
198
199			$this->assertEquals(4, $countAfter);
200
201			$this->expectException(DuplicatedItemException::class);
202
203			self::$service->create($data);
204			}
205
206			/**
207			* @throws \SP\Core\Exceptions\ConstraintException
208			* @throws \SP\Core\Exceptions\QueryException
209			* @throws \SP\Services\ServiceException
210			*/
211			public function testDeleteByIdBatch()
212			{
213			$countBefore = $this->conn->getRowCount('Client');
214
215			self::$service->deleteByIdBatch([3]);
216
217			$countAfter = $this->conn->getRowCount('Client');
218
219			$this->assertEquals($countBefore - 1, $countAfter);
220
221			// Comprobar que se produce una excepción al tratar de eliminar clientes usados
222			$this->expectException(ConstraintException::class);
223
224			self::$service->deleteByIdBatch([1, 2]);
225
226			$this->expectException(ServiceException::class);
227
228			self::$service->deleteByIdBatch([10]);
229			}
230
231			/**
232			* @throws ConstraintException
233			* @throws NoSuchItemException
234			* @throws \SP\Core\Exceptions\QueryException
235			*/
236			public function testGetByName()
237			{
238			$data = self::$service->getByName('Google');
239
240			$this->assertEquals(1, $data->getId());
241			$this->assertEquals('Google Inc.', $data->getDescription());
242
243			$data = self::$service->getByName('Apple');
244
245			$this->assertEquals(2, $data->getId());
246			$this->assertEquals('Apple Inc.', $data->getDescription());
247
248			// Se comprueba que el hash generado es el mismo en para el nombre 'Web'
249			$data = self::$service->getByName(' google. ');
250
251			$this->assertEquals(1, $data->getId());
252			$this->assertEquals('Google Inc.', $data->getDescription());
253
254			$this->expectException(NoSuchItemException::class);
255
256			self::$service->getByName('Amazon');
257			}
258
259			/**
260			* @throws \SP\Core\Exceptions\SPException
261			*/
262			public function testDelete()
263			{
264			$countBefore = $this->conn->getRowCount('Client');
265
266			self::$service->delete(3);
267
268			$countAfter = $this->conn->getRowCount('Client');
269
270			$this->assertEquals($countBefore - 1, $countAfter);
271
272			// Comprobar que se produce una excepción al tratar de eliminar clientes usados
273			$this->expectException(ConstraintException::class);
274
275			self::$service->delete(2);
276
277			$this->expectException(NoSuchItemException::class);
278
279			self::$service->delete(10);
280			}
281
282			/**
283			* @throws ConstraintException
284			* @throws \SP\Core\Exceptions\QueryException
285			* @throws \SP\Core\Exceptions\SPException
286			*/
287			public function testUpdate()
288			{
289			$data = new ClientData();
290			$data->id = 1;
291			$data->name = 'Cliente prueba';
292			$data->description = 'Descripción cliente prueba';
293
294			self::$service->update($data);
295
296			$result = self::$service->getById(1);
297
298			$this->assertEquals($data->name, $result->getName());
299			$this->assertEquals($data->description, $result->getDescription());
300
301			// Comprobar la a actualización con un nombre duplicado comprobando su hash
302			$data = new ClientData();
303			$data->id = 1;
304			$data->name = ' apple.';
305
306			$this->expectException(DuplicatedItemException::class);
307
308			self::$service->update($data);
309			}
310			}
311

nuxsmin / sysPass

Push — devel-3.0 ( 09ea81...3c7891 )

ClientServiceTest::testDelete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like