Generic - Code Metrics - Inspection of "Merge branch '8.1.x' of github.com:nuvoleweb/drupa..." - nuvoleweb/drupal-behat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 8.1.x ( fb062c...e20c53 )

by Antonio

created 2016-09-15 13:17 UTC

Generic B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	328
Duplicated Lines	19.82 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
dl	65
loc	328
c	0
b	0
f	0
wmc	38
lcom	1
cbo	4
rs	8.3999

16 Methods

Rating	Name	Duplication	Size	Complexity
A	userCanContent()	16	16	2
A	userCanNotContent()	15	15	2
A	assertContentEditLink()	0	5	2
A	assertNoContentEditLink()	0	5	2
A	iShouldSeeInTheHeader()	0	6	2
A	assertElementType()	0	5	2
A	getContentEditLink()	0	20	4
A	beforeMobileScenario()	0	3	1
A	afterJavascriptScenario()	0	3	1
A	adjustScreenSizeBeforeStep()	0	8	2
B	iShouldSeeTheField()	17	17	5
B	iShouldNotSeeTheField()	17	17	5
A	iAmViewingTheTerm()	0	3	1
A	iAmEditingTheTerm()	0	3	1
A	visitTermPage()	0	20	2
A	shouldPrecede()	0	14	4

How to fix Duplicated Code

<?php

namespace NuvoleWeb\Drupal\DrupalExtension\Traits;

use Behat\Mink\Element\NodeElement;
use Behat\Mink\Exception\ExpectationException;
use Behat\Mink\Exception\UnsupportedDriverActionException;

/**
 * Trait Generic.
 *
 * @package Nuvole\Drupal\Behat\Traits
 */
trait Generic {

  /**
   * Default screen size.
   */
  protected $defaultScreenSize = ['width' => 1024, 'height' => 768];

  /**
   * Screen size in use.
   */
  protected $screenSize = ['width' => 1024, 'height' => 768];

  /**
   * Assert that given user can perform given operation on given content.
   *
   * @param string $name
   *    User name.
   * @param string $op
   *    Operation: view, edit or delete.
   * @param string $title
   *    Content title.
   *
   * @throws \Exception
   *   If user cannot perform given operation on given content.
   *
   * @Then :name can :op content :content
   */
  public function userCanContent($name, $op, $title) {


    $op = strtr($op, array('edit' => 'update'));
    $node = $this->loadNodeByName($title);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $account = user_load_by_name($name);
    $access = $node->access($op, $account);

    if (!$access) {
      $params = array(
        '@name' => $name,
        '@op' => $op,
        '@content' => $title,
      );
      throw new \Exception(format_string("@name can not @op @content.", $params));

    }
  }

  /**
   * Assert that given user cannot perform given operation on given content.
   *
   * @param string $name
   *    User name.
   * @param string $op
   *    Operation: view, edit or delete.
   * @param string $title
   *    Content title.
   *
   * @throws \Exception
   *   If user can perform given operation on given content.
   *
   * @Then :name can not :op content :content
   * @Then :name cannot :op content :content
   */
  public function userCanNotContent($name, $op, $title) {

    $op = strtr($op, array('edit' => 'update'));
    $node = $this->loadNodeByName($title);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $account = user_load_by_name($name);
    $access = $node->access($op, $account);

    if ($access) {
      $params = array(
        '@name' => $name,
        '@op' => $op,
        '@content' => $title,
      );
      throw new \Exception(format_string("@name can @op @content but should not.", $params));

    }
  }

  /**
   * Assert presence of content edit link given its name and content title.
   *
   * @param string $link
   *    Link "name" HTML attribute.
   * @param string $title
   *    Content title.
   *
   * @throws \Behat\Mink\Exception\ExpectationException
   *    If no edit link for given content has been found.
   *
   * @Then I should see the link :link to edit content :content
   */
  public function assertContentEditLink($link, $title) {
    if (!$this->getContentEditLink($link, $title)) {
      throw new ExpectationException("No '$link' link to edit '$title' has been found.", $this->getSession());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
  }

  /**
   * Assert absence of content edit link given its content title.
   *
   * @param string $title
   *    Content title.
   *
   * @throws \Behat\Mink\Exception\ExpectationException
   *    If edit link for given content has been found.
   *
   * @Then I should not see a link to edit content :content
   */
  public function assertNoContentEditLink($title) {
    if ($this->getContentEditLink(NULL, $title)) {
      throw new ExpectationException("link to edit '$title' has been found.", $this->getSession());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
  }

  /**
   * Assert string in HTTP response header.
   *
   * @Then I should see in the header :header::value
   */
  public function iShouldSeeInTheHeader($header, $value) {
    $headers = $this->getSession()->getResponseHeaders();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    if ($headers[$header] != $value) {
      throw new \Exception(sprintf("Did not see %s with value %s.", $header, $value));
    }
  }

  /**
   * Checks that the given element is of the given type.
   *
   * @param NodeElement $element
   *   The element to check.
   * @param string $type
   *   The expected type.
   *
   * @throws ExpectationException
   *   Thrown when the given element is not of the expected type.
   */
  public function assertElementType(NodeElement $element, $type) {
    if ($element->getTagName() !== $type) {
      throw new ExpectationException("The element is not a '$type'' field.", $this->getSession());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
  }

  /**
   * Get the edit link for a node.
   *
   * @param string $link
   *   The link name.
   * @param string $title
   *   The node title.
   *
   * @return \Behat\Mink\Element\NodeElement|null
   *   The link if found.
   *
   * @throws \Exception
   */
  public function getContentEditLink($link, $title) {
    $node = $this->loadNodeByName($title);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

    /** @var DocumentElement $element */
    $element = $this->getSession()->getPage();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

    $locator = ($link ? array('link', sprintf("'%s'", $link)) : array('link', "."));

    /** @var NodeElement[] $links */
    $links = $element->findAll('named', $locator);

    // Loop over all the links on the page and check for the node edit path.
    foreach ($links as $result) {
      $target = $result->getAttribute('href');
      if (strpos($target, 'node/' . $node->id() . '/edit') !== FALSE) {
        return $result;
      }
    }
    return NULL;
  }

  /**
   * Set browser size to mobile.
   *
   * @BeforeScenario @javascript&&@mobile
   */
  public function beforeMobileScenario() {
    $this->screenSize = ['width' => 450, 'height' => 768];
  }

  /**
   * Reset browser size.
   *
   * @AfterScenario @javascript
   */
  public function afterJavascriptScenario() {
    $this->screenSize = $this->defaultScreenSize;
  }

  /**
   * Resize the browser window.
   *
   * @BeforeStep
   */
  public function adjustScreenSizeBeforeStep() {
    try {
      // We make sure all selenium drivers use the same screen size.
      $this->getSession()->resizeWindow($this->screenSize['width'], $this->screenSize['height'], 'current');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    catch (UnsupportedDriverActionException $e) {

    }
  }

  /**
   * Assert presence of given field on the page.
   *
   * @Then I should see the field :field
   */
  public function iShouldSeeTheField($field) {

    $element = $this->getSession()->getPage();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $result = $element->findField($field);
    try {
      if ($result && !$result->isVisible()) {
        throw new \Exception(sprintf("No field '%s' on the page %s", $field, $this->getSession()->getCurrentUrl()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
      }
    }
    catch (UnsupportedDriverActionException $e) {
      // We catch the UnsupportedDriverActionException exception in case
      // this step is not being performed by a driver that supports javascript.
      // All other exceptions are valid.
    }
    if (empty($result)) {
      throw new \Exception(sprintf("No field '%s' on the page %s", $field, $this->getSession()->getCurrentUrl()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
  }

  /**
   * Assert absence of given field.
   *
   * @Then I should not see the field :field
   */
  public function iShouldNotSeeTheField($field) {

    $element = $this->getSession()->getPage();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $result = $element->findField($field);
    try {
      if ($result && $result->isVisible()) {
        throw new \Exception(sprintf("The field '%s' was present on the page %s and was not supposed to be", $field, $this->getSession()->getCurrentUrl()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
      }
    }
    catch (UnsupportedDriverActionException $e) {
      // We catch the UnsupportedDriverActionException exception in case
      // this step is not being performed by a driver that supports javascript.
      // All other exceptions are valid.
      if ($result) {
        throw new \Exception(sprintf("The field '%s' was present on the page %s and was not supposed to be", $field, $this->getSession()->getCurrentUrl()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
      }
    }
  }

  /**
   * Visit taxonomy term page given its type and name.
   *
   * @Given I am visiting the :type term :title
   * @Given I visit the :type term :title
   */
  public function iAmViewingTheTerm($type, $title) {
    $this->visitTermPage('view', $type, $title);
  }

  /**
   * Visit taxonomy term edit page given its type and name.
   *
   * @Given I am editing the :type term :title
   * @Given I edit the :type term :title
   */
  public function iAmEditingTheTerm($type, $title) {
    $this->visitTermPage('edit', $type, $title);
  }

  /**
   * Provides a common step definition callback for node pages.
   *
   * @param string $op
   *   The operation being performed: 'view', 'edit', 'delete'.
   * @param string $type
   *   The node type either as id or as label.
   * @param string $title
   *   The node title.
   *
   * @throws ExpectationException
   *   When the node does not exist.
   */
  protected function visitTermPage($op, $type, $title) {
    $type = $this->convertLabelToTermTypeId($type);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $result = \Drupal::entityQuery('taxonomy_term')
      ->condition('vid', $type)
      ->condition('name', $title)
      ->execute();

    if (!empty($result)) {
      $tid = array_shift($result);
      $path = [
        'view' => "taxonomy/term/$tid",
        'edit' => "taxonomy/term/$tid/edit",
        'delete' => "taxonomy/term/$tid/delete",
      ];
      $this->visitPath($path[$op]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    else {
      throw new ExpectationException("No term with vocabulary '$type' and title '$title' has been found.", $this->getSession());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
  }

  /**
   * Assert first element precedes second one.
   *
   * @Then :first should precede :second
   */
  public function shouldPrecede($first, $second) {
    $page = $this->getSession()->getPage()->getText();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $pos1 = strpos($page, $first);
    if ($pos1 === FALSE) {
      throw new ExpectationException("Text not found: '$first'.", $this->getSession());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    $pos2 = strpos($page, $second);
    if ($pos2 === FALSE) {
      throw new ExpectationException("Text not found: '$second'.", $this->getSession());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    if ($pos2 < $pos1) {
      throw new \Exception("Text '$first' does not precede text '$second'.");
    }
  }

}


1			<?php
2
3			namespace NuvoleWeb\Drupal\DrupalExtension\Traits;
4
5			use Behat\Mink\Element\NodeElement;
6			use Behat\Mink\Exception\ExpectationException;
7			use Behat\Mink\Exception\UnsupportedDriverActionException;
8
9			/**
10			* Trait Generic.
11			*
12			* @package Nuvole\Drupal\Behat\Traits
13			*/
14			trait Generic {
15
16			/**
17			* Default screen size.
18			*/
19			protected $defaultScreenSize = ['width' => 1024, 'height' => 768];
20
21			/**
22			* Screen size in use.
23			*/
24			protected $screenSize = ['width' => 1024, 'height' => 768];
25
26			/**
27			* Assert that given user can perform given operation on given content.
28			*
29			* @param string $name
30			* User name.
31			* @param string $op
32			* Operation: view, edit or delete.
33			* @param string $title
34			* Content title.
35			*
36			* @throws \Exception
37			* If user cannot perform given operation on given content.
38			*
39			* @Then :name can :op content :content
40			*/

nuvoleweb / drupal-behat

Push — 8.1.x ( fb062c...e20c53 )

Generic B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like