Completed
Push — stable ( ba1838...bafb54 )
by Nuno
09:32
created

Notifier::send()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
c 0
b 0
f 0
rs 10
cc 1
eloc 2
nc 1
nop 1
1
<?php
2
3
/**
4
 * This file is part of Laravel Desktop Notifier.
5
 *
6
 * (c) Nuno Maduro <[email protected]>
7
 *
8
 *  For the full copyright and license information, please view the LICENSE
9
 *  file that was distributed with this source code.
10
 */
11
12
namespace NunoMaduro\LaravelDesktopNotifier;
13
14
use Joli\JoliNotif\Notification;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, NunoMaduro\LaravelDesktopNotifier\Notification.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
15
use Joli\JoliNotif\Notifier as BaseNotifier;
16
use \NunoMaduro\LaravelDesktopNotifier\Contracts\Notifier as NotifierContract;
17
18
/**
19
 * The concrete implementation of the notifier.
20
 *
21
 * @author Nuno Maduro <[email protected]>
22
 */
23
class Notifier implements NotifierContract
24
{
25
    /**
26
     * @var \Joli\JoliNotif\Notifier
27
     */
28
    protected $notifier;
29
30
    /**
31
     * Notifier constructor.
32
     *
33
     * @param \Joli\JoliNotif\Notifier $notifier
34
     */
35
    public function __construct(BaseNotifier $notifier)
36
    {
37
        $this->notifier = $notifier;
38
    }
39
40
    /**
41
     * {@inheritdoc}
42
     */
43
    public function isSupported()
44
    {
45
        return $this->notifier->isSupported();
46
    }
47
48
    /**
49
     * {@inheritdoc}
50
     */
51
    public function getPriority()
52
    {
53
        return $this->notifier->getPriority();
54
    }
55
56
    /**
57
     * {@inheritdoc}
58
     */
59
    public function send(Notification $notification)
60
    {
61
        return $this->notifier->send($notification);
62
    }
63
}
64