Issues in class-wp-feed-cache-transient.php (ticket-41057) - Issues in ticket-41057 - ntwb/wordpress - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4967)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/wp-includes/class-wp-feed-cache-transient.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Feed API: WP_Feed_Cache_Transient class
 *
 * @package WordPress
 * @subpackage Feed
 * @since 4.7.0
 */

/**
 * Core class used to implement feed cache transients.
 *
 * @since 2.8.0
 */
class WP_Feed_Cache_Transient {

	/**
	 * Holds the transient name.
	 *
	 * @since 2.8.0
	 * @access public
	 * @var string
	 */
	public $name;

	/**
	 * Holds the transient mod name.
	 *
	 * @since 2.8.0
	 * @access public
	 * @var string
	 */
	public $mod_name;

	/**
	 * Holds the cache duration in seconds.
	 *
	 * Defaults to 43200 seconds (12 hours).
	 *
	 * @since 2.8.0
	 * @access public
	 * @var int
	 */
	public $lifetime = 43200;

	/**
	 * Constructor.
	 *
	 * @since 2.8.0
	 * @since 3.2.0 Updated to use a PHP5 constructor.
	 * @access public
	 *
	 * @param string $location  URL location (scheme is used to determine handler).
	 * @param string $filename  Unique identifier for cache object.
	 * @param string $extension 'spi' or 'spc'.
	 */
	public function __construct($location, $filename, $extension) {

		$this->name = 'feed_' . $filename;
		$this->mod_name = 'feed_mod_' . $filename;

		$lifetime = $this->lifetime;
		/**
		 * Filters the transient lifetime of the feed cache.
		 *
		 * @since 2.8.0
		 *
		 * @param int    $lifetime Cache duration in seconds. Default is 43200 seconds (12 hours).
		 * @param string $filename Unique identifier for the cache object.
		 */
		$this->lifetime = apply_filters( 'wp_feed_cache_transient_lifetime', $lifetime, $filename);
	}

	/**
	 * Sets the transient.
	 *
	 * @since 2.8.0
	 * @access public
	 *
	 * @param SimplePie $data Data to save.
	 * @return true Always true.

	 */
	public function save($data) {
		if ( $data instanceof SimplePie ) {
			$data = $data->data;
		}

		set_transient($this->name, $data, $this->lifetime);
		set_transient($this->mod_name, time(), $this->lifetime);
		return true;
	}

	/**
	 * Gets the transient.
	 *
	 * @since 2.8.0
	 * @access public
	 *
	 * @return mixed Transient value.
	 */
	public function load() {
		return get_transient($this->name);
	}

	/**
	 * Gets mod transient.
	 *
	 * @since 2.8.0
	 * @access public
	 *
	 * @return mixed Transient value.
	 */
	public function mtime() {
		return get_transient($this->mod_name);
	}

	/**
	 * Sets mod transient.
	 *
	 * @since 2.8.0
	 * @access public
	 *
	 * @return bool False if value was not set and true if value was set.
	 */
	public function touch() {
		return set_transient($this->mod_name, time(), $this->lifetime);
	}

	/**
	 * Deletes transients.
	 *
	 * @since 2.8.0
	 * @access public
	 *
	 * @return true Always true.

	 */
	public function unlink() {
		delete_transient($this->name);
		delete_transient($this->mod_name);
		return true;
	}
}


1			<?php
2			/**
3			* Feed API: WP_Feed_Cache_Transient class
4			*
5			* @package WordPress
6			* @subpackage Feed
7			* @since 4.7.0
8			*/
9
10			/**
11			* Core class used to implement feed cache transients.
12			*
13			* @since 2.8.0
14			*/
15			class WP_Feed_Cache_Transient {
16
17			/**
18			* Holds the transient name.
19			*
20			* @since 2.8.0
21			* @access public
22			* @var string
23			*/
24			public $name;
25
26			/**
27			* Holds the transient mod name.
28			*
29			* @since 2.8.0
30			* @access public
31			* @var string
32			*/
33			public $mod_name;
34
35			/**
36			* Holds the cache duration in seconds.
37			*
38			* Defaults to 43200 seconds (12 hours).
39			*
40			* @since 2.8.0
41			* @access public
42			* @var int
43			*/
44			public $lifetime = 43200;
45
46			/**
47			* Constructor.
48			*
49			* @since 2.8.0
50			* @since 3.2.0 Updated to use a PHP5 constructor.
51			* @access public
52			*
53			* @param string $location URL location (scheme is used to determine handler).
54			* @param string $filename Unique identifier for cache object.
55			* @param string $extension 'spi' or 'spc'.
56			*/
57			public function __construct($location, $filename, $extension) {
			0 ignored issues – show Unused Code introduced 2015-12-17 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$location` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2015-12-17 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$extension` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
58			$this->name = 'feed_' . $filename;
59			$this->mod_name = 'feed_mod_' . $filename;
60
61			$lifetime = $this->lifetime;
62			/**
63			* Filters the transient lifetime of the feed cache.
64			*
65			* @since 2.8.0
66			*
67			* @param int $lifetime Cache duration in seconds. Default is 43200 seconds (12 hours).
68			* @param string $filename Unique identifier for the cache object.
69			*/
70			$this->lifetime = apply_filters( 'wp_feed_cache_transient_lifetime', $lifetime, $filename);
71			}
72
73			/**
74			* Sets the transient.
75			*
76			* @since 2.8.0
77			* @access public
78			*
79			* @param SimplePie $data Data to save.
80			* @return true Always true.
			0 ignored issues – show Documentation introduced 2017-06-24 04:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `boolean`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
81			*/
82			public function save($data) {
83			if ( $data instanceof SimplePie ) {
84			$data = $data->data;
85			}
86
87			set_transient($this->name, $data, $this->lifetime);
88			set_transient($this->mod_name, time(), $this->lifetime);
89			return true;
90			}
91
92			/**
93			* Gets the transient.
94			*
95			* @since 2.8.0
96			* @access public
97			*
98			* @return mixed Transient value.
99			*/
100			public function load() {
101			return get_transient($this->name);
102			}
103
104			/**
105			* Gets mod transient.
106			*
107			* @since 2.8.0
108			* @access public
109			*
110			* @return mixed Transient value.
111			*/
112			public function mtime() {
113			return get_transient($this->mod_name);
114			}
115
116			/**
117			* Sets mod transient.
118			*
119			* @since 2.8.0
120			* @access public
121			*
122			* @return bool False if value was not set and true if value was set.
123			*/
124			public function touch() {
125			return set_transient($this->mod_name, time(), $this->lifetime);
126			}
127
128			/**
129			* Deletes transients.
130			*
131			* @since 2.8.0
132			* @access public
133			*
134			* @return true Always true.
			0 ignored issues – show Documentation introduced 2017-06-24 04:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `boolean`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
135			*/
136			public function unlink() {
137			delete_transient($this->name);
138			delete_transient($this->mod_name);
139			return true;
140			}
141			}
142

ntwb / wordpress

Issues (4967)

Security Analysis not enabled

src/wp-includes/class-wp-feed-cache-transient.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like