Issues in link-parse-opml.php (ticket-41057) - Issues in ticket-41057 - ntwb/wordpress - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4967)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/wp-admin/link-parse-opml.php (3 issues)

Labels

Unused Code 3

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Parse OPML XML files and store in globals.
 *
 * @package WordPress
 * @subpackage Administration
 */

if ( ! defined('ABSPATH') )
	die();

/**
 * @global string $opml
 */
global $opml;

/**
 * XML callback function for the start of a new XML tag.
 *
 * @since 0.71
 * @access private
 *
 * @global array $names
 * @global array $urls
 * @global array $targets
 * @global array $descriptions
 * @global array $feeds
 *
 * @param mixed $parser XML Parser resource.
 * @param string $tagName XML element name.
 * @param array $attrs XML element attributes.
 */
function startElement($parser, $tagName, $attrs) {

	global $names, $urls, $targets, $descriptions, $feeds;

	if ( 'OUTLINE' === $tagName ) {
		$name = '';
		if ( isset( $attrs['TEXT'] ) ) {
			$name = $attrs['TEXT'];
		}
		if ( isset( $attrs['TITLE'] ) ) {
			$name = $attrs['TITLE'];
		}
		$url = '';
		if ( isset( $attrs['URL'] ) ) {
			$url = $attrs['URL'];
		}
		if ( isset( $attrs['HTMLURL'] ) ) {
			$url = $attrs['HTMLURL'];
		}

		// Save the data away.
		$names[] = $name;
		$urls[] = $url;
		$targets[] = isset( $attrs['TARGET'] ) ? $attrs['TARGET'] :  '';
		$feeds[] = isset( $attrs['XMLURL'] ) ? $attrs['XMLURL'] :  '';
		$descriptions[] = isset( $attrs['DESCRIPTION'] ) ? $attrs['DESCRIPTION'] :  '';
	} // End if outline.
}

/**
 * XML callback function that is called at the end of a XML tag.
 *
 * @since 0.71
 * @access private
 *
 * @param mixed $parser XML Parser resource.
 * @param string $tagName XML tag name.
 */
function endElement($parser, $tagName) {

	// Nothing to do.
}

// Create an XML parser
if ( ! function_exists( 'xml_parser_create' ) ) {
	trigger_error( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." ) );
	wp_die( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." ) );
}

$xml_parser = xml_parser_create();

// Set the functions to handle opening and closing tags
xml_set_element_handler($xml_parser, "startElement", "endElement");

if ( ! xml_parse( $xml_parser, $opml, true ) ) {
	printf(
		/* translators: 1: error message, 2: line number */
		__( 'XML Error: %1$s at line %2$s' ),
		xml_error_string( xml_get_error_code( $xml_parser ) ),
		xml_get_current_line_number( $xml_parser )
	);
}

// Free up memory used by the XML parser
xml_parser_free($xml_parser);


1			<?php
2			/**
3			* Parse OPML XML files and store in globals.
4			*
5			* @package WordPress
6			* @subpackage Administration
7			*/
8
9			if ( ! defined('ABSPATH') )
10			die();
11
12			/**
13			* @global string $opml
14			*/
15			global $opml;
16
17			/**
18			* XML callback function for the start of a new XML tag.
19			*
20			* @since 0.71
21			* @access private
22			*
23			* @global array $names
24			* @global array $urls
25			* @global array $targets
26			* @global array $descriptions
27			* @global array $feeds
28			*
29			* @param mixed $parser XML Parser resource.
30			* @param string $tagName XML element name.
31			* @param array $attrs XML element attributes.
32			*/
33			function startElement($parser, $tagName, $attrs) {
			0 ignored issues – show Unused Code introduced 2015-12-17 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$parser` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
34			global $names, $urls, $targets, $descriptions, $feeds;
35
36			if ( 'OUTLINE' === $tagName ) {
37			$name = '';
38			if ( isset( $attrs['TEXT'] ) ) {
39			$name = $attrs['TEXT'];
40			}
41			if ( isset( $attrs['TITLE'] ) ) {
42			$name = $attrs['TITLE'];
43			}
44			$url = '';
45			if ( isset( $attrs['URL'] ) ) {
46			$url = $attrs['URL'];
47			}
48			if ( isset( $attrs['HTMLURL'] ) ) {
49			$url = $attrs['HTMLURL'];
50			}
51
52			// Save the data away.
53			$names[] = $name;
54			$urls[] = $url;
55			$targets[] = isset( $attrs['TARGET'] ) ? $attrs['TARGET'] : '';
56			$feeds[] = isset( $attrs['XMLURL'] ) ? $attrs['XMLURL'] : '';
57			$descriptions[] = isset( $attrs['DESCRIPTION'] ) ? $attrs['DESCRIPTION'] : '';
58			} // End if outline.
59			}
60
61			/**
62			* XML callback function that is called at the end of a XML tag.
63			*
64			* @since 0.71
65			* @access private
66			*
67			* @param mixed $parser XML Parser resource.
68			* @param string $tagName XML tag name.
69			*/
70			function endElement($parser, $tagName) {
			0 ignored issues – show Unused Code introduced 2015-12-17 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$parser` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2015-12-17 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$tagName` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
71			// Nothing to do.
72			}
73
74			// Create an XML parser
75			if ( ! function_exists( 'xml_parser_create' ) ) {
76			trigger_error( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." ) );
77			wp_die( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." ) );
78			}
79
80			$xml_parser = xml_parser_create();
81
82			// Set the functions to handle opening and closing tags
83			xml_set_element_handler($xml_parser, "startElement", "endElement");
84
85			if ( ! xml_parse( $xml_parser, $opml, true ) ) {
86			printf(
87			/* translators: 1: error message, 2: line number */
88			__( 'XML Error: %1$s at line %2$s' ),
89			xml_error_string( xml_get_error_code( $xml_parser ) ),
90			xml_get_current_line_number( $xml_parser )
91			);
92			}
93
94			// Free up memory used by the XML parser
95			xml_parser_free($xml_parser);
96

ntwb / wordpress

Issues (4967)

Security Analysis not enabled

src/wp-admin/link-parse-opml.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like