ntwb /
wordpress
| Conditions | 88 |
| Paths | 0 |
| Total Lines | 420 |
| Code Lines | 229 |
| Lines | 41 |
| Ratio | 9.76 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 476 | protected function get_comment_ids() { |
||
| 477 | global $wpdb; |
||
| 478 | |||
| 479 | // Assemble clauses related to 'comment_approved'. |
||
| 480 | $approved_clauses = array(); |
||
| 481 | |||
| 482 | // 'status' accepts an array or a comma-separated string. |
||
| 483 | $status_clauses = array(); |
||
| 484 | $statuses = $this->query_vars['status']; |
||
| 485 | if ( ! is_array( $statuses ) ) { |
||
| 486 | $statuses = preg_split( '/[\s,]+/', $statuses ); |
||
| 487 | } |
||
| 488 | |||
| 489 | // 'any' overrides other statuses. |
||
| 490 | if ( ! in_array( 'any', $statuses ) ) { |
||
| 491 | foreach ( $statuses as $status ) { |
||
| 492 | switch ( $status ) { |
||
| 493 | case 'hold' : |
||
| 494 | $status_clauses[] = "comment_approved = '0'"; |
||
| 495 | break; |
||
| 496 | |||
| 497 | case 'approve' : |
||
| 498 | $status_clauses[] = "comment_approved = '1'"; |
||
| 499 | break; |
||
| 500 | |||
| 501 | case 'all' : |
||
| 502 | case '' : |
||
| 503 | $status_clauses[] = "( comment_approved = '0' OR comment_approved = '1' )"; |
||
| 504 | break; |
||
| 505 | |||
| 506 | default : |
||
| 507 | $status_clauses[] = $wpdb->prepare( "comment_approved = %s", $status ); |
||
| 508 | break; |
||
| 509 | } |
||
| 510 | } |
||
| 511 | |||
| 512 | if ( ! empty( $status_clauses ) ) { |
||
| 513 | $approved_clauses[] = '( ' . implode( ' OR ', $status_clauses ) . ' )'; |
||
| 514 | } |
||
| 515 | } |
||
| 516 | |||
| 517 | // User IDs or emails whose unapproved comments are included, regardless of $status. |
||
| 518 | if ( ! empty( $this->query_vars['include_unapproved'] ) ) { |
||
| 519 | $include_unapproved = $this->query_vars['include_unapproved']; |
||
| 520 | |||
| 521 | // Accepts arrays or comma-separated strings. |
||
| 522 | if ( ! is_array( $include_unapproved ) ) { |
||
| 523 | $include_unapproved = preg_split( '/[\s,]+/', $include_unapproved ); |
||
| 524 | } |
||
| 525 | |||
| 526 | $unapproved_ids = $unapproved_emails = array(); |
||
| 527 | foreach ( $include_unapproved as $unapproved_identifier ) { |
||
| 528 | // Numeric values are assumed to be user ids. |
||
| 529 | if ( is_numeric( $unapproved_identifier ) ) { |
||
| 530 | $approved_clauses[] = $wpdb->prepare( "( user_id = %d AND comment_approved = '0' )", $unapproved_identifier ); |
||
| 531 | |||
| 532 | // Otherwise we match against email addresses. |
||
| 533 | } else { |
||
| 534 | $approved_clauses[] = $wpdb->prepare( "( comment_author_email = %s AND comment_approved = '0' )", $unapproved_identifier ); |
||
| 535 | } |
||
| 536 | } |
||
| 537 | } |
||
| 538 | |||
| 539 | // Collapse comment_approved clauses into a single OR-separated clause. |
||
| 540 | if ( ! empty( $approved_clauses ) ) { |
||
| 541 | if ( 1 === count( $approved_clauses ) ) { |
||
| 542 | $this->sql_clauses['where']['approved'] = $approved_clauses[0]; |
||
| 543 | } else { |
||
| 544 | $this->sql_clauses['where']['approved'] = '( ' . implode( ' OR ', $approved_clauses ) . ' )'; |
||
| 545 | } |
||
| 546 | } |
||
| 547 | |||
| 548 | $order = ( 'ASC' == strtoupper( $this->query_vars['order'] ) ) ? 'ASC' : 'DESC'; |
||
| 549 | |||
| 550 | // Disable ORDER BY with 'none', an empty array, or boolean false. |
||
| 551 | if ( in_array( $this->query_vars['orderby'], array( 'none', array(), false ), true ) ) { |
||
| 552 | $orderby = ''; |
||
| 553 | } elseif ( ! empty( $this->query_vars['orderby'] ) ) { |
||
| 554 | $ordersby = is_array( $this->query_vars['orderby'] ) ? |
||
| 555 | $this->query_vars['orderby'] : |
||
| 556 | preg_split( '/[,\s]/', $this->query_vars['orderby'] ); |
||
| 557 | |||
| 558 | $orderby_array = array(); |
||
| 559 | $found_orderby_comment_ID = false; |
||
| 560 | foreach ( $ordersby as $_key => $_value ) { |
||
| 561 | if ( ! $_value ) { |
||
| 562 | continue; |
||
| 563 | } |
||
| 564 | |||
| 565 | View Code Duplication | if ( is_int( $_key ) ) { |
|
| 566 | $_orderby = $_value; |
||
| 567 | $_order = $order; |
||
| 568 | } else { |
||
| 569 | $_orderby = $_key; |
||
| 570 | $_order = $_value; |
||
| 571 | } |
||
| 572 | |||
| 573 | if ( ! $found_orderby_comment_ID && in_array( $_orderby, array( 'comment_ID', 'comment__in' ) ) ) { |
||
| 574 | $found_orderby_comment_ID = true; |
||
| 575 | } |
||
| 576 | |||
| 577 | $parsed = $this->parse_orderby( $_orderby ); |
||
| 578 | |||
| 579 | if ( ! $parsed ) { |
||
| 580 | continue; |
||
| 581 | } |
||
| 582 | |||
| 583 | if ( 'comment__in' === $_orderby ) { |
||
| 584 | $orderby_array[] = $parsed; |
||
| 585 | continue; |
||
| 586 | } |
||
| 587 | |||
| 588 | $orderby_array[] = $parsed . ' ' . $this->parse_order( $_order ); |
||
| 589 | } |
||
| 590 | |||
| 591 | // If no valid clauses were found, order by comment_date_gmt. |
||
| 592 | if ( empty( $orderby_array ) ) { |
||
| 593 | $orderby_array[] = "$wpdb->comments.comment_date_gmt $order"; |
||
| 594 | } |
||
| 595 | |||
| 596 | // To ensure determinate sorting, always include a comment_ID clause. |
||
| 597 | if ( ! $found_orderby_comment_ID ) { |
||
| 598 | $comment_ID_order = ''; |
||
| 599 | |||
| 600 | // Inherit order from comment_date or comment_date_gmt, if available. |
||
| 601 | foreach ( $orderby_array as $orderby_clause ) { |
||
| 602 | if ( preg_match( '/comment_date(?:_gmt)*\ (ASC|DESC)/', $orderby_clause, $match ) ) { |
||
| 603 | $comment_ID_order = $match[1]; |
||
| 604 | break; |
||
| 605 | } |
||
| 606 | } |
||
| 607 | |||
| 608 | // If no date-related order is available, use the date from the first available clause. |
||
| 609 | if ( ! $comment_ID_order ) { |
||
| 610 | foreach ( $orderby_array as $orderby_clause ) { |
||
| 611 | if ( false !== strpos( 'ASC', $orderby_clause ) ) { |
||
| 612 | $comment_ID_order = 'ASC'; |
||
| 613 | } else { |
||
| 614 | $comment_ID_order = 'DESC'; |
||
| 615 | } |
||
| 616 | |||
| 617 | break; |
||
| 618 | } |
||
| 619 | } |
||
| 620 | |||
| 621 | // Default to DESC. |
||
| 622 | if ( ! $comment_ID_order ) { |
||
| 623 | $comment_ID_order = 'DESC'; |
||
| 624 | } |
||
| 625 | |||
| 626 | $orderby_array[] = "$wpdb->comments.comment_ID $comment_ID_order"; |
||
| 627 | } |
||
| 628 | |||
| 629 | $orderby = implode( ', ', $orderby_array ); |
||
| 630 | } else { |
||
| 631 | $orderby = "$wpdb->comments.comment_date_gmt $order"; |
||
| 632 | } |
||
| 633 | |||
| 634 | $number = absint( $this->query_vars['number'] ); |
||
| 635 | $offset = absint( $this->query_vars['offset'] ); |
||
| 636 | |||
| 637 | View Code Duplication | if ( ! empty( $number ) ) { |
|
| 638 | if ( $offset ) { |
||
| 639 | $limits = 'LIMIT ' . $offset . ',' . $number; |
||
| 640 | } else { |
||
| 641 | $limits = 'LIMIT ' . $number; |
||
| 642 | } |
||
| 643 | } |
||
| 644 | |||
| 645 | if ( $this->query_vars['count'] ) { |
||
| 646 | $fields = 'COUNT(*)'; |
||
| 647 | } else { |
||
| 648 | $fields = "$wpdb->comments.comment_ID"; |
||
| 649 | } |
||
| 650 | |||
| 651 | $post_id = absint( $this->query_vars['post_id'] ); |
||
| 652 | if ( ! empty( $post_id ) ) { |
||
| 653 | $this->sql_clauses['where']['post_id'] = $wpdb->prepare( 'comment_post_ID = %d', $post_id ); |
||
| 654 | } |
||
| 655 | |||
| 656 | // Parse comment IDs for an IN clause. |
||
| 657 | if ( ! empty( $this->query_vars['comment__in'] ) ) { |
||
| 658 | $this->sql_clauses['where']['comment__in'] = "$wpdb->comments.comment_ID IN ( " . implode( ',', wp_parse_id_list( $this->query_vars['comment__in'] ) ) . ' )'; |
||
| 659 | } |
||
| 660 | |||
| 661 | // Parse comment IDs for a NOT IN clause. |
||
| 662 | if ( ! empty( $this->query_vars['comment__not_in'] ) ) { |
||
| 663 | $this->sql_clauses['where']['comment__not_in'] = "$wpdb->comments.comment_ID NOT IN ( " . implode( ',', wp_parse_id_list( $this->query_vars['comment__not_in'] ) ) . ' )'; |
||
| 664 | } |
||
| 665 | |||
| 666 | // Parse comment parent IDs for an IN clause. |
||
| 667 | if ( ! empty( $this->query_vars['parent__in'] ) ) { |
||
| 668 | $this->sql_clauses['where']['parent__in'] = 'comment_parent IN ( ' . implode( ',', wp_parse_id_list( $this->query_vars['parent__in'] ) ) . ' )'; |
||
| 669 | } |
||
| 670 | |||
| 671 | // Parse comment parent IDs for a NOT IN clause. |
||
| 672 | if ( ! empty( $this->query_vars['parent__not_in'] ) ) { |
||
| 673 | $this->sql_clauses['where']['parent__not_in'] = 'comment_parent NOT IN ( ' . implode( ',', wp_parse_id_list( $this->query_vars['parent__not_in'] ) ) . ' )'; |
||
| 674 | } |
||
| 675 | |||
| 676 | // Parse comment post IDs for an IN clause. |
||
| 677 | if ( ! empty( $this->query_vars['post__in'] ) ) { |
||
| 678 | $this->sql_clauses['where']['post__in'] = 'comment_post_ID IN ( ' . implode( ',', wp_parse_id_list( $this->query_vars['post__in'] ) ) . ' )'; |
||
| 679 | } |
||
| 680 | |||
| 681 | // Parse comment post IDs for a NOT IN clause. |
||
| 682 | if ( ! empty( $this->query_vars['post__not_in'] ) ) { |
||
| 683 | $this->sql_clauses['where']['post__not_in'] = 'comment_post_ID NOT IN ( ' . implode( ',', wp_parse_id_list( $this->query_vars['post__not_in'] ) ) . ' )'; |
||
| 684 | } |
||
| 685 | |||
| 686 | View Code Duplication | if ( '' !== $this->query_vars['author_email'] ) { |
|
| 687 | $this->sql_clauses['where']['author_email'] = $wpdb->prepare( 'comment_author_email = %s', $this->query_vars['author_email'] ); |
||
| 688 | } |
||
| 689 | |||
| 690 | View Code Duplication | if ( '' !== $this->query_vars['author_url'] ) { |
|
| 691 | $this->sql_clauses['where']['author_url'] = $wpdb->prepare( 'comment_author_url = %s', $this->query_vars['author_url'] ); |
||
| 692 | } |
||
| 693 | |||
| 694 | View Code Duplication | if ( '' !== $this->query_vars['karma'] ) { |
|
| 695 | $this->sql_clauses['where']['karma'] = $wpdb->prepare( 'comment_karma = %d', $this->query_vars['karma'] ); |
||
| 696 | } |
||
| 697 | |||
| 698 | // Filtering by comment_type: 'type', 'type__in', 'type__not_in'. |
||
| 699 | $raw_types = array( |
||
| 700 | 'IN' => array_merge( (array) $this->query_vars['type'], (array) $this->query_vars['type__in'] ), |
||
| 701 | 'NOT IN' => (array) $this->query_vars['type__not_in'], |
||
| 702 | ); |
||
| 703 | |||
| 704 | $comment_types = array(); |
||
| 705 | foreach ( $raw_types as $operator => $_raw_types ) { |
||
| 706 | $_raw_types = array_unique( $_raw_types ); |
||
| 707 | |||
| 708 | foreach ( $_raw_types as $type ) { |
||
| 709 | switch ( $type ) { |
||
| 710 | // An empty translates to 'all', for backward compatibility |
||
| 711 | case '': |
||
| 712 | case 'all' : |
||
| 713 | break; |
||
| 714 | |||
| 715 | case 'comment': |
||
| 716 | case 'comments': |
||
| 717 | $comment_types[ $operator ][] = "''"; |
||
| 718 | break; |
||
| 719 | |||
| 720 | case 'pings': |
||
| 721 | $comment_types[ $operator ][] = "'pingback'"; |
||
| 722 | $comment_types[ $operator ][] = "'trackback'"; |
||
| 723 | break; |
||
| 724 | |||
| 725 | default: |
||
| 726 | $comment_types[ $operator ][] = $wpdb->prepare( '%s', $type ); |
||
| 727 | break; |
||
| 728 | } |
||
| 729 | } |
||
| 730 | |||
| 731 | if ( ! empty( $comment_types[ $operator ] ) ) { |
||
| 732 | $types_sql = implode( ', ', $comment_types[ $operator ] ); |
||
| 733 | $this->sql_clauses['where']['comment_type__' . strtolower( str_replace( ' ', '_', $operator ) ) ] = "comment_type $operator ($types_sql)"; |
||
| 734 | } |
||
| 735 | } |
||
| 736 | |||
| 737 | if ( $this->query_vars['hierarchical'] && ! $this->query_vars['parent'] ) { |
||
| 738 | $this->query_vars['parent'] = 0; |
||
| 739 | } |
||
| 740 | |||
| 741 | View Code Duplication | if ( '' !== $this->query_vars['parent'] ) { |
|
| 742 | $this->sql_clauses['where']['parent'] = $wpdb->prepare( 'comment_parent = %d', $this->query_vars['parent'] ); |
||
| 743 | } |
||
| 744 | |||
| 745 | if ( is_array( $this->query_vars['user_id'] ) ) { |
||
| 746 | $this->sql_clauses['where']['user_id'] = 'user_id IN (' . implode( ',', array_map( 'absint', $this->query_vars['user_id'] ) ) . ')'; |
||
| 747 | View Code Duplication | } elseif ( '' !== $this->query_vars['user_id'] ) { |
|
| 748 | $this->sql_clauses['where']['user_id'] = $wpdb->prepare( 'user_id = %d', $this->query_vars['user_id'] ); |
||
| 749 | } |
||
| 750 | |||
| 751 | // Falsy search strings are ignored. |
||
| 752 | if ( strlen( $this->query_vars['search'] ) ) { |
||
| 753 | $search_sql = $this->get_search_sql( |
||
| 754 | $this->query_vars['search'], |
||
| 755 | array( 'comment_author', 'comment_author_email', 'comment_author_url', 'comment_author_IP', 'comment_content' ) |
||
| 756 | ); |
||
| 757 | |||
| 758 | // Strip leading 'AND'. |
||
| 759 | $this->sql_clauses['where']['search'] = preg_replace( '/^\s*AND\s*/', '', $search_sql ); |
||
| 760 | } |
||
| 761 | |||
| 762 | // If any post-related query vars are passed, join the posts table. |
||
| 763 | $join_posts_table = false; |
||
| 764 | $plucked = wp_array_slice_assoc( $this->query_vars, array( 'post_author', 'post_name', 'post_parent' ) ); |
||
| 765 | $post_fields = array_filter( $plucked ); |
||
| 766 | |||
| 767 | if ( ! empty( $post_fields ) ) { |
||
| 768 | $join_posts_table = true; |
||
| 769 | foreach ( $post_fields as $field_name => $field_value ) { |
||
| 770 | // $field_value may be an array. |
||
| 771 | $esses = array_fill( 0, count( (array) $field_value ), '%s' ); |
||
| 772 | $this->sql_clauses['where'][ $field_name ] = $wpdb->prepare( " {$wpdb->posts}.{$field_name} IN (" . implode( ',', $esses ) . ')', $field_value ); |
||
| 773 | } |
||
| 774 | } |
||
| 775 | |||
| 776 | // 'post_status' and 'post_type' are handled separately, due to the specialized behavior of 'any'. |
||
| 777 | foreach ( array( 'post_status', 'post_type' ) as $field_name ) { |
||
| 778 | $q_values = array(); |
||
| 779 | if ( ! empty( $this->query_vars[ $field_name ] ) ) { |
||
| 780 | $q_values = $this->query_vars[ $field_name ]; |
||
| 781 | if ( ! is_array( $q_values ) ) { |
||
| 782 | $q_values = explode( ',', $q_values ); |
||
| 783 | } |
||
| 784 | |||
| 785 | // 'any' will cause the query var to be ignored. |
||
| 786 | if ( in_array( 'any', $q_values, true ) || empty( $q_values ) ) { |
||
| 787 | continue; |
||
| 788 | } |
||
| 789 | |||
| 790 | $join_posts_table = true; |
||
| 791 | |||
| 792 | $esses = array_fill( 0, count( $q_values ), '%s' ); |
||
| 793 | $this->sql_clauses['where'][ $field_name ] = $wpdb->prepare( " {$wpdb->posts}.{$field_name} IN (" . implode( ',', $esses ) . ")", $q_values ); |
||
| 794 | } |
||
| 795 | } |
||
| 796 | |||
| 797 | // Comment author IDs for an IN clause. |
||
| 798 | if ( ! empty( $this->query_vars['author__in'] ) ) { |
||
| 799 | $this->sql_clauses['where']['author__in'] = 'user_id IN ( ' . implode( ',', wp_parse_id_list( $this->query_vars['author__in'] ) ) . ' )'; |
||
| 800 | } |
||
| 801 | |||
| 802 | // Comment author IDs for a NOT IN clause. |
||
| 803 | if ( ! empty( $this->query_vars['author__not_in'] ) ) { |
||
| 804 | $this->sql_clauses['where']['author__not_in'] = 'user_id NOT IN ( ' . implode( ',', wp_parse_id_list( $this->query_vars['author__not_in'] ) ) . ' )'; |
||
| 805 | } |
||
| 806 | |||
| 807 | // Post author IDs for an IN clause. |
||
| 808 | View Code Duplication | if ( ! empty( $this->query_vars['post_author__in'] ) ) { |
|
| 809 | $join_posts_table = true; |
||
| 810 | $this->sql_clauses['where']['post_author__in'] = 'post_author IN ( ' . implode( ',', wp_parse_id_list( $this->query_vars['post_author__in'] ) ) . ' )'; |
||
| 811 | } |
||
| 812 | |||
| 813 | // Post author IDs for a NOT IN clause. |
||
| 814 | View Code Duplication | if ( ! empty( $this->query_vars['post_author__not_in'] ) ) { |
|
| 815 | $join_posts_table = true; |
||
| 816 | $this->sql_clauses['where']['post_author__not_in'] = 'post_author NOT IN ( ' . implode( ',', wp_parse_id_list( $this->query_vars['post_author__not_in'] ) ) . ' )'; |
||
| 817 | } |
||
| 818 | |||
| 819 | $join = ''; |
||
| 820 | |||
| 821 | if ( $join_posts_table ) { |
||
| 822 | $join .= "JOIN $wpdb->posts ON $wpdb->posts.ID = $wpdb->comments.comment_post_ID"; |
||
| 823 | } |
||
| 824 | |||
| 825 | if ( ! empty( $this->meta_query_clauses ) ) { |
||
| 826 | $join .= $this->meta_query_clauses['join']; |
||
| 827 | |||
| 828 | // Strip leading 'AND'. |
||
| 829 | $this->sql_clauses['where']['meta_query'] = preg_replace( '/^\s*AND\s*/', '', $this->meta_query_clauses['where'] ); |
||
| 830 | |||
| 831 | if ( ! $this->query_vars['count'] ) { |
||
| 832 | $groupby = "{$wpdb->comments}.comment_ID"; |
||
| 833 | } |
||
| 834 | } |
||
| 835 | |||
| 836 | $date_query = $this->query_vars['date_query']; |
||
| 837 | View Code Duplication | if ( ! empty( $date_query ) && is_array( $date_query ) ) { |
|
| 838 | $date_query_object = new WP_Date_Query( $date_query, 'comment_date' ); |
||
| 839 | $this->sql_clauses['where']['date_query'] = preg_replace( '/^\s*AND\s*/', '', $date_query_object->get_sql() ); |
||
| 840 | } |
||
| 841 | |||
| 842 | $where = implode( ' AND ', $this->sql_clauses['where'] ); |
||
| 843 | |||
| 844 | $pieces = array( 'fields', 'join', 'where', 'orderby', 'limits', 'groupby' ); |
||
| 845 | /** |
||
| 846 | * Filter the comment query clauses. |
||
| 847 | * |
||
| 848 | * @since 3.1.0 |
||
| 849 | * |
||
| 850 | * @param array $pieces A compacted array of comment query clauses. |
||
| 851 | * @param WP_Comment_Query &$this Current instance of WP_Comment_Query, passed by reference. |
||
| 852 | */ |
||
| 853 | $clauses = apply_filters_ref_array( 'comments_clauses', array( compact( $pieces ), &$this ) ); |
||
| 854 | |||
| 855 | $fields = isset( $clauses[ 'fields' ] ) ? $clauses[ 'fields' ] : ''; |
||
| 856 | $join = isset( $clauses[ 'join' ] ) ? $clauses[ 'join' ] : ''; |
||
| 857 | $where = isset( $clauses[ 'where' ] ) ? $clauses[ 'where' ] : ''; |
||
| 858 | $orderby = isset( $clauses[ 'orderby' ] ) ? $clauses[ 'orderby' ] : ''; |
||
| 859 | $limits = isset( $clauses[ 'limits' ] ) ? $clauses[ 'limits' ] : ''; |
||
| 860 | $groupby = isset( $clauses[ 'groupby' ] ) ? $clauses[ 'groupby' ] : ''; |
||
| 861 | |||
| 862 | $this->filtered_where_clause = $where; |
||
| 863 | |||
| 864 | if ( $where ) { |
||
| 865 | $where = 'WHERE ' . $where; |
||
| 866 | } |
||
| 867 | |||
| 868 | if ( $groupby ) { |
||
| 869 | $groupby = 'GROUP BY ' . $groupby; |
||
| 870 | } |
||
| 871 | |||
| 872 | if ( $orderby ) { |
||
| 873 | $orderby = "ORDER BY $orderby"; |
||
| 874 | } |
||
| 875 | |||
| 876 | $found_rows = ''; |
||
| 877 | if ( ! $this->query_vars['no_found_rows'] ) { |
||
| 878 | $found_rows = 'SQL_CALC_FOUND_ROWS'; |
||
| 879 | } |
||
| 880 | |||
| 881 | $this->sql_clauses['select'] = "SELECT $found_rows $fields"; |
||
| 882 | $this->sql_clauses['from'] = "FROM $wpdb->comments $join"; |
||
| 883 | $this->sql_clauses['groupby'] = $groupby; |
||
| 884 | $this->sql_clauses['orderby'] = $orderby; |
||
| 885 | $this->sql_clauses['limits'] = $limits; |
||
| 886 | |||
| 887 | $this->request = "{$this->sql_clauses['select']} {$this->sql_clauses['from']} {$where} {$this->sql_clauses['groupby']} {$this->sql_clauses['orderby']} {$this->sql_clauses['limits']}"; |
||
| 888 | |||
| 889 | if ( $this->query_vars['count'] ) { |
||
| 890 | return intval( $wpdb->get_var( $this->request ) ); |
||
| 891 | } else { |
||
| 892 | $comment_ids = $wpdb->get_col( $this->request ); |
||
| 893 | return array_map( 'intval', $comment_ids ); |
||
| 894 | } |
||
| 895 | } |
||
| 896 | |||
| 1108 |
Loading history...
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.