yentu\factories\CommandFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createCommand()	0	4	1
A	__construct()	0	5	1

<?php

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

Filename "CommandFactory.php" doesn't match the expected filename "commandfactory.php"

Missing file doc comment

namespace yentu\factories;


use clearice\io\Io;
use yentu\Yentu;

class CommandFactory

Missing class doc comment

{

Opening brace should be on the same line as the declaration for class CommandFactory

    private $io;

Private member variable "io" must contain a leading underscore

Expected 1 blank line before member var; 0 found

Missing member variable doc comment

Private member variable "io" must be prefixed with an underscore

    private $yentu;

Private member variable "yentu" must contain a leading underscore

Expected 1 blank line before member var; 0 found

Missing member variable doc comment

Private member variable "yentu" must be prefixed with an underscore

    private $manipulatorFactory;

Private member variable "manipulatorFactory" must contain a leading underscore

Expected 1 blank line before member var; 0 found

Missing member variable doc comment

Private member variable "manipulatorFactory" must be prefixed with an underscore

    public function __construct(Io $io, DatabaseManipulatorFactory $manipulatorFactory, Yentu $yentu)

Expected 2 blank lines before function; 1 found

Missing function doc comment

This line exceeds maximum limit of 100 characters; contains 101 characters

    {

Opening brace should be on the same line as the declaration

        $this->io = $io;

Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space

        $this->manipulatorFactory = $manipulatorFactory;
        $this->yentu = $yentu;

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

    }

Expected 1 blank line before closing function brace; 0 found

    public function createCommand($command, $options = [])

Missing function doc comment

Incorrect spacing between argument "$options" and equals sign; expected 0 but found 1

Incorrect spacing between default value and equals sign for argument "$options"; expected 0 but found 1

Short array syntax is not allowed

    {

Opening brace should be on the same line as the declaration

        $class = "yentu\\commands\\" . ucfirst($command);

The string literal yentu\\commands\\ does not require double quotes, as per coding-style, please use single quotes.

Concat operator must not be surrounded by spaces

        return new $class($this->yentu, $this->manipulatorFactory, $this->io, $options);
    }

Expected 1 blank line before closing function brace; 0 found

}

As per coding style, files should not end with a newline character.