AbstractDatabaseManipulator::getDefaultSchema() - Code Metrics - Inspection of "Should fix postgresql tests" - ntentan/yentu - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 4b619a...66d037 )

by James Ekow Abaka

created 2018-11-18 08:15 UTC

AbstractDatabaseManipulator::getDefaultSchema() A

↳ Parent: AbstractDatabaseManipulator

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

Coding Style introduced 2018-10-19 22:43 UTC by

This file is missing a doc comment.

Coding Style introduced 2018-10-19 22:43 UTC by

The PHP open tag does not have a corresponding PHP close tag

Coding Style introduced 2018-10-19 22:43 UTC by

Filename "AbstractDatabaseManipulator.php" doesn't match the expected filename "abstractdatabasemanipulator.php"

Coding Style introduced 2018-10-19 22:43 UTC by

Missing file doc comment

namespace yentu\manipulators;

use clearice\io\Io;

use ntentan\atiaa\DriverFactory;

use yentu\Yentu;

use yentu\DatabaseAssertor;

use yentu\SchemaDescription;

use yentu\exceptions\DatabaseManipulatorException;

use yentu\Parameters;

abstract class AbstractDatabaseManipulator

Coding Style Documentation introduced 2018-10-19 22:43 UTC by

Missing class doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration for class AbstractDatabaseManipulator

    const CONVERT_TO_DRIVER = 'driver';

    const CONVERT_TO_YENTU = 'yentu';

Coding Style introduced 2018-10-19 22:43 UTC by

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

    private $schemaDescription;

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "schemaDescription" must contain a leading underscore

Coding Style Documentation introduced 2018-10-19 22:43 UTC by

Missing member variable doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "schemaDescription" must be prefixed with an underscore

    private $assertor;

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "assertor" must contain a leading underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before member var; 0 found

Coding Style Documentation introduced 2018-10-19 22:43 UTC by

Missing member variable doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "assertor" must be prefixed with an underscore

    private $connection;

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "connection" must contain a leading underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before member var; 0 found

Coding Style Documentation introduced 2018-10-19 22:43 UTC by

Missing member variable doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "connection" must be prefixed with an underscore

    private $dumpQuery;

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "dumpQuery" must contain a leading underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before member var; 0 found

Coding Style Documentation introduced 2018-10-19 22:43 UTC by

Missing member variable doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "dumpQuery" must be prefixed with an underscore

    private $disableQuery;

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "disableQuery" must contain a leading underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before member var; 0 found

Coding Style Documentation introduced 2018-10-19 22:43 UTC by

Missing member variable doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Private member variable "disableQuery" must be prefixed with an underscore

    protected $defaultSchema;

Coding Style introduced 2018-10-19 22:43 UTC by

Protected member variable "defaultSchema" must contain a leading underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before member var; 0 found

Coding Style Documentation introduced 2018-10-19 22:43 UTC by

Missing member variable doc comment

    private $io;

Coding Style introduced 2018-11-18 08:14 UTC by

Private member variable "io" must contain a leading underscore

Coding Style introduced 2018-11-18 08:14 UTC by

Expected 1 blank line before member var; 0 found

Coding Style Documentation introduced 2018-11-18 08:14 UTC by

Missing member variable doc comment

Coding Style introduced 2018-11-18 08:14 UTC by

Private member variable "io" must be prefixed with an underscore

/**

     * AbstractDatabaseManipulator constructor.

     * @param DriverFactory $driverFactory

Coding Style introduced 2018-11-18 08:14 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style introduced 2018-11-18 08:14 UTC by

Missing parameter comment

Coding Style introduced 2018-11-18 08:14 UTC by

Tag value indented incorrectly; expected 2 spaces but found 1

     * @param Io $io

Coding Style introduced 2018-11-18 08:14 UTC by

Missing parameter comment

Coding Style introduced 2018-11-18 08:14 UTC by

Expected 12 spaces after parameter type; 1 found

Coding Style introduced 2018-11-18 08:14 UTC by

Tag value indented incorrectly; expected 2 spaces but found 1

     * @throws \ntentan\atiaa\exceptions\ConnectionException

Coding Style introduced 2018-11-18 08:14 UTC by

Tag cannot be grouped with parameter tags in a doc comment

introduced 2018-11-18 08:14 UTC by

Comment missing for @throws tag in function comment

*/

    public function __construct(DriverFactory $driverFactory, Io $io)

Coding Style introduced 2018-11-18 08:14 UTC by

Expected 2 blank lines before function; 1 found

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        $this->connection = $driverFactory->createDriver();

        $this->connection->connect();

        $this->io = $io;

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

    public function __get($name)

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        if ($name === 'description') {

            return $this->getDescription();

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

    public function setDumpQuery($dumpQuery)

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        $this->dumpQuery = $dumpQuery;

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

    public function setDisableQuery($disableQuery)

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        $this->disableQuery = $disableQuery;

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

    public function __call($name, $arguments)

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        if (preg_match("/^(add|drop|change|executeQuery|reverseQuery)/", $name)) {

Coding Style Comprehensibility introduced 2018-10-19 22:43 UTC by

The string literal /^(add|drop|change|executeQuery|reverseQuery)/ does not require double quotes, as per coding-style, please use single quotes.

            $details = Parameters::wrap($arguments[0]);

            $this->description->$name($details);

Bug Best Practice introduced 2018-06-17 14:12 UTC by

The property description does not exist on yentu\manipulators\AbstractDatabaseManipulator. Since you implemented __get, consider adding a @property annotation.

            $name = "_$name";

Coding Style Best Practice introduced 2018-10-19 22:43 UTC by

As per coding-style, please use concatenation or sprintf for the variable $name instead of interpolation.

            new \ReflectionMethod($this, $name);

            return $this->$name($details);

        } else {

            throw new \Exception("Failed to execute method '$name'");

Coding Style Best Practice introduced 2018-10-19 22:43 UTC by

As per coding-style, please use concatenation or sprintf for the variable $name instead of interpolation.

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

    public function query($query, $bind = false)

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Incorrect spacing between argument "$bind" and equals sign; expected 0 but found 1

Coding Style introduced 2018-10-19 22:43 UTC by

Incorrect spacing between default value and equals sign for argument "$bind"; expected 0 but found 1

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        try {

            if ($this->dumpQuery) {

                echo "$query\n";

Coding Style Best Practice introduced 2018-10-19 22:43 UTC by

As per coding-style, please use concatenation or sprintf for the variable $query instead of interpolation.

            $this->io->output("\n    > Running Query [$query]", Io::OUTPUT_LEVEL_3);

Coding Style Best Practice introduced 2018-10-19 22:43 UTC by

As per coding-style, please use concatenation or sprintf for the variable $query instead of interpolation.

            if ($this->disableQuery !== true) {

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

                return $this->connection->query($query, $bind);

        } catch (\ntentan\atiaa\exceptions\DatabaseDriverException $e) {

            throw new DatabaseManipulatorException($e->getMessage());

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

    public function disconnect()

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        $this->connection->disconnect();

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

    public function getDefaultSchema()

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        return $this->connection->getDefaultSchema();

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

    public function getAssertor()

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

        if (!is_object($this->assertor)) {

Coding Style introduced 2018-10-19 22:43 UTC by

There must be a single space after a NOT operator; 0 found

100

            $this->assertor = new DatabaseAssertor($this->description);

Bug Best Practice introduced 2018-06-17 14:12 UTC by

The property description does not exist on yentu\manipulators\AbstractDatabaseManipulator. Since you implemented __get, consider adding a @property annotation.

101

Coding Style introduced 2018-10-19 22:43 UTC by

No blank line found after control structure

102

        return $this->assertor;

103

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

104

105

    abstract protected function _addSchema($name);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addSchema" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

106

107

    abstract protected function _dropSchema($name);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropSchema" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

108

109

    abstract protected function _addTable($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addTable" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

110

111

    abstract protected function _dropTable($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropTable" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

112

113

    abstract protected function _changeTableName($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_changeTableName" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

114

115

    abstract protected function _addColumn($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addColumn" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

116

117

    abstract protected function _changeColumnNulls($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_changeColumnNulls" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

118

119

    abstract protected function _changeColumnName($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_changeColumnName" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

120

121

    abstract protected function _changeColumnDefault($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_changeColumnDefault" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

122

123

    abstract protected function _dropColumn($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropColumn" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

124

125

    abstract protected function _addPrimaryKey($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addPrimaryKey" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

126

127

    abstract protected function _dropPrimaryKey($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropPrimaryKey" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

128

129

    abstract protected function _addUniqueKey($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addUniqueKey" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

130

131

    abstract protected function _dropUniqueKey($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropUniqueKey" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

132

133

    abstract protected function _addAutoPrimaryKey($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addAutoPrimaryKey" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

134

135

    abstract protected function _dropAutoPrimaryKey($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropAutoPrimaryKey" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

136

137

    abstract protected function _addForeignKey($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addForeignKey" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

138

139

    abstract protected function _dropForeignKey($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropForeignKey" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

140

141

    abstract protected function _addIndex($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addIndex" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

142

143

    abstract protected function _dropIndex($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropIndex" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

144

145

    abstract protected function _addView($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_addView" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

146

147

    abstract protected function _dropView($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_dropView" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

148

149

    abstract protected function _changeViewDefinition($details);

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_changeViewDefinition" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

150

151

    protected function _changeForeignKeyOnDelete($details)

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_changeForeignKeyOnDelete" must not be prefixed with an underscore

152

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

153

        $this->_dropForeignKey($details['from']);

154

        $this->_addForeignKey($details['to']);

155

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

156

157

    protected function _changeForeignKeyOnUpdate($details)

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_changeForeignKeyOnUpdate" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

158

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

159

        $this->_dropForeignKey($details['from']);

160

        $this->_addForeignKey($details['to']);

161

Coding Style introduced 2018-11-18 08:14 UTC by

Expected 1 blank line before closing function brace; 0 found

162

163

    protected function _executeQuery($details)

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_executeQuery" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

164

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

165

        $this->query($details['query'], $details['bind'] ?? []);

Coding Style introduced 2018-10-19 22:43 UTC by

Arithmetic operation must be bracketed

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax is not allowed

166

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

167

168

    protected function _reverseQuery($details)

Coding Style introduced 2018-10-19 22:43 UTC by

Protected method name "AbstractDatabaseManipulator::_reverseQuery" must not be prefixed with an underscore

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

169

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

170

171

Coding Style introduced 2018-10-19 22:43 UTC by

Function closing brace must go on the next line following the body; found 1 blank lines before brace

172

173

    abstract public function convertTypes($type, $direction, $length);

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

174

175

/**

Coding Style introduced 2018-10-19 22:43 UTC by

Missing short description in doc comment

176

177

     * @return SchemaDescription

178

*/

179

    public function getDescription()

180

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

181

        if (!is_object($this->schemaDescription)) {

Coding Style introduced 2018-10-19 22:43 UTC by

There must be a single space after a NOT operator; 0 found

182

            $this->schemaDescription = SchemaDescription::wrap($this->connection->describe(), $this);

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 101 characters

183

Coding Style introduced 2018-10-19 22:43 UTC by

No blank line found after control structure

184

        return $this->schemaDescription;

185

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

186

187

    public function setVersion($version)

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

188

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

189

        $this->query('INSERT INTO yentu_history(version) values (?)', array($version));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

190

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

191

192

    public function getVersion()

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

193

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

194

        $version = $this->query("SELECT MAX(version) as version FROM yentu_history");

Coding Style Comprehensibility introduced 2018-10-19 22:43 UTC by

The string literal SELECT MAX(version) as version FROM yentu_history does not require double quotes, as per coding-style, please use single quotes.

195

        return isset($version[0]) ? $version[0]['version'] : null;

Coding Style introduced 2018-10-19 22:43 UTC by

Inline IF statements are not allowed

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

196

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

197

198

    public function getLastSession()

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

199

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

200

        $session = $this->query("SELECT session FROM yentu_history ORDER BY id DESC LIMIT 1");

Coding Style Comprehensibility introduced 2018-10-19 22:43 UTC by

The string literal SELECT session FROM yent...RDER BY id DESC LIMIT 1 does not require double quotes, as per coding-style, please use single quotes.

201

        return isset($session[0]['session']) ? $session[0]['session'] : null;

Coding Style introduced 2018-10-19 22:43 UTC by

Inline IF statements are not allowed

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

202

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

203

204

    public function getSessionVersions($session)

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

205

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

206

        $sessionVersions = array();

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

207

        $versions = $this->query(

Coding Style introduced 2018-10-19 22:43 UTC by

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

208

            "SELECT DISTINCT version FROM yentu_history WHERE session = ?", array($session)

Coding Style Comprehensibility introduced 2018-10-19 22:43 UTC by

The string literal SELECT DISTINCT version ...story WHERE session = ? does not require double quotes, as per coding-style, please use single quotes.

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

209

);

210

211

        foreach ($versions as $version) {

212

            $sessionVersions[] = $version['version'];

213

214

215

        return $sessionVersions;

216

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

217

218

    public function createHistory()

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

219

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

220

        try {

221

            $this->connection->describeTable('yentu_history');

222

        } catch (\ntentan\atiaa\exceptions\TableNotFoundException $e) {

223

            $this->io->pushOutputLevel(Io::OUTPUT_LEVEL_0);

224

            $this->addTable(array('schema' => '', 'name' => 'yentu_history'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Bug introduced 2018-06-17 14:12 UTC by

The method addTable() does not exist on yentu\manipulators\AbstractDatabaseManipulator. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

225

226

            $this->addColumn(array('default' => null, 'schema' => '', 'nulls' => true, 'length' => null, 'table' => 'yentu_history', 'name' => 'session', 'type' => 'string'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 175 characters

Bug introduced 2018-06-17 14:12 UTC by

The method addColumn() does not exist on yentu\manipulators\AbstractDatabaseManipulator. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

227

            $this->addColumn(array('default' => null, 'schema' => '', 'nulls' => false, 'length' => null, 'table' => 'yentu_history', 'name' => 'version', 'type' => 'string'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 176 characters

228

            $this->addColumn(array('default' => null, 'schema' => '', 'nulls' => true, 'length' => null, 'table' => 'yentu_history', 'name' => 'method', 'type' => 'string'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 174 characters

229

            $this->addColumn(array('default' => null, 'schema' => '', 'nulls' => true, 'length' => null, 'table' => 'yentu_history', 'name' => 'arguments', 'type' => 'text'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 175 characters

230

            $this->addColumn(array('default' => null, 'schema' => '', 'nulls' => true, 'length' => null, 'table' => 'yentu_history', 'name' => 'migration', 'type' => 'string'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 177 characters

231

            $this->addColumn(array('default' => null, 'schema' => '', 'nulls' => true, 'length' => null, 'table' => 'yentu_history', 'name' => 'default_schema', 'type' => 'string'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 182 characters

232

            $this->addColumn(array('default' => null, 'schema' => '', 'nulls' => true, 'length' => null, 'table' => 'yentu_history', 'name' => 'id', 'type' => 'integer'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

Coding Style introduced 2018-10-19 22:43 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 171 characters

233

            $this->addPrimaryKey(array('schema' => '', 'table' => 'yentu_history', 'name' => 'yentu_history_pk', 'columns' => array('id')));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 140 characters

Bug introduced 2018-06-17 14:12 UTC by

The method addPrimaryKey() does not exist on yentu\manipulators\AbstractDatabaseManipulator. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

234

            $this->addAutoPrimaryKey(array('schema' => '', 'table' => 'yentu_history', 'column' => 'id'));

Coding Style introduced 2018-10-19 22:43 UTC by

Short array syntax must be used to define arrays

Coding Style introduced 2018-10-19 22:43 UTC by

This line exceeds maximum limit of 100 characters; contains 106 characters

Bug introduced 2018-06-17 14:12 UTC by

The method addAutoPrimaryKey() does not exist on yentu\manipulators\AbstractDatabaseManipulator. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

235

            $this->io->popOutputLevel();

236

237

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

238

239

    public function __clone()

Coding Style introduced 2018-10-19 22:43 UTC by

Missing function doc comment

240

Coding Style introduced 2018-10-19 22:43 UTC by

Opening brace should be on the same line as the declaration

241

        if (is_object($this->schemaDescription)) {

242

            $this->schemaDescription = clone $this->schemaDescription;

243

244

Coding Style introduced 2018-10-19 22:43 UTC by

Expected 1 blank line before closing function brace; 0 found

245

246

Coding Style introduced 2018-10-19 22:43 UTC by

As per coding style, files should not end with a newline character.

247

ntentan / yentu

Push — dev ( 4b619a...66d037 )

AbstractDatabaseManipulator::getDefaultSchema() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like