yentu\database\EncapsulatedStack

Complexity

Total Complexity

6

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	pop()	0	3	1
A	top()	0	3	1
A	push()	0	3	1
A	purge()	0	5	2
A	hasItems()	0	3	1

<?php
namespace yentu\database;

class EncapsulatedStack
{
    private array $stack = [];
    
    public function push(DatabaseItem $encapsulated): void
    {
        $this->stack[] = $encapsulated;
    }
    
    public function pop(): DatabaseItem
    {
        return array_pop($this->stack);
    }
    
    public function top(): DatabaseItem
    {
        return end($this->stack);
    }
    
    public function hasItems(): bool
    {
        return !empty($this->stack);
    }
    
    public function purge(): void
    {
        for ($i = 0; $i < count($this->stack); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $item = array_pop($this->stack);
            $item->commit();
        }
    }    
}