Issues in UniqueValidation.php (master) - Issues in master - ntentan/nibii - Measure and Improve Code Quality continuously with Scrutinizer

Issues (58)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/UniqueValidation.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * The MIT License
 *
 * Copyright 2014-2018 James Ekow Abaka Ainooson
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

namespace ntentan\nibii;

use ntentan\utils\validator\Validation;

class UniqueValidation extends Validation
{
    /**
     * @var RecordWrapper
     */
    private $model;
    private $mode;

    public function __construct($params)
    {
        $this->model = $params['model'];
        $this->mode = $params['mode'];
    }

    public function run($field, $data)
    {
        $test = [];
        foreach ($field['name'] as $name) {
            $test[$name] = isset($data[$name]) ? $data[$name] : null;
        }

        if ($test[$name] === null) {
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
            return true;
        }

        if ($this->mode == DataOperations::MODE_UPDATE) {
            $primaryKeyFields = $this->model->getDescription()->getPrimaryKey();
            $keys = [];
            foreach ($primaryKeyFields as $name) {
                $keys[$name] = $data[$name];
            }
            $testItem = $this->model->createNew()->fetchFirst($test);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $intersection = array_intersect($testItem->toArray(), $keys);
            if (!empty($intersection)) {
                return true;
            }
        } else {
            $testItem = ((new \ReflectionClass($this->model))->newInstance())->fields(array_keys($test))->fetchFirst($test);
        }

        return $this->evaluateResult(
            $field, $testItem === null, 'The value of '.implode(', ', $field['name']).' must be unique'
        );
    }
}


1		<?php
2
3		/*
4		* The MIT License
5		*
6		* Copyright 2014-2018 James Ekow Abaka Ainooson
7		*
8		* Permission is hereby granted, free of charge, to any person obtaining a copy
9		* of this software and associated documentation files (the "Software"), to deal
10		* in the Software without restriction, including without limitation the rights
11		* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
12		* copies of the Software, and to permit persons to whom the Software is
13		* furnished to do so, subject to the following conditions:
14		*
15		* The above copyright notice and this permission notice shall be included in
16		* all copies or substantial portions of the Software.
17		*
18		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
19		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
20		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
21		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
22		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
23		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
24		* THE SOFTWARE.
25		*/
26
27		namespace ntentan\nibii;
28
29		use ntentan\utils\validator\Validation;
30
31		class UniqueValidation extends Validation
32		{
33		/**
34		* @var RecordWrapper
35		*/
36		private $model;
37		private $mode;
38
39	6	public function __construct($params)
40		{
41	6	$this->model = $params['model'];
42	6	$this->mode = $params['mode'];
43	6	}
44
45	6	public function run($field, $data)
46		{
47	6	$test = [];
48	6	foreach ($field['name'] as $name) {
49	6	$test[$name] = isset($data[$name]) ? $data[$name] : null;
50		}
51
52	6	if ($test[$name] === null) {
		0 ignored issues – show Bug introduced 2017-05-05 09:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$name` seems to be defined by a `foreach` iteration on line `48`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
53		return true;
54		}
55
56	6	if ($this->mode == DataOperations::MODE_UPDATE) {
57		$primaryKeyFields = $this->model->getDescription()->getPrimaryKey();
58		$keys = [];
59		foreach ($primaryKeyFields as $name) {
60		$keys[$name] = $data[$name];
61		}
62		$testItem = $this->model->createNew()->fetchFirst($test);
		0 ignored issues – show Documentation Bug introduced 2017-07-18 14:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `createNew` does not exist on `object<ntentan\nibii\RecordWrapper>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
63		$intersection = array_intersect($testItem->toArray(), $keys);
64		if (!empty($intersection)) {
65		return true;
66		}
67		} else {
68	6	$testItem = ((new \ReflectionClass($this->model))->newInstance())->fields(array_keys($test))->fetchFirst($test);
69		}
70
71	6	return $this->evaluateResult(
72	6	$field, $testItem === null, 'The value of '.implode(', ', $field['name']).' must be unique'
73		);
74		}
75		}
76

ntentan / nibii

Issues (58)

Security Analysis no request data

src/UniqueValidation.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like