UniqueValidation - Code Metrics - Inspection of "Relocated unique validation and fixed its context..." - ntentan/nibii - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( acec2e...e58eb5 )

by James Ekow Abaka

created 2017-07-29 07:33 UTC

UniqueValidation A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

62.5%

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
wmc	8
c	1
b	1
f	0
lcom	1
cbo	4
dl	0
loc	51
ccs	15
cts	24
cp	0.625
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
C	run()	0	31	7

<?php

/*
 * The MIT License
 *
 * Copyright 2015 ekow.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

namespace ntentan\nibii;

use ntentan\utils\validator\Validation;
use ntentan\panie\Container;

class UniqueValidation extends Validation
{

    /**
     *
     * @var \ntentan\nibii\RecordWrapper
     */
    private $model;
    private $mode;
    private $container;

    public function __construct(Container $container, $params)
    {
        $this->model = $params['model'];
        $this->mode = $params['mode'];
        $this->container = $container;
    }

    public function run($field, $data)
    {
        $test = [];
        foreach ($field['name'] as $name) {
            $test[$name] = isset($data[$name]) ? $data[$name] : null;
        }

        if ($test[$name] === null) {
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
            return true;
        }

        if ($this->mode == \ntentan\nibii\DataOperations::MODE_UPDATE) {
            $primaryKeyFields = $this->model->getDescription()->getPrimaryKey();
            $keys = [];
            foreach ($primaryKeyFields as $name) {
                $keys[$name] = $data[$name];
            }
            $testItem = $this->model->createNew()->fetchFirst($test);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $intersection = array_intersect($testItem->toArray(), $keys);
            if (!empty($intersection)) {
                return true;
            }
        } else {
            $testItem = $this->container->resolve((new \ReflectionClass($this->model))->getName())
                            ->fields(array_keys($test))->fetchFirst($test);
        }

        return $this->evaluateResult(
            $field, $testItem->count() === 0, "The value of " . implode(', ', $field['name']) . " must be unique"
        );
    }

}


1		<?php
2
3		/*
4		* The MIT License
5		*
6		* Copyright 2015 ekow.
7		*
8		* Permission is hereby granted, free of charge, to any person obtaining a copy
9		* of this software and associated documentation files (the "Software"), to deal
10		* in the Software without restriction, including without limitation the rights
11		* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
12		* copies of the Software, and to permit persons to whom the Software is
13		* furnished to do so, subject to the following conditions:
14		*
15		* The above copyright notice and this permission notice shall be included in
16		* all copies or substantial portions of the Software.
17		*
18		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
19		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
20		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
21		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
22		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
23		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
24		* THE SOFTWARE.
25		*/
26
27		namespace ntentan\nibii;
28
29		use ntentan\utils\validator\Validation;
30		use ntentan\panie\Container;
31
32		class UniqueValidation extends Validation
33		{
34
35		/**
36		*
37		* @var \ntentan\nibii\RecordWrapper
38		*/
39		private $model;
40		private $mode;
41		private $container;
42
43	6	public function __construct(Container $container, $params)
44		{
45	6	$this->model = $params['model'];
46	6	$this->mode = $params['mode'];
47	6	$this->container = $container;
48	6	}
49
50	6	public function run($field, $data)
51		{
52	6	$test = [];
53	6	foreach ($field['name'] as $name) {
54	6	$test[$name] = isset($data[$name]) ? $data[$name] : null;
55		}
56
57	6	if ($test[$name] === null) {
		0 ignored issues – show Bug introduced 2017-05-05 09:11 UTC by Report Bug Copy Issue Report The variable `$name` seems to be defined by a `foreach` iteration on line `53`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
58		return true;
59		}
60
61	6	if ($this->mode == \ntentan\nibii\DataOperations::MODE_UPDATE) {
62		$primaryKeyFields = $this->model->getDescription()->getPrimaryKey();
63		$keys = [];
64		foreach ($primaryKeyFields as $name) {
65		$keys[$name] = $data[$name];
66		}
67		$testItem = $this->model->createNew()->fetchFirst($test);
		0 ignored issues – show Documentation Bug introduced 2017-07-18 14:01 UTC by Report Bug Copy Issue Report The method `createNew` does not exist on `object<ntentan\nibii\RecordWrapper>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
68		$intersection = array_intersect($testItem->toArray(), $keys);
69		if (!empty($intersection)) {
70		return true;
71		}
72		} else {
73	6	$testItem = $this->container->resolve((new \ReflectionClass($this->model))->getName())
74	6	->fields(array_keys($test))->fetchFirst($test);
75		}
76
77	6	return $this->evaluateResult(
78	6	$field, $testItem->count() === 0, "The value of " . implode(', ', $field['name']) . " must be unique"
79		);
80		}
81
82		}
83

ntentan / nibii

Push — master ( acec2e...e58eb5 )

UniqueValidation A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like