Complex classes like RecordWrapper often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RecordWrapper, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 35 | class RecordWrapper implements \ArrayAccess, \Countable, \Iterator |
||
| 36 | { |
||
| 37 | /** |
||
| 38 | * An associative array of models to which this model has a one to may relationship. |
||
| 39 | * |
||
| 40 | * @var array |
||
| 41 | */ |
||
| 42 | protected $hasMany = []; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * An associative array of models which have a one-to-many relationship with this model. |
||
| 46 | * |
||
| 47 | * @var array |
||
| 48 | */ |
||
| 49 | protected $belongsTo = []; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * An associative array of models with which this model has a many to many relationship. |
||
| 53 | * |
||
| 54 | * @var array |
||
| 55 | */ |
||
| 56 | protected $manyHaveMany = []; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * The name of the database table. |
||
| 60 | * |
||
| 61 | * @var string |
||
| 62 | */ |
||
| 63 | protected $table; |
||
| 64 | |||
| 65 | /** |
||
| 66 | * The name of the schema to which this table belongs. |
||
| 67 | * |
||
| 68 | * @var string |
||
| 69 | */ |
||
| 70 | protected $schema; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Temporary data held in the model object. |
||
| 74 | * |
||
| 75 | * @var array |
||
| 76 | */ |
||
| 77 | protected $modelData = []; |
||
| 78 | |||
| 79 | /** |
||
| 80 | * A quoted string of the table name used for building queries. |
||
| 81 | * |
||
| 82 | * @var string |
||
| 83 | */ |
||
| 84 | private $quotedTable; |
||
| 85 | |||
| 86 | /** |
||
| 87 | * The raw table name without any quotes. |
||
| 88 | * |
||
| 89 | * @var string |
||
| 90 | */ |
||
| 91 | private $unquotedTable; |
||
| 92 | |||
| 93 | /** |
||
| 94 | * An array of fields that contain validation errors after an attempted save. |
||
| 95 | * |
||
| 96 | * @var array |
||
| 97 | */ |
||
| 98 | private $invalidFields; |
||
| 99 | |||
| 100 | /** |
||
| 101 | * An instance of the operations dispatcher. |
||
| 102 | * |
||
| 103 | * @var Operations |
||
| 104 | */ |
||
| 105 | private $dynamicOperations; |
||
| 106 | |||
| 107 | /** |
||
| 108 | * Location of the RecordWrapper's internal iterator. |
||
| 109 | * |
||
| 110 | * @var int |
||
| 111 | */ |
||
| 112 | private $index = 0; |
||
| 113 | |||
| 114 | /** |
||
| 115 | * This flag is set whenever data is manually put in the model with the setData method. |
||
| 116 | * |
||
| 117 | * @var bool |
||
| 118 | */ |
||
| 119 | private $dataSet = false; |
||
| 120 | |||
| 121 | /** |
||
| 122 | * The name of the class for this model obtained through reflection. |
||
| 123 | * |
||
| 124 | * @var string |
||
| 125 | */ |
||
| 126 | private $className; |
||
| 127 | |||
| 128 | /** |
||
| 129 | * An instance of the driver adapter for interacting with the database. |
||
| 130 | * |
||
| 131 | * @var DriverAdapter |
||
| 132 | */ |
||
| 133 | private $adapter; |
||
| 134 | |||
| 135 | /** |
||
| 136 | * An instance of the ORMContext through which this model is operating. |
||
| 137 | * |
||
| 138 | * @var ORMContext |
||
| 139 | */ |
||
| 140 | private $context; |
||
| 141 | |||
| 142 | /** |
||
| 143 | * Keys for the various fields when model is accessed as an associative array. |
||
| 144 | * |
||
| 145 | * @var array |
||
| 146 | */ |
||
| 147 | private $keys = []; |
||
| 148 | |||
| 149 | /** |
||
| 150 | * This flag is set after the model has been properly initialized. |
||
| 151 | * Useful after model is unserialized or accessed through the static interface. |
||
| 152 | * |
||
| 153 | * @var bool |
||
| 154 | */ |
||
| 155 | private $initialized = false; |
||
| 156 | |||
| 157 | /** |
||
| 158 | * Initialize the record wrapper and setup the adapters, drivers, tables and schemas. |
||
| 159 | * After initialization, this method sets the initialized flag. |
||
| 160 | * |
||
| 161 | * @return void |
||
| 162 | */ |
||
| 163 | 36 | protected function initialize(): void |
|
| 164 | { |
||
| 165 | 36 | if ($this->initialized) { |
|
| 166 | 36 | return; |
|
| 167 | } |
||
| 168 | 36 | $this->context = ORMContext::getInstance(); |
|
|
|
|||
| 169 | 36 | $this->adapter = $this->context->getDriverAdapter(); |
|
| 170 | 36 | $table = $this->table ?? $this->context->getModelTable($this); |
|
| 171 | 36 | $driver = $this->context->getDbContext()->getDriver(); |
|
| 172 | 36 | $this->adapter->setContext($this->context); |
|
| 173 | 36 | $this->className = (new \ReflectionClass($this))->getName(); |
|
| 174 | 36 | if (is_string($table)) { |
|
| 175 | 36 | $this->table = $this->unquotedTable = $table; |
|
| 176 | } else { |
||
| 177 | $this->table = $table['table']; |
||
| 178 | $this->schema = $table['schema']; |
||
| 179 | } |
||
| 180 | 36 | $this->quotedTable = ($this->schema ? "{$driver->quoteIdentifier($this->schema)}." : '').$driver->quoteIdentifier($this->table); |
|
| 181 | 36 | $this->unquotedTable = ($this->schema ? "{$this->schema}." : '').$this->table; |
|
| 182 | 36 | $this->adapter->setModel($this, $this->quotedTable); |
|
| 183 | 36 | $this->initialized = true; |
|
| 184 | 36 | } |
|
| 185 | |||
| 186 | public function __debugInfo() |
||
| 187 | { |
||
| 188 | $data = $this->getData(); |
||
| 189 | |||
| 190 | return $this->hasMultipleItems() ? $data : isset($data[0]) ? $data[0] : []; |
||
| 191 | } |
||
| 192 | |||
| 193 | /** |
||
| 194 | * Return a description of the model wrapped by this wrapper. |
||
| 195 | * |
||
| 196 | * @return ModelDescription |
||
| 197 | */ |
||
| 198 | 28 | public function getDescription() : ModelDescription |
|
| 199 | { |
||
| 200 | 28 | $this->initialize(); |
|
| 201 | |||
| 202 | 28 | return $this->context->getCache()->read( |
|
| 203 | "{$this->className}::desc", function () { |
||
| 204 | 28 | return $this->context->getModelDescription($this); |
|
| 205 | 28 | } |
|
| 206 | ); |
||
| 207 | } |
||
| 208 | |||
| 209 | /** |
||
| 210 | * Return the number of items stored in the model or matched by the query. |
||
| 211 | * Depending on the state of the model, the count method will return different values. For models that have data |
||
| 212 | * values set with calls to setData, this method returns the number of records that were added. On the other hand, |
||
| 213 | * for models that do not have data set, this method queries the database to find out the number of records that |
||
| 214 | * are either in the model, or for models that have been filtered, the number of records that match the filter. |
||
| 215 | * |
||
| 216 | * @param int|array|QueryParameters $query |
||
| 217 | * |
||
| 218 | * @return int |
||
| 219 | */ |
||
| 220 | 8 | public function count($query = null) |
|
| 221 | { |
||
| 222 | 8 | if ($this->dataSet) { |
|
| 223 | 8 | return count($this->getData()); |
|
| 224 | } |
||
| 225 | |||
| 226 | return $this->__call('count', [$query]); |
||
| 227 | } |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Retrieve an item stored in the record. |
||
| 231 | * This method returns items that are directly stored in the model, or lazy loads related items if needed. |
||
| 232 | * The key could be a field in the model's table or the name of a related model. |
||
| 233 | * |
||
| 234 | * @param string $key A key identifying the item to be retrieved. |
||
| 235 | * |
||
| 236 | * @return mixed |
||
| 237 | */ |
||
| 238 | 12 | private function retrieveItem($key) |
|
| 239 | { |
||
| 240 | 12 | if ($this->hasMultipleItems()) { |
|
| 241 | throw new NibiiException('Current model object state contains multiple items. Please index with a numeric key to select a specific item first.'); |
||
| 242 | } |
||
| 243 | 12 | $relationships = $this->getDescription()->getRelationships(); |
|
| 244 | 12 | $decamelizedKey = Text::deCamelize($key); |
|
| 245 | 12 | if (isset($relationships[$key])) { |
|
| 246 | 8 | return $this->fetchRelatedFields($relationships[$key]); |
|
| 247 | } |
||
| 248 | |||
| 249 | 4 | return isset($this->modelData[$decamelizedKey]) ? $this->modelData[$decamelizedKey] : null; |
|
| 250 | } |
||
| 251 | |||
| 252 | /** |
||
| 253 | * Calls dynamic methods. |
||
| 254 | * |
||
| 255 | * @param string $name |
||
| 256 | * @param array $arguments |
||
| 257 | * |
||
| 258 | * @throws exceptions\NibiiException |
||
| 259 | * |
||
| 260 | * @return type |
||
| 261 | */ |
||
| 262 | 34 | public function __call($name, $arguments) |
|
| 263 | { |
||
| 264 | 34 | $this->initialize(); |
|
| 265 | 34 | if ($this->dynamicOperations === null) { |
|
| 266 | 34 | $this->dynamicOperations = new Operations($this, $this->quotedTable); |
|
| 267 | } |
||
| 268 | |||
| 269 | 34 | return $this->dynamicOperations->perform($name, $arguments); |
|
| 270 | } |
||
| 271 | |||
| 272 | /** |
||
| 273 | * Set a value for a field in the model. |
||
| 274 | * |
||
| 275 | * @param string $name |
||
| 276 | * @param mixed $value |
||
| 277 | */ |
||
| 278 | 8 | public function __set($name, $value) |
|
| 279 | { |
||
| 280 | 8 | $this->dataSet = true; |
|
| 281 | 8 | $this->modelData[Text::deCamelize($name)] = $value; |
|
| 282 | 8 | } |
|
| 283 | |||
| 284 | 12 | public function __get($name) |
|
| 288 | |||
| 289 | 10 | public function save() |
|
| 290 | { |
||
| 291 | 10 | $return = $this->__call('save', [$this->hasMultipleItems()]); |
|
| 292 | 10 | $this->invalidFields = $this->dynamicOperations->getInvalidFields(); |
|
| 293 | |||
| 294 | 10 | return $return; |
|
| 295 | } |
||
| 296 | |||
| 297 | 26 | private function hasMultipleItems() |
|
| 298 | { |
||
| 299 | 26 | if (count($this->modelData) > 0) { |
|
| 300 | 24 | return is_numeric(array_keys($this->modelData)[0]); |
|
| 301 | } else { |
||
| 302 | 2 | return false; |
|
| 303 | } |
||
| 304 | } |
||
| 305 | |||
| 306 | 18 | public function getData() |
|
| 320 | |||
| 321 | 26 | public function setData($data) |
|
| 322 | { |
||
| 323 | 26 | $this->dataSet = is_array($data) ? true : false; |
|
| 324 | 26 | $this->modelData = $data; |
|
| 325 | 26 | } |
|
| 326 | |||
| 327 | public function mergeData($data) |
||
| 328 | { |
||
| 329 | foreach ($data as $key => $value) { |
||
| 330 | $this->modelData[$key] = $value; |
||
| 331 | } |
||
| 332 | $this->dataSet = true; |
||
| 333 | } |
||
| 334 | |||
| 335 | 2 | public function offsetExists($offset) |
|
| 339 | |||
| 340 | 2 | public function offsetGet($offset) |
|
| 341 | { |
||
| 342 | 2 | if (is_numeric($offset)) { |
|
| 343 | 2 | return $this->wrap($offset); |
|
| 344 | } else { |
||
| 345 | 2 | return $this->retrieveItem($offset); |
|
| 346 | } |
||
| 347 | } |
||
| 348 | |||
| 349 | 2 | public function offsetSet($offset, $value) |
|
| 350 | { |
||
| 351 | 2 | $this->dataSet = true; |
|
| 352 | 2 | $this->modelData[$offset] = $value; |
|
| 353 | 2 | } |
|
| 354 | |||
| 355 | public function offsetUnset($offset) |
||
| 356 | { |
||
| 357 | unset($this->modelData[$offset]); |
||
| 358 | } |
||
| 359 | |||
| 360 | 6 | private function wrap($offset) |
|
| 361 | { |
||
| 362 | 6 | $this->initialize(); |
|
| 363 | 6 | if (isset($this->modelData[$offset])) { |
|
| 364 | 6 | $className = $this->className; |
|
| 365 | 6 | $newInstance = new $className(); |
|
| 366 | 6 | $newInstance->initialize(); |
|
| 367 | 6 | $newInstance->setData($this->modelData[$offset]); |
|
| 368 | |||
| 369 | 6 | return $newInstance; |
|
| 370 | } else { |
||
| 371 | return; |
||
| 372 | } |
||
| 373 | } |
||
| 374 | |||
| 375 | 4 | public function getInvalidFields() |
|
| 376 | { |
||
| 377 | 4 | return $this->invalidFields; |
|
| 378 | } |
||
| 379 | |||
| 380 | public function getHasMany() |
||
| 384 | |||
| 385 | public function getBelongsTo() |
||
| 386 | { |
||
| 387 | return $this->belongsTo; |
||
| 388 | } |
||
| 389 | |||
| 390 | 4 | public function current() |
|
| 391 | { |
||
| 392 | 4 | return $this->wrap($this->keys[$this->index]); |
|
| 393 | } |
||
| 394 | |||
| 395 | public function key() |
||
| 396 | { |
||
| 397 | return $this->keys[$this->index]; |
||
| 398 | } |
||
| 399 | |||
| 400 | 4 | public function next() |
|
| 401 | { |
||
| 402 | 4 | $this->index++; |
|
| 403 | 4 | } |
|
| 404 | |||
| 405 | 4 | public function rewind() |
|
| 406 | { |
||
| 407 | 4 | $this->keys = array_keys($this->modelData); |
|
| 408 | 4 | $this->index = 0; |
|
| 409 | 4 | } |
|
| 410 | |||
| 411 | 4 | public function valid() |
|
| 412 | { |
||
| 413 | 4 | return isset($this->keys[$this->index]) && isset($this->modelData[$this->keys[$this->index]]); |
|
| 414 | } |
||
| 415 | |||
| 416 | /** |
||
| 417 | * A custom validator for the record wrapper. |
||
| 418 | * |
||
| 419 | * @return mixed |
||
| 420 | */ |
||
| 421 | 10 | public function validate() |
|
| 425 | |||
| 426 | 12 | private function fetchRelatedFields($relationship, $index = null) |
|
| 427 | { |
||
| 428 | 12 | if ($index === null) { |
|
| 429 | 12 | $data = $this->modelData; |
|
| 430 | } else { |
||
| 431 | $data = $this->modelData[$index]; |
||
| 432 | } |
||
| 433 | 12 | $model = $relationship->getModelInstance(); |
|
| 434 | 12 | if (empty($data)) { |
|
| 435 | return $model; |
||
| 436 | } |
||
| 437 | 12 | $query = $relationship->prepareQuery($data); |
|
| 438 | |||
| 439 | 12 | return $query ? $model->fetch($query) : $model; |
|
| 440 | } |
||
| 441 | |||
| 442 | 28 | public function getRelationships() |
|
| 443 | { |
||
| 444 | return [ |
||
| 445 | 28 | 'HasMany' => $this->hasMany, |
|
| 446 | 28 | 'BelongsTo' => $this->belongsTo, |
|
| 447 | 28 | 'ManyHaveMany' => $this->manyHaveMany, |
|
| 448 | ]; |
||
| 449 | } |
||
| 450 | |||
| 451 | public function usetField($field) |
||
| 452 | { |
||
| 453 | unset($this->modelData[$field]); |
||
| 454 | } |
||
| 455 | |||
| 456 | /** |
||
| 457 | * Callback for when a record is either added or modified. |
||
| 458 | */ |
||
| 459 | 10 | public function preSaveCallback() |
|
| 460 | { |
||
| 461 | 10 | } |
|
| 462 | |||
| 463 | /** |
||
| 464 | * Callback for when a record has been added or modified. |
||
| 465 | * |
||
| 466 | * @param $id |
||
| 467 | */ |
||
| 468 | 6 | public function postSaveCallback() |
|
| 469 | { |
||
| 470 | 6 | } |
|
| 471 | |||
| 472 | /** |
||
| 473 | * Callback for when a new record is about to be created. |
||
| 474 | */ |
||
| 475 | 8 | public function preCreateCallback() |
|
| 476 | { |
||
| 477 | 8 | } |
|
| 478 | |||
| 479 | /** |
||
| 480 | * Callback for when a new record has been created. |
||
| 481 | * This callback can be most useful for obtaining the primary key of a newly created record. |
||
| 482 | * |
||
| 483 | * @param $id |
||
| 484 | */ |
||
| 485 | 4 | public function postCreateCallback($id) |
|
| 486 | { |
||
| 487 | 4 | } |
|
| 488 | |||
| 489 | /** |
||
| 490 | * Callback for when a record is about to be updated. |
||
| 491 | */ |
||
| 492 | 2 | public function preUpdateCallback() |
|
| 493 | { |
||
| 494 | 2 | } |
|
| 495 | |||
| 496 | /** |
||
| 497 | * Callback for when a record has been updated. |
||
| 498 | */ |
||
| 499 | 2 | public function postUpdateCallback() |
|
| 502 | |||
| 503 | 36 | public function getDBStoreInformation() |
|
| 504 | { |
||
| 505 | 36 | $this->initialize(); |
|
| 506 | |||
| 507 | return [ |
||
| 508 | 36 | 'schema' => $this->schema, |
|
| 509 | 36 | 'table' => $this->table, |
|
| 510 | 36 | 'quoted_table' => $this->quotedTable, |
|
| 511 | 36 | 'unquoted_table' => $this->unquotedTable, |
|
| 512 | ]; |
||
| 513 | } |
||
| 514 | |||
| 515 | /** |
||
| 516 | * @return DriverAdapter |
||
| 517 | */ |
||
| 518 | 36 | public function getAdapter() |
|
| 524 | |||
| 525 | 4 | private function expandArrayValue($array, $relationships, $depth, $expandableModels = [], $index = null) |
|
| 526 | { |
||
| 527 | 4 | if (empty($expandableModels)) { |
|
| 528 | 4 | foreach ($relationships as $name => $relationship) { |
|
| 529 | 4 | $array[$name] = $this->fetchRelatedFields($relationship, $index)->toArray($depth); |
|
| 530 | } |
||
| 531 | } else { |
||
| 532 | foreach ($expandableModels as $name) { |
||
| 533 | $array[$name] = $this->fetchRelatedFields($relationships[$name], $index)->toArray($depth, $expandableModels); |
||
| 534 | } |
||
| 535 | } |
||
| 536 | |||
| 537 | 4 | return $array; |
|
| 538 | } |
||
| 539 | |||
| 540 | 24 | public function toArray($depth = 0, $expandableModels = []) |
|
| 541 | { |
||
| 542 | 24 | $relationships = $this->getDescription()->getRelationships(); |
|
| 543 | 24 | $array = $this->modelData; |
|
| 544 | 24 | if ($depth > 0) { |
|
| 545 | 4 | if ($this->hasMultipleItems()) { |
|
| 546 | foreach ($array as $i => $value) { |
||
| 547 | $array[$i] = $this->expandArrayValue($value, $relationships, $depth - 1, $expandableModels, $i); |
||
| 548 | } |
||
| 549 | } else { |
||
| 550 | 4 | $array = $this->expandArrayValue($array, $relationships, $depth - 1, $expandableModels); |
|
| 551 | } |
||
| 552 | } |
||
| 553 | |||
| 554 | 24 | return $array; |
|
| 555 | } |
||
| 556 | } |
||
| 557 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..