DriverAdapter::select() - Code Metrics - Inspection of "Some documentation and work on the count operation..." - ntentan/nibii - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 798733...6762cf )

by James Ekow Abaka

created 2017-11-09 18:36 UTC

DriverAdapter::select() A

↳ Parent: DriverAdapter

Complexity

Conditions	3
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	2
nop	1
crap	3

<?php

namespace ntentan\nibii;

/**
 * DriverAdapter provides a generic interface through which specific database operations can be performed.
 * It
 */
abstract class DriverAdapter
{

    protected $data;
    private $insertQuery;
    private $updateQuery;
    private $modelInstance;
    protected $queryEngine;
    private $driver;

    public function setContext(ORMContext $context)
    {
        $this->driver = $context->getDbContext()->getDriver();
    }

    public function setData($data)
    {
        $this->data = $data;
    }

    /**
     * Convert datatypes from the database system's native type to a generic type
     * supported by nibii.
     *
     * @param string $nativeType The native datatype
     * @return string The generic datatype for use in nibii.
     */
    abstract public function mapDataTypes($nativeType);

    /**
     *
     *
     * @param QueryParameters $parameters
     * @return type
     */
    public function select($parameters)
    {
        $result = $this->driver->query(
            $this->getQueryEngine()->getSelectQuery($parameters),
            $parameters->getBoundData()
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        if ($parameters->getFirstOnly() && isset($result[0])) {
            $result = $result[0];
        }

        return $result;
    }

    /**
     * @param QueryParameters $parameters
     */
    public function count($parameters)

    {
        $result = $this->driver->query($this->getQueryEngine()->getCountQuery($parameters), $parameters->getBoundData());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        return $result[0]['count'];
    }

    private function initInsert()
    {
        $this->insertQuery = $this->getQueryEngine()->getInsertQuery($this->modelInstance);
    }

    private function initUpdate()
    {
        $this->updateQuery = $this->getQueryEngine()->getUpdateQuery($this->modelInstance);
    }

    public function insert($record)
    {
        if ($this->insertQuery === null) {
            $this->initInsert();
        }
        return $this->driver->query($this->insertQuery, $record);
    }

    public function update($record)
    {
        if ($this->updateQuery === null) {
            $this->initUpdate();
        }
        return $this->driver->query($this->updateQuery, $record);
    }

    /**
     * @param QueryParameters $parameters
     */
    public function bulkUpdate($data, $parameters)
    {
        return $this->driver->query(
            $this->getQueryEngine()->getBulkUpdateQuery($data, $parameters), array_merge($data, $parameters->getBoundData())
        );
    }

    /**
     * @param QueryParameters $parameters
     */
    public function delete($parameters)
    {
        return $this->driver->query(
            $this->getQueryEngine()->getDeleteQuery($parameters), $parameters->getBoundData()
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }

    public function describe($model, $relationships)

    {
        return new ModelDescription(
            $this->driver->describeTable($table)[$table], $relationships, function ($type) {

            return $this->mapDataTypes($type);
        }
        );
    }

    /**
     *
     * @return \ntentan\nibii\QueryEngine
     */
    private function getQueryEngine()
    {
        if ($this->queryEngine === null) {
            $this->queryEngine = new QueryEngine();
            $this->queryEngine->setDriver($this->driver);
        }
        return $this->queryEngine;
    }

    /**
     * @param RecordWrapper $model
     */
    public function setModel($model)
    {
        $this->modelInstance = $model;
    }

    public function getDriver()
    {
        return $this->driver;
    }

}


1		<?php
2
3		namespace ntentan\nibii;
4
5		/**
6		* DriverAdapter provides a generic interface through which specific database operations can be performed.
7		* It
8		*/
9		abstract class DriverAdapter
10		{
11
12		protected $data;
13		private $insertQuery;
14		private $updateQuery;
15		private $modelInstance;
16		protected $queryEngine;
17		private $driver;
18
19	36	public function setContext(ORMContext $context)
20		{
21	36	$this->driver = $context->getDbContext()->getDriver();
22	36	}
23
24		public function setData($data)
25		{
26		$this->data = $data;
27		}
28
29		/**
30		* Convert datatypes from the database system's native type to a generic type
31		* supported by nibii.
32		*
33		* @param string $nativeType The native datatype
34		* @return string The generic datatype for use in nibii.
35		*/
36		abstract public function mapDataTypes($nativeType);
37
38		/**
39		*
40		*
41		* @param QueryParameters $parameters
42		* @return type
43		*/
44	24	public function select($parameters)
45		{
46	24	$result = $this->driver->query(
47	24	$this->getQueryEngine()->getSelectQuery($parameters),
48	24	$parameters->getBoundData()
		0 ignored issues – show Documentation introduced 2017-05-21 02:04 UTC by Report Bug Copy Issue Report `$parameters->getBoundData()` is of type `array\|boolean`, but the function expects a `false\|array<integer,*>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49		);
50
51	24	if ($parameters->getFirstOnly() && isset($result[0])) {
52	20	$result = $result[0];
53		}
54
55	24	return $result;
56		}
57
58		/**
59		* @param QueryParameters $parameters
60		*/
61	4	public function count($parameters)
		0 ignored issues – show Documentation introduced 2017-10-30 04:06 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
62		{
63	4	$result = $this->driver->query($this->getQueryEngine()->getCountQuery($parameters), $parameters->getBoundData());
		0 ignored issues – show Documentation introduced 2017-10-30 04:06 UTC by Report Bug Copy Issue Report `$parameters->getBoundData()` is of type `array\|boolean`, but the function expects a `false\|array<integer,*>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
64	4	return $result[0]['count'];
65		}
66
67		private function initInsert()
68		{
69		$this->insertQuery = $this->getQueryEngine()->getInsertQuery($this->modelInstance);
70		}
71
72	2	private function initUpdate()
73		{
74	2	$this->updateQuery = $this->getQueryEngine()->getUpdateQuery($this->modelInstance);
75	2	}
76
77		public function insert($record)
78		{
79		if ($this->insertQuery === null) {
80		$this->initInsert();
81		}
82		return $this->driver->query($this->insertQuery, $record);
83		}
84
85	2	public function update($record)
86		{
87	2	if ($this->updateQuery === null) {
88	2	$this->initUpdate();
89		}
90	2	return $this->driver->query($this->updateQuery, $record);
91		}
92
93		/**
94		* @param QueryParameters $parameters
95		*/
96	6	public function bulkUpdate($data, $parameters)
97		{
98	6	return $this->driver->query(
99	6	$this->getQueryEngine()->getBulkUpdateQuery($data, $parameters), array_merge($data, $parameters->getBoundData())
100		);
101		}
102
103		/**
104		* @param QueryParameters $parameters
105		*/
106	2	public function delete($parameters)
107		{
108	2	return $this->driver->query(
109	2	$this->getQueryEngine()->getDeleteQuery($parameters), $parameters->getBoundData()
		0 ignored issues – show Documentation introduced 2017-05-21 02:04 UTC by Report Bug Copy Issue Report `$parameters->getBoundData()` is of type `array\|boolean`, but the function expects a `false\|array<integer,*>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
110		);
111		}
112
113		public function describe($model, $relationships)
		0 ignored issues – show Unused Code introduced 2017-08-06 18:08 UTC by Report Bug Copy Issue Report The parameter `$model` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
114		{
115		return new ModelDescription(
116		$this->driver->describeTable($table)[$table], $relationships, function ($type) {
		0 ignored issues – show Bug introduced 2017-04-01 21:58 UTC by Report Bug Copy Issue Report The variable `$table` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Unused Code introduced 2017-04-01 21:58 UTC by Report Bug Copy Issue Report The call to `ModelDescription::__construct()` has too many arguments starting with `$relationships`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
117		return $this->mapDataTypes($type);
118		}
119		);
120		}
121
122		/**
123		*
124		* @return \ntentan\nibii\QueryEngine
125		*/
126	32	private function getQueryEngine()
127		{
128	32	if ($this->queryEngine === null) {
129	32	$this->queryEngine = new QueryEngine();
130	32	$this->queryEngine->setDriver($this->driver);
131		}
132	32	return $this->queryEngine;
133		}
134
135		/**
136		* @param RecordWrapper $model
137		*/
138	36	public function setModel($model)
139		{
140	36	$this->modelInstance = $model;
141	36	}
142
143		public function getDriver()
144		{
145		return $this->driver;
146		}
147
148		}
149

ntentan / nibii

Push — master ( 798733...6762cf )

DriverAdapter::select() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like