Complex classes like RecordWrapper often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RecordWrapper, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 35 | class RecordWrapper implements \ArrayAccess, \Countable, \Iterator |
||
| 36 | { |
||
| 37 | /** |
||
| 38 | * An associative array of models to which this model has a one to may relationship. |
||
| 39 | * |
||
| 40 | * @var array |
||
| 41 | */ |
||
| 42 | protected $hasMany = []; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * An associative array of models which have a one-to-many relationship with this model. |
||
| 46 | * |
||
| 47 | * @var array |
||
| 48 | */ |
||
| 49 | protected $belongsTo = []; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * An associative array of models with which this model has a many to many relationship. |
||
| 53 | * |
||
| 54 | * @var array |
||
| 55 | */ |
||
| 56 | protected $manyHaveMany = []; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * The name of the database table. |
||
| 60 | * |
||
| 61 | * @var string |
||
| 62 | */ |
||
| 63 | protected $table; |
||
| 64 | |||
| 65 | /** |
||
| 66 | * The name of the schema to which this table belongs. |
||
| 67 | * |
||
| 68 | * @var string |
||
| 69 | */ |
||
| 70 | protected $schema; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Temporary data held in the model object. |
||
| 74 | * |
||
| 75 | * @var array |
||
| 76 | */ |
||
| 77 | protected $modelData = []; |
||
| 78 | |||
| 79 | /** |
||
| 80 | * A quoted string of the table name used for building queries. |
||
| 81 | * |
||
| 82 | * @var string |
||
| 83 | */ |
||
| 84 | private $quotedTable; |
||
| 85 | |||
| 86 | /** |
||
| 87 | * The raw table name without any quotes. |
||
| 88 | * |
||
| 89 | * @var string |
||
| 90 | */ |
||
| 91 | private $unquotedTable; |
||
| 92 | |||
| 93 | /** |
||
| 94 | * An array of fields that contain validation errors after an attempted save. |
||
| 95 | * |
||
| 96 | * @var array |
||
| 97 | */ |
||
| 98 | private $invalidFields; |
||
| 99 | |||
| 100 | /** |
||
| 101 | * An instance of the operations dispatcher. |
||
| 102 | * |
||
| 103 | * @var Operations |
||
| 104 | */ |
||
| 105 | private $dynamicOperations; |
||
| 106 | |||
| 107 | /** |
||
| 108 | * Location of the RecordWrapper's internal iterator. |
||
| 109 | * |
||
| 110 | * @var int |
||
| 111 | */ |
||
| 112 | private $index = 0; |
||
| 113 | |||
| 114 | /** |
||
| 115 | * This flag is set whenever data is manually put in the model with the setData method. |
||
| 116 | * |
||
| 117 | * @var bool |
||
| 118 | */ |
||
| 119 | private $dataSet = false; |
||
| 120 | |||
| 121 | /** |
||
| 122 | * The name of the class for this model obtained through reflection. |
||
| 123 | * |
||
| 124 | * @var string |
||
| 125 | */ |
||
| 126 | private $className; |
||
| 127 | |||
| 128 | /** |
||
| 129 | * An instance of the driver adapter for interacting with the database. |
||
| 130 | * |
||
| 131 | * @var DriverAdapter |
||
| 132 | */ |
||
| 133 | private $adapter; |
||
| 134 | |||
| 135 | /** |
||
| 136 | * An instance of the ORMContext through which this model is operating. |
||
| 137 | * |
||
| 138 | * @var ORMContext |
||
| 139 | */ |
||
| 140 | private $context; |
||
| 141 | |||
| 142 | /** |
||
| 143 | * Keys for the various fields when model is accessed as an associative array. |
||
| 144 | * |
||
| 145 | * @var array |
||
| 146 | */ |
||
| 147 | private $keys = []; |
||
| 148 | |||
| 149 | /** |
||
| 150 | * This flag is set after the model has been properly initialized. |
||
| 151 | * Useful after model is unserialized or accessed through the static interface. |
||
| 152 | * |
||
| 153 | * @var bool |
||
| 154 | */ |
||
| 155 | private $initialized = false; |
||
| 156 | |||
| 157 | /** |
||
| 158 | * Initialize the record wrapper and setup the adapters, drivers, tables and schemas. |
||
| 159 | * After initialization, this method sets the initialized flag. |
||
| 160 | * |
||
| 161 | * @return void |
||
| 162 | */ |
||
| 163 | protected function initialize(): void |
||
| 185 | |||
| 186 | public function __debugInfo() |
||
| 192 | |||
| 193 | /** |
||
| 194 | * Return a description of the model wrapped by this wrapper. |
||
| 195 | * |
||
| 196 | * @return ModelDescription |
||
| 197 | */ |
||
| 198 | public function getDescription() : ModelDescription |
||
| 208 | |||
| 209 | /** |
||
| 210 | * Return the number of items stored in the model or matched by the query. |
||
| 211 | * Depending on the state of the model, the count method will return different values. For models that have data |
||
| 212 | * values set with calls to setData, this method returns the number of records that were added. On the other hand, |
||
| 213 | * for models that do not have data set, this method queries the database to find out the number of records that |
||
| 214 | * are either in the model, or for models that have been filtered, the number of records that match the filter. |
||
| 215 | * |
||
| 216 | * @param int|array|QueryParameters $query |
||
| 217 | * |
||
| 218 | * @return int |
||
| 219 | */ |
||
| 220 | public function count($query = null) |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Retrieve an item stored in the record. |
||
| 231 | * This method returns items that are directly stored in the model, or lazy loads related items if needed. |
||
| 232 | * The key could be a field in the model's table or the name of a related model. |
||
| 233 | * |
||
| 234 | * @param string $key A key identifying the item to be retrieved. |
||
| 235 | * |
||
| 236 | * @return mixed |
||
| 237 | */ |
||
| 238 | private function retrieveItem($key) |
||
| 251 | |||
| 252 | /** |
||
| 253 | * Calls dynamic methods. |
||
| 254 | * |
||
| 255 | * @param string $name |
||
| 256 | * @param array $arguments |
||
| 257 | * |
||
| 258 | * @throws exceptions\NibiiException |
||
| 259 | * |
||
| 260 | * @return type |
||
| 261 | */ |
||
| 262 | public function __call($name, $arguments) |
||
| 271 | |||
| 272 | /** |
||
| 273 | * Set a value for a field in the model. |
||
| 274 | * |
||
| 275 | * @param string $name |
||
| 276 | * @param mixed $value |
||
| 277 | */ |
||
| 278 | public function __set($name, $value) |
||
| 283 | |||
| 284 | public function __get($name) |
||
| 288 | |||
| 289 | public function save() |
||
| 296 | |||
| 297 | private function hasMultipleItems() |
||
| 305 | |||
| 306 | public function getData() |
||
| 320 | |||
| 321 | public function setData($data) |
||
| 326 | |||
| 327 | public function mergeData($data) |
||
| 334 | |||
| 335 | public function offsetExists($offset) |
||
| 339 | |||
| 340 | public function offsetGet($offset) |
||
| 348 | |||
| 349 | public function offsetSet($offset, $value) |
||
| 354 | |||
| 355 | public function offsetUnset($offset) |
||
| 359 | |||
| 360 | private function wrap($offset) |
||
| 374 | |||
| 375 | public function getInvalidFields() |
||
| 379 | |||
| 380 | public function getHasMany() |
||
| 384 | |||
| 385 | public function getBelongsTo() |
||
| 389 | |||
| 390 | public function current() |
||
| 394 | |||
| 395 | public function key() |
||
| 399 | |||
| 400 | public function next() |
||
| 404 | |||
| 405 | public function rewind() |
||
| 410 | |||
| 411 | public function valid() |
||
| 415 | |||
| 416 | /** |
||
| 417 | * A custom validator for the record wrapper. |
||
| 418 | * |
||
| 419 | * @return mixed |
||
| 420 | */ |
||
| 421 | public function onValidate($invalidFields) |
||
| 422 | { |
||
| 423 | return []; |
||
| 424 | } |
||
| 425 | |||
| 426 | private function fetchRelatedFields($relationship, $index = null) |
||
| 441 | |||
| 442 | public function getRelationships() |
||
| 450 | |||
| 451 | public function usetField($field) |
||
| 455 | |||
| 456 | /** |
||
| 457 | * Callback for when a record is either added or modified. |
||
| 458 | */ |
||
| 459 | public function preSaveCallback() |
||
| 462 | |||
| 463 | /** |
||
| 464 | * Callback for when a record has been added or modified. |
||
| 465 | * |
||
| 466 | * @param $id |
||
| 467 | */ |
||
| 468 | public function postSaveCallback() |
||
| 471 | |||
| 472 | /** |
||
| 473 | * Callback for when a new record is about to be created. |
||
| 474 | */ |
||
| 475 | public function preCreateCallback() |
||
| 478 | |||
| 479 | /** |
||
| 480 | * Callback for when a new record has been created. |
||
| 481 | * This callback can be most useful for obtaining the primary key of a newly created record. |
||
| 482 | * |
||
| 483 | * @param $id |
||
| 484 | */ |
||
| 485 | public function postCreateCallback($id) |
||
| 488 | |||
| 489 | /** |
||
| 490 | * Callback for when a record is about to be updated. |
||
| 491 | */ |
||
| 492 | public function preUpdateCallback() |
||
| 495 | |||
| 496 | /** |
||
| 497 | * Callback for when a record has been updated. |
||
| 498 | */ |
||
| 499 | public function postUpdateCallback() |
||
| 502 | |||
| 503 | public function getDBStoreInformation() |
||
| 514 | |||
| 515 | /** |
||
| 516 | * @return DriverAdapter |
||
| 517 | */ |
||
| 518 | public function getAdapter() |
||
| 524 | |||
| 525 | private function expandArrayValue($array, $relationships, $depth, $expandableModels = [], $index = null) |
||
| 539 | |||
| 540 | public function toArray($depth = 0, $expandableModels = []) |
||
| 556 | } |
||
| 557 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..