ntentan\honam\engines\php\helpers\ImagesHelper

Complexity

Total Complexity

20

Size/Duplication

Total Lines	146
Duplicated Lines	21.92 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	loadImage()	16	16	4
A	writeImage()	16	16	4
A	resize()	0	29	3
A	crop()	0	15	2
B	thumbnail()	0	27	6
A	quality()	0	5	1

<?php
namespace ntentan\honam\engines\php\helpers;

use ntentan\honam\engines\php\Helper;


/**
 * 
 * 
 * @todo Completely rewrite this helper to make it more efficient. Expose the
 * interfaces as they are. Consider using Image Magick.
 */
class ImagesHelper extends Helper
{
    private $quality = 90;
    
    private function loadImage($path)

This method seems to be duplicated in your project.

    {
    	$array = explode(".", $path);
        switch(strtolower(end($array)))
        {
            case 'png':
                $image = imagecreatefrompng($path);
                break;

            case 'jpeg':
            case 'jpg':
                $image = imagecreatefromjpeg($path);
                break;
        }
        return $image;

The variable $image does not seem to be defined for all execution paths leading up to this point.

    }
    
    private function writeImage($image, $path)

The return type could not be reliably inferred; please add a @return annotation.

This method seems to be duplicated in your project.

    {
    	$array = explode(".", $path);
        switch(strtolower(end($array)))
        {
            case 'png':
                $image = imagepng($image, $path);
                break;

            case 'jpeg':
            case 'jpg':
                $image = imagejpeg($image, $path, $this->quality);
                break;
        }
        return $image;        
    }
    
    /**
     * Resizes an image.
     * 
     * @param string $src Path to the image to be resized
     * @param string $dest Path to sore the resized image
     * @param integer $width New width of the image
     * @param integer $height New Height of the image
     */
    public function resize($src, $dest, $width = 0, $height = 0)
    {
        $im = $this->loadImage($src);
        $outputWidth = imagesx($im);
        $outputHeight = imagesy($im);

        $aspect = $outputWidth / $outputHeight;

        if($width<=0)
        {
            $width = $aspect * $height;
        }
        else if($height<=0)
        {
            $height = $width / $aspect;
        }

        $destinationImage = imagecreatetruecolor($width, $height);
        imagealphablending($destinationImage, false );
        imagesavealpha($destinationImage, true );
        imagecopyresampled($destinationImage, $im, 0, 0, 0, 0, $width, $height, $outputWidth, $outputHeight);

        $this->writeImage($destinationImage, $dest);
        
        imagedestroy($im);
        imagedestroy($destinationImage);

        return $dest;
    }

    /**
     * Crops an image. This function crops by fitting the image into the center
     * of a new cropping area. If the cropping area is smaller than the image
     * the image is scaled to fit.
     *
     * @param string $src The path to the source image
     * @param string $dest The path to the destination image
     * @param int $width The cropping width
     * @param int $height The cropping height
     * @param boolean $head Place the cropping area on top of the image
     */
    public function crop($src, $dest, $width, $height,$head=false)
    {
        $im = $this->loadImage($src);
        $o_width = imagesx($im);
        $o_height = imagesy($im);
        if($head==false) $top = ($o_height/2)-($height/2); else $top=0;

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

        $left = ($o_width/2)-($width/2);
        $im2 = imagecreatetruecolor ($width, $height);
        imagealphablending($im2, false );
        imagesavealpha($im2, true );
        imagecopyresampled($im2,$im,0,0,$left,$top,$width,$height,$width,$height);
        $this->writeImage($im2, $dest);
        imagedestroy($im);
        imagedestroy($im2);
    }

    /**
     * A smart thumbnailing function. Generates thumbnail images without
     * distorting the output of the final image.
     * @param string $file

There is no parameter named $file. Was it maybe removed?

     * @param string $width
     * @param string $height
     * @param string $head
     * @return string
     */
    public function thumbnail($source, $destination, $width, $height, $head=false, $overwrite=false)
    {
        if(!is_file($source)) return;
        if(!is_file($destination) || (filemtime($source)>filemtime($destination)) || $overwrite === true)
        {
            $image = $this->loadImage($source);
            $imageWidth = imagesx($image);
            $imageHeight = imagesy($image);
            imagedestroy($image);
            $tempImage = 'cache/' . uniqid() . ".png";

            $aspect = $imageWidth / $imageHeight;

            if($aspect * $height >= $width)
            {
                $this->resize($source, $tempImage, 0, $height);
            }
            else
            {
                $this->resize($source, $tempImage, $width, 0);
            }

            $this->crop( $tempImage, $destination, $width, $height, $head);

It seems like $head defined by parameter $head on line 125 can also be of type string; however, ntentan\honam\engines\php\helpers\ImagesHelper::crop() does only seem to accept boolean, maybe add an additional type check?

            unlink($tempImage);
        }
        return $destination;
    }
    
    public function quality($quality)
    {
        $this->quality = $quality;
        return $this;
    }
}