Core::__destruct() - Code Metrics - Inspection of "Got tests running now on the integration side" - ntentan/honam - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 8a2d43...215a79 )

by James Ekow Abaka

created 2019-05-19 23:23 UTC

Core::__destruct() A

↳ Parent: Core

Complexity

Conditions	5
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.5222
c	0
b	0
f	0
cc	5
nc	4
nop	0

<?php
namespace ntentan\honam\engines\smarty;

use ntentan\honam\factories\HelperFactory;
use Smarty;

class Core extends Smarty
{
    private $temp;
    private $helperFactory;
    
    public function __construct(HelperFactory $helperFactory, string $tempDirectory)
    {
        parent::__construct();
        $this->temp = $tempDirectory;
        $this->helperFactory = $helperFactory;
        $this->setCompileDir("{$this->temp}/smarty_compiled_templates");
    }
    
    public function __destruct() 
    {
        if($this->temp === '.' && file_exists("./smarty_compiled_templates")) {
            $files = scandir("./smarty_compiled_templates");
            foreach($files as $file) {
                if($file == "." | $file == "..") {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                    continue;
                }
                unlink("./smarty_compiled_templates/$file");
            }
            rmdir("./smarty_compiled_templates");
        }
    }

    public function setData($data)
    {
        $this->clearAllAssign();
        $this->assign($data);
        $this->assign('honam', $this->helperFactory);
    }
}


1			<?php
2			namespace ntentan\honam\engines\smarty;
3
4			use ntentan\honam\factories\HelperFactory;
5			use Smarty;
6
7			class Core extends Smarty
8			{
9			private $temp;
10			private $helperFactory;
11
12			public function __construct(HelperFactory $helperFactory, string $tempDirectory)
13			{
14			parent::__construct();
15			$this->temp = $tempDirectory;
16			$this->helperFactory = $helperFactory;
17			$this->setCompileDir("{$this->temp}/smarty_compiled_templates");
18			}
19
20			public function __destruct()
21			{
22			if($this->temp === '.' && file_exists("./smarty_compiled_templates")) {
23			$files = scandir("./smarty_compiled_templates");
24			foreach($files as $file) {
25			if($file == "." \| $file == "..") {
			0 ignored issues – show Comprehensibility introduced 2016-03-27 07:30 UTC by Report Bug Copy Issue Report Consider adding parentheses for clarity. Current Interpretation: `($file == '.') \| $file == '..'`, Probably Intended Meaning: `$file == ('.' \| $file == '..')` When comparing the result of a bit operation, we suggest to add explicit parenthesis and not to rely on PHP’s built-in operator precedence to ensure the code behaves as intended and to make it more readable. Let’s take a look at these examples: // Returns always int(0). return 0 === $foo & 4; return (0 === $foo) & 4; // More likely intended return: true/false return 0 === ($foo & 4); Loading history...
26			continue;
27			}
28			unlink("./smarty_compiled_templates/$file");
29			}
30			rmdir("./smarty_compiled_templates");
31			}
32			}
33
34			public function setData($data)
35			{
36			$this->clearAllAssign();
37			$this->assign($data);
38			$this->assign('honam', $this->helperFactory);
39			}
40			}
41

ntentan / honam

Push — dev ( 8a2d43...215a79 )

Core::__destruct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like