DbContext::getInstance() - Code Metrics - Inspection of "DbContext can be destroyed and Driver constructor..." - ntentan/atiaa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f42128...f70f0b )

by James Ekow Abaka

created 2017-09-07 02:32 UTC

DbContext::getInstance() A

↳ Parent: DbContext

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	7
ccs	0
cts	4
cp	0
rs	9.4285
cc	2
eloc	4
nc	2
nop	0
crap	6

<?php

namespace ntentan\atiaa;

use ntentan\panie\Container;
use ntentan\utils\Text;

class DbContext

{

    private $driver;
    private $driverFactory;
    private static $instance;

    private function __construct(DriverFactory $driverFactory)
    {
        $this->driverFactory = $driverFactory;
        self::$instance = $this;
    }

    public static function initialize(DriverFactory $driverFactory)
    {
        self::$instance = new self($driverFactory);
        return self::$instance;
    }

    public static function getInstance(): DbContext
    {
        if(!self::$instance) {
            throw new \Exception("The database context has not been initialized");  
        }
        return self::$instance;
    }

    /**
     *
     * @return Driver
     */
    public function getDriver() : Driver
    {
        if (is_null($this->driver)) {
            $this->driver = $this->driverFactory->createDriver();
            $this->driver->connect();
        }
        return $this->driver;
    }

    public function query($query, $bindData = false)
    {
        return $this->getDriver()->query($query, $bindData);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public static function destroy()
    {
        self::$instance->getDriver()->disconnect();
        self::$instance = null;
    }

}


1			<?php
2
3			namespace ntentan\atiaa;
4
5			use ntentan\panie\Container;
6			use ntentan\utils\Text;
7
8			class DbContext
			0 ignored issues – show Coding Style introduced 2017-09-05 13:36 UTC by Report Bug Copy Issue Report Since you have declared the constructor as private, maybe you should also declare the class as final. Loading history...
9			{
10
11			private $driver;
12			private $driverFactory;
13			private static $instance;
14
15			private function __construct(DriverFactory $driverFactory)
16			{
17			$this->driverFactory = $driverFactory;
18			self::$instance = $this;
19			}
20
21			public static function initialize(DriverFactory $driverFactory)
22			{
23			self::$instance = new self($driverFactory);
24			return self::$instance;
25			}
26
27			public static function getInstance(): DbContext
28			{
29			if(!self::$instance) {
30			throw new \Exception("The database context has not been initialized");
31			}
32			return self::$instance;
33			}
34
35			/**
36			*
37			* @return Driver
38			*/
39			public function getDriver() : Driver
40			{
41			if (is_null($this->driver)) {
42			$this->driver = $this->driverFactory->createDriver();
43			$this->driver->connect();
44			}
45			return $this->driver;
46			}
47
48			public function query($query, $bindData = false)
49			{
50			return $this->getDriver()->query($query, $bindData);
			0 ignored issues – show Documentation introduced 2015-12-16 14:00 UTC by Report Bug Copy Issue Report `$bindData` is of type `boolean`, but the function expects a `false\|array<integer,*>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51			}
52
53			public static function destroy()
54			{
55			self::$instance->getDriver()->disconnect();
56			self::$instance = null;
57			}
58
59			}
60

ntentan / atiaa

Push — master ( f42128...f70f0b )

DbContext::getInstance() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like