Db::getDriver() - Code Metrics - Inspection of "Added a query method" - ntentan/atiaa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f2dd2e...a32d5e )

by James Ekow Abaka

created 2015-12-16 13:52 UTC

Db::getDriver() A

↳ Parent: Db

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	14
rs	9.4286
cc	3
eloc	8
nc	3
nop	0

<?php

namespace ntentan\atiaa;

class Db
{
    private static $db;
    private static $defaultSettings;
    
    /**
     * 
     * @return Driver
     */
    public static function getDriver()
    {
        if(self::$db == null) {
            self::$db = \ntentan\atiaa\Driver::getConnection(self::$defaultSettings);
            self::$db->setCleanDefaults(true);

            try {
                self::$db->getPDO()->setAttribute(\PDO::ATTR_AUTOCOMMIT, false);
            } catch (\PDOException $e) {
                // Just do nothing for drivers which do not allow turning off autocommit
            }
        }
        return self::$db;
    }    
    
    /**
     * Set the settings used for creating default datastores.
     * @param array $settings
     */
    public static function setDefaultSettings($settings)
    {
        self::$defaultSettings = $settings;
    }    
    
    public static function getDefaultSettings()
    {
        return self::$defaultSettings;
    }
    
    public static function reset()
    {
        if(self::$db !== null) {
            self::$db->disconnect();
            self::$db = null;
        }
    }    
    
    public static function query($query, $bindData = false)
    {
        return self::getDriver()->query($query, $bindData);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace ntentan\atiaa;
4
5			class Db
6			{
7			private static $db;
8			private static $defaultSettings;
9
10			/**
11			*
12			* @return Driver
13			*/
14			public static function getDriver()
15			{
16			if(self::$db == null) {
17			self::$db = \ntentan\atiaa\Driver::getConnection(self::$defaultSettings);
18			self::$db->setCleanDefaults(true);
19
20			try {
21			self::$db->getPDO()->setAttribute(\PDO::ATTR_AUTOCOMMIT, false);
22			} catch (\PDOException $e) {
23			// Just do nothing for drivers which do not allow turning off autocommit
24			}
25			}
26			return self::$db;
27			}
28
29			/**
30			* Set the settings used for creating default datastores.
31			* @param array $settings
32			*/
33			public static function setDefaultSettings($settings)
34			{
35			self::$defaultSettings = $settings;
36			}
37
38			public static function getDefaultSettings()
39			{
40			return self::$defaultSettings;
41			}
42
43			public static function reset()
44			{
45			if(self::$db !== null) {
46			self::$db->disconnect();
47			self::$db = null;
48			}
49			}
50
51			public static function query($query, $bindData = false)
52			{
53			return self::getDriver()->query($query, $bindData);
			0 ignored issues – show Documentation introduced 2015-12-16 14:00 UTC by Report Bug Copy Issue Report `$bindData` is of type `boolean`, but the function expects a `false\|array<integer,*>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			}
55			}
56

ntentan / atiaa

Push — master ( f2dd2e...a32d5e )

Db::getDriver() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like