ntentan\atiaa\descriptors\PostgresqlDescriptor

Complexity

Total Complexity

13

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

96.88%

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	cleanDefaultValue()	0	33	6
A	getIndices()	0	28	1
A	getForeignKeys()	0	30	1
A	getSchemata()	0	10	1
A	hasAutoIncrementingKey()	0	14	4

<?php
namespace ntentan\atiaa\descriptors;

class PostgresqlDescriptor extends InformationSchemaDescriptor
{   

The opening class brace should be on a newline by itself.

    protected function cleanDefaultValue($defaultValue) 

The return type could not be reliably inferred; please add a @return annotation.

    {
        // Deal with typecasts
        if(preg_match("/(?<value>.*)(::)(?<type>[a-zA-Z0-9\s]*)$/", $defaultValue, $matches)) {
            
            $value = $matches['value'];
            
            // If numeric
            if(is_numeric($value)) {
                return $value;
                
            // If its a string
            } else if (preg_match("/'(?<string>.*)'/", $value, $matches)) {
                return $matches['string'];
                
            // null for anything else

38% of this comment could be valid code. Did you maybe forget this after debugging?

            } else {
                return null;
            }
        
        // Return the nextval as atiaa uses them to detect auto keys
        } else if(preg_match("/nextval\(.*/", $defaultValue)) {
            return $defaultValue;
            
        // Return numeric default values
        } else if(is_numeric($defaultValue)) {
            return $defaultValue;
            
        // Return null for anything else

40% of this comment could be valid code. Did you maybe forget this after debugging?

        } else {
            return null;
        }
    }

    /**
     * 
     * @note Query sourced from http://stackoverflow.com/questions/2204058/show-which-columns-an-index-is-on-in-postgresql
     * @param type $table
     * @return type
     */
    protected function getIndices(&$table)
    {
        return $this->driver->query(
            sprintf("select
                        t.relname as table_name,
                        i.relname as name,
                        a.attname as column
                    from
                        pg_class t,
                        pg_class i,
                        pg_index ix,
                        pg_attribute a,
                        pg_namespace n
                    where
                        t.oid = ix.indrelid
                        and i.oid = ix.indexrelid
                        and a.attrelid = t.oid
                        and a.attnum = ANY(ix.indkey)
                        and t.relkind = 'r'
                        and t.relname = '%s'
                        and n.nspname = '%s'
                        and i.relnamespace = n.oid
                            AND indisunique != 't'
                            AND indisprimary != 't'
                        order by i.relname, a.attname", 
            $table['name'], $table['schema'])
        );        
    }
    
    /**
     * @note Query sourced from http://stackoverflow.com/questions/1152260/postgres-sql-to-list-table-foreign-keys
     * @param type $table
     */
    protected function getForeignKeys(&$table)
    {
        return $this->driver->query(
            "SELECT distinct
                kcu.constraint_name as name,
                kcu.table_schema as schema,
                kcu.table_name as table, 
                kcu.column_name as column, 
                ccu.table_name AS foreign_table,
                ccu.table_schema AS foreign_schema,
                ccu.column_name AS foreign_column,
                rc.update_rule as on_update,
                rc.delete_rule as on_delete

            FROM 
                information_schema.table_constraints AS tc 
                JOIN information_schema.key_column_usage AS kcu
                  ON tc.constraint_name = kcu.constraint_name and tc.table_schema = kcu.table_schema and tc.table_name = kcu.table_name 
                JOIN information_schema.constraint_column_usage AS ccu
                  ON ccu.constraint_name = tc.constraint_name   and ccu.constraint_schema = tc.table_schema
                JOIN information_schema.referential_constraints AS rc
                  ON rc.constraint_name = tc.constraint_name and rc.constraint_schema = tc.table_schema
            WHERE constraint_type = 'FOREIGN KEY' 
                AND tc.table_name=:name AND tc.table_schema=:schema
                AND kcu.table_name=:name AND kcu.table_schema=:schema
                order by kcu.constraint_name, kcu.column_name",
                //$table['name'], $table['schema']

90% of this comment could be valid code. Did you maybe forget this after debugging?

                array('name'=>$table['name'], 'schema'=>$table['schema'])
        );
    }
    
    public function getSchemata()
    {
        return $this->driver->query(
            "select schema_name as name from information_schema.schemata 
            where schema_name not like 'pg_temp%' and 
            schema_name not like 'pg_toast%' and 
            schema_name not in ('pg_catalog', 'information_schema')
            order by schema_name"
        );
    }

    protected function hasAutoIncrementingKey(&$table)
    {
        $auto = false;
        $primaryKey = reset($table['primary_key']);
        if(is_array($primaryKey))
        {
            if(count($primaryKey) == 1 && substr_count($table['columns'][$primaryKey['columns'][0]]['default'], 'nextval'))
            {
                $table['columns'][$primaryKey['columns'][0]]['default'] = null;
                $auto = true;
            }
        }
        return $auto;
    }
}