nstdio\svg\traits\ChildTrait

Complexity

Total Complexity

17

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getChild()	0	15	4
A	getChildById()	0	19	6
A	getFirstChild()	0	8	2
A	hasChild()	0	4	1
A	getChildren()	0	4	1
A	getChildAtIndex()	0	4	1
A	removeChild()	0	11	2

<?php
namespace nstdio\svg\traits;


use nstdio\svg\container\ContainerInterface;
use nstdio\svg\ElementInterface;
use nstdio\svg\ElementStorage;
use nstdio\svg\SVGElement;
use nstdio\svg\XMLDocumentInterface;

/**
 * Class ChildTrait
 *
 * @package nstdio\svg\traits
 * @author  Edgar Asatryan <nstdio@gmail.com>
 */
trait ChildTrait
{
    /**
     * @var ElementStorage
     */
    protected $child;

    /**
     * @param string $name
     *
     * @return ContainerInterface[]
     */
    public function getChild($name)
    {
        $find = [];
        /** @var ContainerInterface $item */
        foreach ($this->child as $item) {
            if (strtolower($item->getName()) === strtolower($name)) {
                $find[] = $item;
            }
            if ($item->hasChild()) {
                $find = array_merge($find, $item->getChild($name));
            }
        }

        return $find;
    }

    /**
     * @param $id
     *
     * @return ContainerInterface
     */
    public function getChildById($id)
    {
        $find = null;
        /** @var ContainerInterface|SVGElement $item */
        foreach ($this->child as $item) {
            if ($item->id === $id) {
                $find = $item;
            }
        }
        if ($find === null) {
            foreach ($this->child as $item) {
                if ($item->hasChild()) {
                    $find = $item->getChildById($id);
                }
            }
        }

        return $find;
    }

    /**
     * @return ContainerInterface|null
     */
    public function getFirstChild()
    {
        if (!$this->hasChild()) {
            return null;
        }

        return $this->child[0];
    }

    /**
     * @return bool
     */
    public function hasChild()
    {
        return count($this->child) > 0;
    }

    /**
     * @return ContainerInterface[]|ElementStorage
     */
    public function getChildren()
    {
        return $this->child;
    }

    /**
     * @param $index
     *
     * @return ContainerInterface|SVGElement|null
     */
    public function getChildAtIndex($index)
    {
        return $this->child[$index];
    }

    /**
     * @param ElementInterface $child
     */
    public function removeChild(ElementInterface $child)
    {
        $this->child->remove($child);
        /** @var XMLDocumentInterface $element */
        $element = $this->getElement();

It seems like getElement() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($element instanceof \DOMNode) {
            $element->removeChild($child->getElement()->getElement());

The method getElement does only exist in nstdio\svg\XMLDocumentInterface and nstdio\svg\container\ContainerInterface, but not in DOMElement.

        } else {
            $element->removeNode($child->getElement());

It seems like $child->getElement() targeting nstdio\svg\ElementInterface::getElement() can also be of type object<DOMElement> or object<nstdio\svg\container\ContainerInterface>; however, nstdio\svg\XMLDocumentInterface::removeNode() does only seem to accept object<nstdio\svg\XMLDocumentInterface>, maybe add an additional type check?

        }
    }
}