nstdio\svg\gradient\Gradient

Complexity

Total Complexity

4

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	appendStop()	0	7	2

<?php
namespace nstdio\svg\gradient;

use nstdio\svg\ElementInterface;
use nstdio\svg\SVGElement;
use nstdio\svg\util\Identifier;

/**
 * Class Gradient
 *
 * @package nstdio\svg\gradient
 * @author  Edgar Asatryan <nstdio@gmail.com>
 */
abstract class Gradient extends SVGElement
{
    const LINEAR = 'linear';

    const RADIAL = 'radial';

    /**
     * Gradient constructor.
     *
     * @param ElementInterface $parent
     * @param null|string      $id
     */
    public function __construct(ElementInterface $parent, $id = null)
    {
        $defs = self::getDefs($parent);
        parent::__construct($defs);

It seems like $defs defined by self::getDefs($parent) on line 28 can be null; however, nstdio\svg\SVGElement::__construct() does not accept null, maybe add an additional type check?

        $this->id = $id === null ? Identifier::random('__gradient', 4) : $id;
    }

    /**
     * Multiply argument can be passed.
     *
     * @param Stop $stop
     */
    public function appendStop(Stop $stop)

The parameter $stop is not used and could be removed.

    {
        $stop = func_get_args();
        foreach ($stop as $item) {
            $this->append($item);
        }
    }
}