Issues in EmailValidation.php (master) - Issues in master - nstack-io/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (17)

src/Models/EmailValidation.php (1 issue)

Labels

Bug 1
Documentation 1

Severity

Minor 1

<?php

namespace NStack\Models;

/**
 * Class EmailValidation
 *
 * @package NStack\Models
 * @author  Tiago Araujo <[email protected]>
 */
class EmailValidation extends Model
{
    /** @var boolean */
    protected $ok;

    /**
     * parse
     *
     * @param array $data
     * @author Tiago Araujo <[email protected]>
     */
    public function parse(array $data)
    {
        $this->ok = (int)$data['ok'];
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * toArray
     *
     * @return array
     * @author Tiago Araujo <[email protected]>
     */
    public function toArray(): array
    {
        return ['ok' => $this->ok];
    }

    /**
     * @return bool
     */
    public function isOk(): bool
    {
        return $this->ok;
    }
}

1		<?php
2
3		namespace NStack\Models;
4
5		/**
6		* Class EmailValidation
7		*
8		* @package NStack\Models
9		* @author Tiago Araujo <[email protected]>
10		*/
11		class EmailValidation extends Model
12		{
13		/** @var boolean */
14		protected $ok;
15
16		/**
17		* parse
18		*
19		* @param array $data
20		* @author Tiago Araujo <[email protected]>
21		*/
22	1	public function parse(array $data)
23		{
24	1	$this->ok = (int)$data['ok'];
		0 ignored issues – show Documentation Bug introduced 2019-09-09 16:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$ok` was declared of type `boolean`, but `(int)$data['ok']` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
25	1	}
26
27		/**
28		* toArray
29		*
30		* @return array
31		* @author Tiago Araujo <[email protected]>
32		*/
33		public function toArray(): array
34		{
35		return ['ok' => $this->ok];
36		}
37
38		/**
39		* @return bool
40		*/
41		public function isOk(): bool
42		{
43		return $this->ok;
44		}
45		}

GitHub Access Token became invalid

Issues (17)

src/Models/EmailValidation.php (1 issue)

Labels

Severity

Introduced By

nstack-io / php-sdk

GitHub Access Token became invalid

Issues (17)

src/Models/EmailValidation.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like