File::parse() - Code Metrics - Inspection of "Merge pull request #11 from nstack-io/develop" - nstack-io/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 579a75...556562 )

by Casper

created 2019-09-03 17:55 UTC

File::parse() A

↳ Parent: File

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	12
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	14
rs	9.8666
ccs	13
cts	13
cp	1
crap	1

<?php

namespace NStack\Models;

/**
 * Class File
 *
 * @package NStack\Models
 * @author  Tiago Araujo <[email protected]>
 */
class File extends Model
{
    /** @var int */
    protected $id;

    /** @var string */
    protected $name;

    /** @var string */
    protected $tags;

    /** @var string */
    protected $privacy;

    /** @var string */
    protected $goneAt;

    /** @var string */
    protected $mime;

    /** @var int */
    protected $size;

    /** @var string */
    protected $password;

    /** @var string */
    protected $url;

    /** @var string */
    protected $cdnUrl;

    /** @var string */
    protected $showUrl;

    /** @var string */
    protected $downloadUrl;

    /**
     * parse
     *
     * @param array $data
     */
    public function parse(array $data)
    {
        $this->id           = (int)$data['id'];
        $this->name         = (string)$data['name'];
        $this->tags         = (string)$data['tags'];
        $this->privacy      = (string)$data['privacy'];
        $this->goneAt       = (string)$data['gone_at'];
        $this->size         = (string)$data['size'];
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->mime         = (string)$data['mime'];
        $this->password     = (string)$data['password'];
        $this->url          = (string)$data['url'];
        $this->cdnUrl       = (string)$data['cdn_url'];
        $this->showUrl      = (string)$data['show_url'];
        $this->downloadUrl  = (string)$data['download_url'];
    }

    /**
     * toArray
     *
     * @return array
     */
    public function toArray(): array
    {
        return [
            'id'            => $this->id,
            'name'          => $this->name,
            'tags'          => $this->tags,
            'privacy'       => $this->privacy,
            'gone_at'       => $this->goneAt,
            'size'          => $this->size,
            'password'      => $this->password,
            'url'           => $this->url,
            'cdn_url'       => $this->cdnUrl,
            'show_url'      => $this->showUrl,
            'download_url'  => $this->downloadUrl,
            'mime'          => $this->mime,
        ];
    }

}

1		<?php
2
3		namespace NStack\Models;
4
5		/**
6		* Class File
7		*
8		* @package NStack\Models
9		* @author Tiago Araujo <[email protected]>
10		*/
11		class File extends Model
12		{
13		/** @var int */
14		protected $id;
15
16		/** @var string */
17		protected $name;
18
19		/** @var string */
20		protected $tags;
21
22		/** @var string */
23		protected $privacy;
24
25		/** @var string */
26		protected $goneAt;
27
28		/** @var string */
29		protected $mime;
30
31		/** @var int */
32		protected $size;
33
34		/** @var string */
35		protected $password;
36
37		/** @var string */
38		protected $url;
39
40		/** @var string */
41		protected $cdnUrl;
42
43		/** @var string */
44		protected $showUrl;
45
46		/** @var string */
47		protected $downloadUrl;
48
49		/**
50		* parse
51		*
52		* @param array $data
53		*/
54	2	public function parse(array $data)
55		{
56	2	$this->id = (int)$data['id'];
57	2	$this->name = (string)$data['name'];
58	2	$this->tags = (string)$data['tags'];
59	2	$this->privacy = (string)$data['privacy'];
60	2	$this->goneAt = (string)$data['gone_at'];
61	2	$this->size = (string)$data['size'];
		0 ignored issues – show Documentation Bug introduced 2019-09-03 17:56 UTC by Report Bug Copy Issue Report The property `$size` was declared of type `integer`, but `(string)$data['size']` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
62	2	$this->mime = (string)$data['mime'];
63	2	$this->password = (string)$data['password'];
64	2	$this->url = (string)$data['url'];
65	2	$this->cdnUrl = (string)$data['cdn_url'];
66	2	$this->showUrl = (string)$data['show_url'];
67	2	$this->downloadUrl = (string)$data['download_url'];
68	2	}
69
70		/**
71		* toArray
72		*
73		* @return array
74		*/
75		public function toArray(): array
76		{
77		return [
78		'id' => $this->id,
79		'name' => $this->name,
80		'tags' => $this->tags,
81		'privacy' => $this->privacy,
82		'gone_at' => $this->goneAt,
83		'size' => $this->size,
84		'password' => $this->password,
85		'url' => $this->url,
86		'cdn_url' => $this->cdnUrl,
87		'show_url' => $this->showUrl,
88		'download_url' => $this->downloadUrl,
89		'mime' => $this->mime,
90		];
91		}
92
93		}

nstack-io / php-sdk

GitHub Access Token became invalid

Push — master ( 579a75...556562 )

File::parse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like