VersionUpdate::parse() - Code Metrics - Inspection of "Merge pull request #16 from nstack-io/develop" - nstack-io/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 550dab...bc8237 )

by Casper

created 2019-09-09 16:21 UTC

VersionUpdate::parse() A

↳ Parent: VersionUpdate

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	8
ccs	0
cts	7
cp	0
crap	2
rs	10

<?php

namespace NStack\Models;

/**
 * Class VersionUpdate
 *
 * @package NStack\Models
 * @author  Tiago Araujo <[email protected]>
 */
class VersionUpdate extends Model
{
    /** @var int */
    protected $id;

    /** @var String */
    protected $version;

    /** @var String */
    protected $update;

    /** @var bool */
    protected $newInVersion;

    /** @var String */
    protected $changeLog;

    /** @var String */
    protected $fileUrl;

    /**
     * parse
     *
     * @param array $data
     */
    public function parse(array $data)
    {
        $this->id = (String)$data['id'];
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->version = (array)$data['version'];

        $this->update = (string)$data['update'];
        $this->newInVersion = (array)$data['new_in_version'];

        $this->changeLog = (array)$data['change_log'];

        $this->fileUrl = (array)$data['file_url'];

    }

    /**
     * toArray
     *
     * @return array
     * @author Casper Rasmussen <[email protected]>
     */
    public function toArray(): array
    {
        return [
            'id' => $this->id,
            'version' => $this->version,
            'update' => $this->update,
            'new_in_version' => $this->newInVersion,
            'change_log' => $this->changeLog,
            'file_url' => $this->fileUrl,
        ];
    }


}

1			<?php
2
3			namespace NStack\Models;
4
5			/**
6			* Class VersionUpdate
7			*
8			* @package NStack\Models
9			* @author Tiago Araujo <[email protected]>
10			*/
11			class VersionUpdate extends Model
12			{
13			/** @var int */
14			protected $id;
15
16			/** @var String */
17			protected $version;
18
19			/** @var String */
20			protected $update;
21
22			/** @var bool */
23			protected $newInVersion;
24
25			/** @var String */
26			protected $changeLog;
27
28			/** @var String */
29			protected $fileUrl;
30
31			/**
32			* parse
33			*
34			* @param array $data
35			*/
36			public function parse(array $data)
37			{
38			$this->id = (String)$data['id'];
			0 ignored issues – show Documentation Bug introduced 2019-09-09 16:23 UTC by Report Bug Copy Issue Report The property `$id` was declared of type `integer`, but `(string)$data['id']` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
39			$this->version = (array)$data['version'];
			0 ignored issues – show Documentation Bug introduced 2019-09-09 16:23 UTC by Report Bug Copy Issue Report It seems like `(array)$data['version']` of type `array` is incompatible with the declared type `string` of property `$version`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
40			$this->update = (string)$data['update'];
41			$this->newInVersion = (array)$data['new_in_version'];
			0 ignored issues – show Documentation Bug introduced 2019-09-09 16:23 UTC by Report Bug Copy Issue Report It seems like `(array)$data['new_in_version']` of type `array` is incompatible with the declared type `boolean` of property `$newInVersion`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
42			$this->changeLog = (array)$data['change_log'];
			0 ignored issues – show Documentation Bug introduced 2019-09-09 16:23 UTC by Report Bug Copy Issue Report It seems like `(array)$data['change_log']` of type `array` is incompatible with the declared type `string` of property `$changeLog`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
43			$this->fileUrl = (array)$data['file_url'];
			0 ignored issues – show Documentation Bug introduced 2019-09-09 16:23 UTC by Report Bug Copy Issue Report It seems like `(array)$data['file_url']` of type `array` is incompatible with the declared type `string` of property `$fileUrl`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
44			}
45
46			/**
47			* toArray
48			*
49			* @return array
50			* @author Casper Rasmussen <[email protected]>
51			*/
52			public function toArray(): array
53			{
54			return [
55			'id' => $this->id,
56			'version' => $this->version,
57			'update' => $this->update,
58			'new_in_version' => $this->newInVersion,
59			'change_log' => $this->changeLog,
60			'file_url' => $this->fileUrl,
61			];
62			}
63
64
65			}

nstack-io / php-sdk

GitHub Access Token became invalid

Push — master ( 550dab...bc8237 )

VersionUpdate::parse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like