Completed
Pull Request — master (#170)
by Luke
02:40
created
src/CSVelte/Collection/AbstractCollection.php 3 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 
16 16
 use ArrayAccess;
17 17
 use ArrayIterator;
18
-use BadMethodCallException;
19 18
 use Countable;
20 19
 use InvalidArgumentException;
21 20
 use Iterator;
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
      *
166 166
      * @return mixed
167 167
      */
168
-    public function current ()
168
+    public function current()
169 169
     {
170 170
         return current($this->data);
171 171
     }
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
      *
178 178
      * @return mixed
179 179
      */
180
-    public function key ()
180
+    public function key()
181 181
     {
182 182
         return key($this->data);
183 183
     }
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
      *
192 192
      * @return mixed
193 193
      */
194
-    public function next ()
194
+    public function next()
195 195
     {
196 196
         $next = next($this->data);
197 197
         $key = key($this->data);
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
      *
211 211
      * @return mixed
212 212
      */
213
-    public function rewind ()
213
+    public function rewind()
214 214
     {
215 215
         $this->isValid = true;
216 216
         return reset($this->data);
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      *
224 224
      * @return bool True if internal pointer isn't past the end
225 225
      */
226
-    public function valid ()
226
+    public function valid()
227 227
     {
228 228
         return $this->isValid;
229 229
     }
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
             return $this->data[$index];
293 293
         }
294 294
         if ($throw) {
295
-            throw new OutOfBoundsException(__CLASS__ . " could not find value at index " . $index);
295
+            throw new OutOfBoundsException(__CLASS__." could not find value at index ".$index);
296 296
         }
297 297
         return $default;
298 298
     }
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
             unset($this->data[$index]);
333 333
         } else {
334 334
             if ($throw) {
335
-                throw new OutOfBoundsException('No value found at given index: ' . $index);
335
+                throw new OutOfBoundsException('No value found at given index: '.$index);
336 336
             }
337 337
         }
338 338
 
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
     public function pairs()
622 622
     {
623 623
         return static::factory(array_map(
624
-            function ($key, $val) {
624
+            function($key, $val) {
625 625
                 return [$key, $val];
626 626
             },
627 627
             array_keys($this->data),
@@ -766,7 +766,7 @@  discard block
 block discarded – undo
766 766
                 }
767 767
 
768 768
                 if (method_exists($val, '__toString')) {
769
-                    $val = (string)$val;
769
+                    $val = (string) $val;
770 770
                 } else {
771 771
                     $val = spl_object_hash($val);
772 772
                 }
@@ -815,7 +815,7 @@  discard block
 block discarded – undo
815 815
     protected function assertCorrectInputDataType($data)
816 816
     {
817 817
         if (!$this->isConsistentDataStructure($data)) {
818
-            throw new InvalidArgumentException(__CLASS__ . ' expected traversable data, got: ' . gettype ($data));
818
+            throw new InvalidArgumentException(__CLASS__.' expected traversable data, got: '.gettype($data));
819 819
         }
820 820
     }
821 821
 
@@ -859,7 +859,7 @@  discard block
 block discarded – undo
859 859
                 }
860 860
             }
861 861
             // if row contains an array it isn't tabular
862
-            if (array_reduce($row, function($carry, $item){
862
+            if (array_reduce($row, function($carry, $item) {
863 863
                 return is_array($item) && $carry;
864 864
             }, true)) {
865 865
                 return false;
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
      * also optionally throw an OutOfBoundsException if no value is found.
283 283
      *
284 284
      * @param mixed $index The index of the data you want to get
285
-     * @param mixed $default The default value to return if none available
285
+     * @param null|integer $default The default value to return if none available
286 286
      * @param bool $throw True if you want an exception to be thrown if no data found at $index
287 287
      * @throws OutOfBoundsException If $throw is true and $index isn't found
288 288
      * @return mixed The data found at $index or failing that, the $default
@@ -547,7 +547,7 @@  discard block
 block discarded – undo
547 547
      * Returns a new collection with $items added.
548 548
      *
549 549
      * @param array $items Any number of arguments will be pushed onto the
550
-     * @return mixed The first item in this collection
550
+     * @return AbstractCollection The first item in this collection
551 551
      */
552 552
     public function push(...$items)
553 553
     {
@@ -560,7 +560,7 @@  discard block
 block discarded – undo
560 560
      *
561 561
      * Returns a new collection with $items added.
562 562
      *
563
-     * @return mixed The first item in this collection
563
+     * @return AbstractCollection The first item in this collection
564 564
      */
565 565
     public function unshift(...$items)
566 566
     {
@@ -616,7 +616,7 @@  discard block
 block discarded – undo
616 616
     /**
617 617
      * Iterate over each item that matches criteria in callback
618 618
      *
619
-     * @param Closure|callable $callback A callback to use
619
+     * @param Closure $callback A callback to use
620 620
      * @param object $bindTo The object to bind to
621 621
      * @return AbstractCollection
622 622
      */
@@ -724,7 +724,7 @@  discard block
 block discarded – undo
724 724
     /**
725 725
      * Returns collection in reverse order.
726 726
      *
727
-     * @param null $preserveKeys True if you want to preserve collection's keys
727
+     * @param boolean $preserveKeys True if you want to preserve collection's keys
728 728
      * @return AbstractCollection This collection in reverse order.
729 729
      */
730 730
     public function reverse($preserveKeys = null)
Please login to merge, or discard this patch.
src/CSVelte/Collection/TabularCollection.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
             return static::factory($values);
65 65
         }
66 66
         if ($throw) {
67
-            throw new OutOfBoundsException(__CLASS__ . " could not find column: " . $column);
67
+            throw new OutOfBoundsException(__CLASS__." could not find column: ".$column);
68 68
         }
69 69
         return false;
70 70
     }
@@ -169,6 +169,6 @@  discard block
 block discarded – undo
169 169
                 return call_user_func_array([$column, $method], $args);
170 170
             }
171 171
         }
172
-        throw new BadMethodCallException("Method does not exist: " . __CLASS__ . "::{$method}()");
172
+        throw new BadMethodCallException("Method does not exist: ".__CLASS__."::{$method}()");
173 173
     }
174 174
 }
175 175
\ No newline at end of file
Please login to merge, or discard this patch.