CSVelte\Sniffer\SniffDelimiterByDistribution::sniff()

Complexity

Conditions	2
Paths	2

Size

Total Lines

26

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	2

Importance

Changes

0

<?php
    public function sniff($data)
    {
        $lineTerminator = $this->getOption('lineTerminator') ?: "\n";
        $delimiters = $this->getOption('delimiters');
        $lines = collect(explode($lineTerminator, $this->removeQuotedStrings($data)));
        return collect($delimiters)->flip()->map(function($x, $char) use ($lines) {

The expression \Noz\collect($delimiters)->flip()->map(function ($x, $char) use($lines) { $sd = $lines->map(function ($line, $line_no) use($char) { $delimited = \Noz\collect(\Stringy\create($line)->split($char))->map(function ($str) { return $str->length(); }); $avg = $delimited->average(); return sqrt($delimited->fold(function ($d, $len) use($avg) { return $d->add(pow($len - $avg, 2)); }, new \Noz\Collection\Collection())->sum() / $delimited->count()); }); return $sd->average(); })->sort()->getKeyAt(1); of type integer|string adds the type integer to the return on line 36 which is incompatible with the return type declared by the abstract method CSVelte\Sniffer\AbstractSniffer::sniff of type string|string[].

                // standard deviation
                $sd = $lines->map(function($line, $line_no) use ($char) {

The parameter $line_no is not used and could be removed.

                    $delimited = collect(s($line)->split($char))
                        ->map(function($str) {
                            return $str->length();
                        });
                    // standard deviation
                    $avg = $delimited->average();
                    return sqrt($delimited->fold(function($d, $len) use ($avg) {
                            return $d->add(pow($len - $avg, 2));
                        }, new Collection)
                            ->sum() / $delimited->count());
                });
                return $sd->average();

            })
            ->sort()
            ->getKeyAt(1);
    }
}