Completed
Pull Request — master (#76)
by Luke
02:26
created
src/functions.php 3 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 {
172 172
     $type = gettype($data);
173 173
     if ($meta) {
174
-        switch($type) {
174
+        switch ($type) {
175 175
             case 'object':
176 176
                 $class = get_class($data);
177 177
                 return "{$type} <{$class}>";
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
                 return "{$type} <{$restype}>";
181 181
         }
182 182
     } else {
183
-        switch($type) {
183
+        switch ($type) {
184 184
             case 'object':
185 185
                 return get_class($data);
186 186
             case 'resource':
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
     } else {
271 271
         echo $label . "\n" . implode(
272 272
                 array_map(
273
-                    function () {
273
+                    function() {
274 274
                         return '-';
275 275
                     },
276 276
                     str_split($label)
Please login to merge, or discard this patch.
Indentation   -7 removed lines patch added patch discarded remove patch
@@ -55,10 +55,8 @@  discard block
 block discarded – undo
55 55
 
56 56
 /**
57 57
  * Underscore function.
58
-
59 58
  * This function is meant to work sort of like jQuery's "$()". It is a contextual catch-all type function. It works
60 59
  * as a short-hand alias for invoke, collect, and with.
61
-
62 60
  * @param callable|mixed    $in
63 61
  * @param mixed ...         $_
64 62
  *
@@ -136,10 +134,8 @@  discard block
 block discarded – undo
136 134
  *
137 135
  * Accepts any kind of data and converts it to an array. If strict mode is on, only data that returns true from
138 136
  * is_arrayable() will be converted to an array. Anything else will cause an InvalidArgumentException to be thrown.
139
-
140 137
  * @param mixed $data   Data to convert to array
141 138
  * @param bool  $strict Whether to use strict mode
142
-
143 139
  * @return array
144 140
  *
145 141
  * @throws InvalidArgumentException
@@ -245,12 +241,9 @@  discard block
 block discarded – undo
245 241
  * Provided with the requested offset, whether it be a string, an integer (positive or negative), or some type of
246 242
  * object, this function will normalize it to a positive integer offset or, failing that, it will throw an exception.
247 243
  * A negative offset will require either the traversable that is being indexed or its total count in order to normalize
248
-
249 244
  * @param int|mixed $offset The offset to normalize
250 245
  * @param int|array|traversable $count  Either the traversable count, or the traversable itself.
251
-
252 246
  * @return int
253
-
254 247
  * @throws RuntimeException If offset cannot be normalized
255 248
  * @throws InvalidArgumentException If offset is negative and count is not provided
256 249
  */
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -10 removed lines patch added patch discarded remove patch
@@ -9,24 +9,15 @@
 block discarded – undo
9 9
  */
10 10
 namespace Noz;
11 11
 
12
-use Closure;
13 12
 use Illuminate\Support\Str;
14 13
 use InvalidArgumentException;
15 14
 use Iterator;
15
+use Noz\Contracts\CollectionInterface;
16 16
 use Noz\Immutable\Collection;
17 17
 use Noz\Immutable\Sequence;
18
-use Noz\Contracts\CollectionInterface;
19 18
 use RuntimeException;
20
-use Serializable;
21 19
 use Traversable;
22 20
 
23
-use Symfony\Component\Serializer\Serializer;
24
-use Symfony\Component\Serializer\Encoder\XmlEncoder;
25
-use Symfony\Component\Serializer\Encoder\JsonEncoder;
26
-use Symfony\Component\Serializer\Encoder\YamlEncoder;
27
-use Symfony\Component\Serializer\Encoder\CsvEncoder;
28
-use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
29
-
30 21
 /**
31 22
  * Collection factory.
32 23
  *
Please login to merge, or discard this patch.
src/Contracts/CollectionInterface.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -491,7 +491,6 @@
 block discarded – undo
491 491
      *
492 492
      * Reduces this collection to one value by passing value, key, and the return value from the previous iteration
493 493
      * until only one value remains. Iteration begins from the last item in the collection and moves up.
494
-
495 494
      * @param callable $callback The callback function
496 495
      * @param          $initial  The initial "carry" value
497 496
      *
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      * @param string|int $index Set value at this index
63 63
      * @param mixed      $value Set this value at index
64 64
      *
65
-     * @return mixed
65
+     * @return CollectionInterface
66 66
      */
67 67
     public function set($index, $value);
68 68
 
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
      *
74 74
      * @param string|int $index Delete item at this index
75 75
      *
76
-     * @return mixed
76
+     * @return CollectionInterface
77 77
      */
78 78
     public function delete($index);
79 79
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
      * @param string|int $index Add value at this index
109 109
      * @param mixed      $value Add this value at index
110 110
      *
111
-     * @return mixed
111
+     * @return CollectionInterface
112 112
      */
113 113
     public function add($index, $value);
114 114
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      * @param int  $nth    The number of items between cycles
165 165
      * @param null $offset An optional offset to begin from
166 166
      *
167
-     * @return mixed
167
+     * @return CollectionInterface
168 168
      */
169 169
     public function nth($nth, $offset = null);
170 170
 
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
      *
229 229
      * @param int $num Number of items to return
230 230
      *
231
-     * @return mixed|CollectionInterface
231
+     * @return CollectionInterface
232 232
      */
233 233
     public function random($num);
234 234
 
Please login to merge, or discard this patch.
src/Traits/IsContainer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      */
31 31
     public function contains($value, $index = null)
32 32
     {
33
-        return (bool) $this->fold(function ($carry, $val, $key) use ($value, $index) {
33
+        return (bool) $this->fold(function($carry, $val, $key) use ($value, $index) {
34 34
             if ($carry) {
35 35
                 return $carry;
36 36
             }
Please login to merge, or discard this patch.
src/Traits/IsArrayable.php 1 patch
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -491,7 +491,6 @@
 block discarded – undo
491 491
      *
492 492
      * Reduces this collection to one value by passing value, key, and the return value from the previous iteration
493 493
      * until only one value remains. Iteration begins from the last item in the collection and moves up.
494
-
495 494
      * @param callable $callback The callback function
496 495
      * @param          $initial  The initial "carry" value
497 496
      *
Please login to merge, or discard this patch.
src/Immutable/Collection.php 3 patches
Unused Use Statements   +4 added lines, -7 removed lines patch added patch discarded remove patch
@@ -9,21 +9,18 @@
 block discarded – undo
9 9
  */
10 10
 namespace Noz\Collection;
11 11
 
12
-use InvalidArgumentException;
13
-use OutOfBoundsException;
14
-
15 12
 use ArrayIterator;
16 13
 use Countable;
14
+use InvalidArgumentException;
17 15
 use Iterator;
18
-use Traversable;
19
-
20 16
 use Noz\Contracts\Arrayable;
21
-use Noz\Contracts\Invokable;
22 17
 use Noz\Contracts\CollectionInterface;
23
-
18
+use Noz\Contracts\Invokable;
24 19
 use Noz\Traits\IsArrayable;
25 20
 use Noz\Traits\IsContainer;
26 21
 use Noz\Traits\IsSerializable;
22
+use OutOfBoundsException;
23
+use Traversable;
27 24
 
28 25
 use function
29 26
     Noz\is_traversable,
Please login to merge, or discard this patch.
Indentation   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -997,7 +997,7 @@  discard block
 block discarded – undo
997 997
             }
998 998
         });
999 999
         $args = $args->prepend($this->getData())
1000
-                     ->prepend(null);
1000
+                        ->prepend(null);
1001 1001
 
1002 1002
         return collect(
1003 1003
 //            array_map(
@@ -1185,11 +1185,9 @@  discard block
 block discarded – undo
1185 1185
 
1186 1186
     /**
1187 1187
      * Get the number of times each item occurs in the collection.
1188
-
1189 1188
      * This method will return a NumericCollection where keys are the
1190 1189
      * values and values are the number of times that value occurs in
1191 1190
      * the original collection.
1192
-
1193 1191
      * @return CollectionInterface
1194 1192
      */
1195 1193
     public function counts()
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -589,7 +589,7 @@  discard block
 block discarded – undo
589 589
     public function pairs()
590 590
     {
591 591
         return collect(array_map(
592
-            function ($key, $val) {
592
+            function($key, $val) {
593 593
                 return [$key, $val];
594 594
             },
595 595
             array_keys($this->getData()),
@@ -608,11 +608,11 @@  discard block
 block discarded – undo
608 608
     public function duplicates()
609 609
     {
610 610
         $dups = [];
611
-        $this->walk(function ($val, $key) use (&$dups) {
611
+        $this->walk(function($val, $key) use (&$dups) {
612 612
             $dups[$val][] = $key;
613 613
         });
614 614
 
615
-        return collect($dups)->filter(function ($val) {
615
+        return collect($dups)->filter(function($val) {
616 616
             return count($val) > 1;
617 617
         });
618 618
     }
@@ -899,7 +899,7 @@  discard block
 block discarded – undo
899 899
     public function split($num)
900 900
     {
901 901
         $count = $this->count();
902
-        $size = (int)($count / $num);
902
+        $size = (int) ($count / $num);
903 903
         $mod = $count % $num;
904 904
         return collect($this->fold(function($chunks, $val, $key, $iter) use ($num, $size, $mod) {
905 905
             $chunk_count = count($chunks);
Please login to merge, or discard this patch.
src/Immutable/Dict.php 1 patch
Unused Use Statements   +2 added lines, -9 removed lines patch added patch discarded remove patch
@@ -9,18 +9,11 @@
 block discarded – undo
9 9
  */
10 10
 namespace Noz\Collection;
11 11
 
12
-use BadMethodCallException;
13
-
14 12
 use Countable;
15
-use Noz\Contracts\Structure\Dictable;
16
-use Traversable;
17
-use SplFixedArray;
18
-
19
-use Noz\Contracts\Structure\Sequenceable;
20
-use Noz\Contracts\Immutable;
21 13
 use Noz\Contracts\Arrayable;
14
+use Noz\Contracts\Immutable;
22 15
 use Noz\Contracts\Invokable;
23
-
16
+use Noz\Contracts\Structure\Dictable;
24 17
 use Noz\Traits\IsImmutable;
25 18
 
26 19
 use function Noz\to_array;
Please login to merge, or discard this patch.
src/Immutable/LList.php 3 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
      *
206 206
      * @param callable|null $funk The callback
207 207
      *
208
-     * @return bool
208
+     * @return boolean|null
209 209
      */
210 210
     public function every(callable $funk = null)
211 211
     {
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
      *
225 225
      * @param callable|null $callback The callback
226 226
      *
227
-     * @return bool
227
+     * @return boolean|null
228 228
      */
229 229
     public function none(callable $callback = null)
230 230
     {
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
 
283 283
     /**
284 284
      * @param callable|null $folder
285
-     * @param null          $initial
285
+     * @param boolean          $initial
286 286
      *
287 287
      * @return null
288 288
      */
Please login to merge, or discard this patch.
Unused Use Statements   +7 added lines, -10 removed lines patch added patch discarded remove patch
@@ -9,21 +9,18 @@
 block discarded – undo
9 9
  */
10 10
 namespace Noz\Immutable;
11 11
 
12
-use InvalidArgumentException;
13
-
14 12
 use Countable;
15
-use Traversable;
16
-use Serializable;
17
-use SplDoublyLinkedList;
18
-
19
-use Noz\Contracts\Structure\Listable;
20
-use Noz\Contracts\Immutable;
13
+use InvalidArgumentException;
21 14
 use Noz\Contracts\Arrayable;
15
+use Noz\Contracts\Immutable;
22 16
 use Noz\Contracts\Invokable;
23
-
17
+use Noz\Contracts\Structure\Listable;
24 18
 use Noz\Traits\IsArrayable;
25
-use Noz\Traits\IsImmutable;
26 19
 use Noz\Traits\IsContainer;
20
+use Noz\Traits\IsImmutable;
21
+use Serializable;
22
+use SplDoublyLinkedList;
23
+use Traversable;
27 24
 
28 25
 use function
29 26
     Noz\is_traversable;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
         } else {
76 76
             $dll = new SplDoublyLinkedList($data);
77 77
             $dll->setIteratorMode(SplDoublyLinkedList::IT_MODE_KEEP);
78
-            foreach($data as $key => $val) {
78
+            foreach ($data as $key => $val) {
79 79
                 $dll->push($val);
80 80
             }
81 81
         }
Please login to merge, or discard this patch.
src/Immutable/Queue.php 1 patch
Unused Use Statements   +2 added lines, -9 removed lines patch added patch discarded remove patch
@@ -9,18 +9,11 @@
 block discarded – undo
9 9
  */
10 10
 namespace Noz\Collection;
11 11
 
12
-use BadMethodCallException;
13
-
14 12
 use Countable;
15
-use Noz\Contracts\Structure\Listable;
16
-use Traversable;
17
-use SplFixedArray;
18
-
19
-use Noz\Contracts\Structure\Sequenceable;
20
-use Noz\Contracts\Immutable;
21 13
 use Noz\Contracts\Arrayable;
14
+use Noz\Contracts\Immutable;
22 15
 use Noz\Contracts\Invokable;
23
-
16
+use Noz\Contracts\Structure\Listable;
24 17
 use Noz\Traits\IsImmutable;
25 18
 
26 19
 use function Noz\to_array;
Please login to merge, or discard this patch.
src/Immutable/Sequence.php 4 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
     /**
165 165
      * Return the key of the current element.
166 166
      *
167
-     * @return mixed|null
167
+     * @return integer
168 168
      */
169 169
     public function key()
170 170
     {
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
      * Fold (reduce) sequence into a single value.
377 377
      *
378 378
      * @param callable $funk    A callback function
379
-     * @param mixed    $initial Initial value for accumulator
379
+     * @param boolean    $initial Initial value for accumulator
380 380
      *
381 381
      * @return mixed
382 382
      */
Please login to merge, or discard this patch.
Unused Use Statements   +6 added lines, -11 removed lines patch added patch discarded remove patch
@@ -9,27 +9,22 @@
 block discarded – undo
9 9
  */
10 10
 namespace Noz\Immutable;
11 11
 
12
-use BadMethodCallException;
13
-use RuntimeException;
14
-
15
-use Iterator;
16 12
 use ArrayAccess;
13
+use BadMethodCallException;
17 14
 use Countable;
18
-use Serializable;
19
-use SplFixedArray;
20
-use Traversable;
21
-
22 15
 use Illuminate\Support\Str;
23
-
16
+use Iterator;
24 17
 use Noz\Contracts\Arrayable;
25 18
 use Noz\Contracts\Immutable;
26 19
 use Noz\Contracts\Invokable;
27 20
 use Noz\Contracts\Structure\Sequenceable;
28
-
21
+use Noz\Traits\IsArrayable;
29 22
 use Noz\Traits\IsContainer;
30 23
 use Noz\Traits\IsImmutable;
31
-use Noz\Traits\IsArrayable;
32 24
 use Noz\Traits\IsSerializable;
25
+use RuntimeException;
26
+use SplFixedArray;
27
+use Traversable;
33 28
 
34 29
 use function
35 30
     Noz\to_array,
Please login to merge, or discard this patch.
Indentation   +6 added lines, -10 removed lines patch added patch discarded remove patch
@@ -83,16 +83,12 @@  discard block
 block discarded – undo
83 83
 
84 84
     /**
85 85
      * Invoke sequence.
86
-
87 86
      * A sequence is invokable as if it were a function. This allows some pretty useful functionality such as negative
88 87
      * indexing, sub-sequence selection, etc. Basically, any way you invoke a sequence, you're going to get back either
89 88
      * a single value from the sequence or a subset of it.
90
-
91 89
      * @internal param mixed $funk Either a numerical offset (positive or negative), a range string (start:end), or a
92 90
      * callback to be used as a filter.
93
-
94 91
      * @return mixed
95
-
96 92
      * @todo Put all the slice logic into a helper function or several
97 93
      */
98 94
     public function __invoke()
@@ -360,12 +356,12 @@  discard block
 block discarded – undo
360 356
      *
361 357
      * @return Sequence
362 358
      */
363
-     public function prepend($item)
364
-     {
365
-         $arr = $this->getData();
366
-         array_unshift($arr, $item);
367
-         return new static($arr);
368
-     }
359
+        public function prepend($item)
360
+        {
361
+            $arr = $this->getData();
362
+            array_unshift($arr, $item);
363
+            return new static($arr);
364
+        }
369 365
 
370 366
     /**
371 367
      * Append item to collection.
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
             $count = $this->count();
104 104
             if (count($args)) {
105 105
                 // if there are more args...
106
-                $length =  array_shift($args);
106
+                $length = array_shift($args);
107 107
             }
108 108
             if (Str::contains($offset, static::SLICE_DELIM)) {
109 109
                 list($start, $length) = get_range_start_end($offset, $count);
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
413 413
     public function isEmpty(callable $funk = null)
414 414
     {
415 415
         if (!is_null($funk)) {
416
-            return $this->fold(function ($carry, $val) use ($funk) {
416
+            return $this->fold(function($carry, $val) use ($funk) {
417 417
                 return $carry && $funk($val);
418 418
             }, true);
419 419
         }
Please login to merge, or discard this patch.