NW\JsonRequestBundle\Tests\EventListener\RequestTransformerListenerTest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	129
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	createRequest()	0	6	1
A	notJsonContentTypes()	0	6	1
A	testTransformRequest()	0	10	1
A	testNotTransformOtherContentType()	0	9	1
A	testBadRequestResponse()	0	8	1
A	createGetResponseEventMock()	0	11	1
A	testNotReplaceRequestData()	0	9	1
A	testDoNotTransformRequestContainingScalarJsonValue()	0	10	1
A	jsonContentTypes()	0	5	1
A	setUp()	0	3	1
A	testNotReplaceRequestDataIfNullContent()	0	9	1

<?php

namespace NW\JsonRequestBundle\Tests\EventListener;

use NW\JsonRequestBundle\Tests\TestCase;
use NW\JsonRequestBundle\EventListener\RequestTransformerListener;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\RequestEvent;

class RequestTransformerListenerTest extends TestCase
{
    /**
     * @var RequestTransformerListener
     */
    private $listener;

    public function setUp(): void
    {
        $this->listener = new RequestTransformerListener();
    }

    /**
     * @param string $contentType
     *
     * @dataProvider jsonContentTypes
     */
    public function testTransformRequest(string $contentType): void
    {
        $data = ['foo' => 'bar'];
        $request = $this->createRequest($contentType, \json_encode($data));
        $event = $this->createGetResponseEventMock($request);

        $this->listener->onKernelRequest($event);

        $this->assertEquals($data, $event->getRequest()->request->all());
        $this->assertNull($event->getResponse());
    }

    /**
     * @param string $contentType
     *
     * @dataProvider jsonContentTypes
     */
    public function testDoNotTransformRequestContainingScalarJsonValue(string $contentType): void
    {
        $content = json_encode('foo');
        $request = $this->createRequest($contentType, $content);
        $event = $this->createGetResponseEventMock($request);

        $this->listener->onKernelRequest($event);

        $this->assertEquals([], $event->getRequest()->request->all());
        $this->assertEquals($content, $event->getRequest()->getContent());
    }

    public function testBadRequestResponse(): void
    {
        $request = $this->createRequest('application/json', '{maaan}');
        $event = $this->createGetResponseEventMock($request);

        $this->listener->onKernelRequest($event);

        $this->assertEquals(400, $event->getResponse()->getStatusCode());
    }

    /**
     * @param string $contentType
     *
     * @dataProvider notJsonContentTypes
     */
    public function testNotTransformOtherContentType(string $contentType): void
    {
        $request = $this->createRequest($contentType, 'some=body');
        $event = $this->createGetResponseEventMock($request);

        $this->listener->onKernelRequest($event);

        $this->assertEquals($request, $event->getRequest());
        $this->assertNull($event->getResponse());
    }

    public function testNotReplaceRequestData(): void
    {
        $request = $this->createRequest('application/json', '');
        $event = $this->createGetResponseEventMock($request);

        $this->listener->onKernelRequest($event);

        $this->assertEquals($request, $event->getRequest());
        $this->assertNull($event->getResponse());
    }

    public function testNotReplaceRequestDataIfNullContent(): void
    {
        $request = $this->createRequest('application/json', 'null');
        $event = $this->createGetResponseEventMock($request);

        $this->listener->onKernelRequest($event);

        $this->assertEquals($request, $event->getRequest());
        $this->assertNull($event->getResponse());
    }

    private function createGetResponseEventMock(Request $request): RequestEvent
    {
        $event = $this
            ->getMockBuilder(RequestEvent::class)
            ->disableOriginalConstructor()
            ->setMethods(['getRequest'])
            ->getMock();

        $event->expects($this->any())->method('getRequest')->will($this->returnValue($request));

        return $event;

The expression return $event returns the type PHPUnit\Framework\MockObject\MockObject which is incompatible with the type-hinted return Symfony\Component\HttpKernel\Event\RequestEvent.

    }

    private function createRequest(string $contentType, string $content): Request
    {
        $request = new Request([], [], [], [], [], [], $content);
        $request->headers->set('CONTENT_TYPE', $contentType);

        return $request;
    }

    public function jsonContentTypes(): array
    {
        return [
            ['application/json'],
            ['application/x-json'],
        ];
    }

    public function notJsonContentTypes(): array
    {
        return [
            ['application/x-www-form-urlencoded'],
            ['text/html'],
            ['text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8'],
        ];
    }
}