HtmlSerializer

Complexity

Total Complexity

7

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	4
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	serialize()	0	4	1
A	contentType()	0	3	1
A	recursive()	0	14	4
A	active()	0	3	1

<?php

/**
 * Serializer for html.
 * @author Christian Blank <c.blank@notthatbad.net>
 */
class HtmlSerializer extends ViewableData implements IRestSerializer {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * @config
     */
    private static $is_active = true;

The property $is_active is not used and could be removed.

    /**
     * The content type
     * @var string
     */
    private $contentType = "text/html";

    /**
     * The given data will be serialized into an html string using a Silverstripe template.
     *
     * @param array $data
     * @return string an html string

Should the return type not be HTMLText?

     */
    public function serialize($data) {
        $list = $this->recursive($data, 1);
        return $this->renderWith(['Result', 'Controller'], ['Data' => ArrayList::create($list)]);
    }

    public function contentType() {
        return $this->contentType;
    }

    private function recursive($data, $level) {
        $list = [];
        if(is_array($data)) {
            foreach ($data as $key => $value) {
                if(is_array($value)) {
                    $list[] = ArrayData::create(['Key' => $key, 'Value' => '', 'Heading' => true, 'Level' => $level]);
                    $list = array_merge($list, $this->recursive($value, $level+1));
                } else {
                    $list[] = ArrayData::create(['Key' => $key, 'Value' => $value, 'Level' => $level]);
                }
            }
        }
        return $list;
    }

    /**
     * Indicates if the serializer is active.
     * Serializers can be deactivated to use another implementation for the same mime type.
     *
     * @return boolean

Should the return type not be array|integer|double|string|boolean?

     */
    public function active() {
        return $this->config()->get('is_active');
    }
}